Re: Looking for a sponsor for a new game 'curseofwar'

Hi Markus and everyone.

Thanks a lot for your feedback. It's was very very helpfull for me.

Thanks for ~/.lintianrc. I used lintian for source and didn't guess to try it on bin package :)

I have made that you said and uploaded a new version (http://mentors.debian.net/package/curseofwar), but I met some issues:

> - Please install your binary to /usr/games and not to /usr/bin

In new Filesystem Hierarchy Standard 3.0 bin from games should be placed in /usr/bin.

https://www.linux.com/learn/tutorials/476610-a-look-at-the-filesystem-hierarchy-standard-30

https://bugs.linuxfoundation.org/show_bug.cgi?id=766

It's strange to make a change for old standart. And even if do that, that's not good for game. Should I do a patch only for debian pkg?

> You should add a desktop and menu file and icons to your package

This game running in console only. Should I do a desktop and menu file in this case?

And I can't win a lintian warning: hardening-no-fortify-functions

I added next to debian/rules:

export DEB_BUILD_MAINT_OPTIONS = hardening=+all

DPKG_EXPORT_BUILDFLAGS = 1

include /usr/share/dpkg/buildflags.mk

And it didn't help me. Could you, please, hint me about that? :)

P.S.

I'm looking for a sponsor for this game :)

2013/7/20 Markus Koschany <apo@gambaru.de>

On 19.07.2013 21:04, Anton Balashov wrote:[...]

> I want to impove my deb maintance skills and be helpfull for community
> and may be for your team in future.

Hi Anton,

(I am not sure if you are subscribed to the list already, hence my CC.)

i can't sponsor your package but here is my first impression and some technical
suggestions how you can improve your package at mentors.

http://mentors.debian.net/debian/pool/main/c/curseofwar/curseofwar_1.1.4-1.dsc

A good idea is to use lintian which will help you with fixing the most common
packaging issues.

Add this to ~/.lintianrc.

info=yes
display-info=yes
display-experimental=yes
pedantic=yes
show-overrides=yes
color=auto
verbose=yes

and then run

lintian curseofwar_1.1.4-1_amd64.changes

after you have built the package.

- changelog: You should close your ITP bug simply with
Initial release (Closes: #717348)
- You should use compat level 9 and build-depend on debhelper >=9 for
automatic hardening build flags.
- debian/control: the short description shouldn't start with an A and
you can also omit the full stop.
- Please install your binary to /usr/games and not to /usr/bin
- You might want to fix those outstanding "hyphen-used-as-minus-sign"
issues in your man page like you already did with the other ones.

Makefile:

$(CC) $(CFLAGS) -o $(EXEC) grid.o state.o king.o network.o output.o client.o server.o main.o $(LDFLAGS)

The order is problematic. Better use

$(CC) $(CFLAGS) $(LDFLAGS) grid.o state.o king.o network.o output.o client.o server.o main.o -o $(EXEC)

to avoid a FTBFS with binutils-gold.

You can improve your watch file for github a little by using the following version,
kindly stolen from one of Bart Martens' watch files and adjusted for your package. :)

version=3
opts=dversionmangle=s/(\da?)[\+\.\-~](?:dfsg|debian|ds|repack|repacked)\.?\d*$/$1/ \
https://github.com/a-nikolaev/curseofwar/tags \
.*/archive/(?:upstream/)?(?:v||version-|release-|X|R|r)(\d\S*)\.tar\.gz

You should add a desktop and menu file and icons to your package, so that it is visible
in all desktop environments. Take a look at the nettoe package which is quite similar
to yours.

Finding a sponsor for your package can be a daunting task sometimes, so please be persistent.
I suggest you add your package to the sponsors queue.

https://wiki.debian.org/Games/Sponsors/Queue

Hope that helps a little

Regards,

Markus