Re: Bug#696192: RFS: matanza/0.13+ds1-3 [updated] -- Space ascii war game
Hi,
>> Anyone interested?
>
> Yes, I'm interested,
Great!
> but would you please look at these things:
Yes, sure.
> On 25-12-12 12:46, Bas Wijnen wrote:
Sorry, I missed that message.
It would be nice if RFS bug report is added to Cc next time.
>> - debain/rules says it can be further simplified by using --with
>> autotools-dev, but then you have extra work restoring config.guess
>> and config.sub. If you instead use --with dh-autoreconf, you don't
>> have that problem. As a bonus, it will then really build from
>> source, so users can change Makefile.am or configure.in and use
>> Debian's build system to create a new package.
I have not touched this file. It works fine as I see. And I am not sure that
extra work is needed for it.
>> - There are a lot of warnings during compilation.
Yes, but I have no intention to fix them.
>> - The watch file has a line, but it is commented out. Why?
Because an original website is not available now. And I am not sure that it is
good idea to use [0] instead. Even despite the fact that all tarballs are
available there.
[0] http://web.archive.org/web/20071226080243/http://bachue.com/matanza/
>> - You are not in Uploaders. Is that intentional?
Yes, I have no intention to maintain this package. I found it during observing
the list of orphaned packages [1]. Package have few important and serious bugs,
which I wanted to fix by "QA upload". But the package was adopted by Peter and
updated version was uploaded to experimental in 2011 [2]. I wrote him in
June [3], but there is no reply still. So I have prepared this "Team upload".
Except fixing bugs I made very few changes, see [4].
[1] http://qa.debian.org/developer.php?login=packages%40qa.debian.org
[2] http://packages.debian.org/changelogs/pool/main/m/matanza/current/changelog
[3] http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=10;bug=675295
[4] http://anonscm.debian.org/gitweb/?p=pkg-games/matanza.git
>> - It has a great manpage, with humor, but there are several
>> spelling errors in it. It'd be good if a native English speaker
>> would look at it.
Sorry, I have not read it yet.
Thanks a lot for review!
Could you mark the most important notes which prevent the package upload?
Best regards,
Boris
Reply to: