[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Advice on a new package

Thanks for your help!

I've filed an ITP bug, it is
I'd like to package this on Alioth so I asked to get into pkg-games
there (the username is jsonic-guest).

2012/8/29 Boris Pek <Tehnick-8@yandex.ru>:
>> The package has a Lintian warning: W: fortuner:
>> hardening-no-fortify-functions usr/games/fortuner. How should that be
>> treated?
> http://wiki.debian.org/Hardening
> Note: Lintian can generate false positive here. So you should check it manually.

I can't solve this myself, if you have knowledge of this subject
please take a look.
>From "debuild" output I can see following:

/usr/bin/c++    -g -O2 -fstack-protector --param=ssp-buffer-size=4
-Wformat -Werror=format-security -D_FORTIFY_SOURCE=2
-I/usr/include/gtk-3.0 -I/usr/include/pango-1.0
-I/usr/include/gio-unix-2.0 -I/usr/include/atk-1.0
-I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0
-I/usr/include/freetype2 -I/usr/include/glib-2.0
-I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1
-I/usr/include/libpng12    -pthread -o
CMakeFiles/fortuner.dir/gtk_ui.cpp.o -c
(that is one of three compilation units)

/usr/bin/c++   -g -O2 -fstack-protector --param=ssp-buffer-size=4
-Wformat -Werror=format-security -D_FORTIFY_SOURCE=2    -Wl,-z,relro
CMakeFiles/fortuner.dir/settings.cpp.o  -o ../../bin/fortuner
-rdynamic -lgtk-3 -lgdk-3 -latk-1.0 -lgio-2.0 -lpangocairo-1.0
-lgdk_pixbuf-2.0 -lcairo-gobject -lpango-1.0 -lcairo -lgobject-2.0
-lglib-2.0 -lnotify
(that is linkage process)

Looks like the build flags are already there, even if I'm not using
anything flags-thing in debian/rules. However, I get the following

$ hardening-check debian/fortuner/usr/games/fortuner
 Position Independent Executable: no, normal executable!
 Stack protected: yes
 Fortify Source functions: no, only unprotected functions found!
 Read-only relocations: yes
 Immediate binding: no, not found!

Adding these lines to debian/rules
2012/8/29 Nathan Owens <ndowens@gmx.us>:
>include /usr/share/dpkg/buildflags.mk
>CFLAGS += -Wextra
did not make any difference.

Juhani Numminen

Reply to: