Re: new package 4dtris looking for sponsor

To: debian-devel-games@lists.debian.org
Subject: Re: new package 4dtris looking for sponsor
From: Paul Wise <pabs@debian.org>
Date: Sun, 13 May 2012 18:20:33 +0800
Message-id: <[🔎] CAKTje6FomrNCuM1h1d9HxwkBEpnifFK2p1-wpeo7X=V+HO28Uw@mail.gmail.com>
In-reply-to: <[🔎] CADQt7iOF1RSNQr0SX7o8YzdQ8k-H=mqabpDtHtA_-FQht1BUSw@mail.gmail.com>
References: <[🔎] CADQt7iOF1RSNQr0SX7o8YzdQ8k-H=mqabpDtHtA_-FQht1BUSw@mail.gmail.com>

On Sun, May 13, 2012 at 5:07 PM, Simon Laszlo wrote:

> I packaged my game 4dtris and now I'm looking for help to get it to Debian.
> I have uploaded it to: http://mentors.debian.net/package/4dtris

A review of your package:

You should not use a native source package, use a 3.0 (quilt) one instead.

None of the comments in debian/rules are needed.

Please add --parallel to the arguments of dh in debian/rules

Please remove debian/README

Please remove debian/docs since neither NEWS or README are very useful
to the users of a Debian package.

Looking at the upstream source, it is GPL-v3-only not GPL-3.0+. You
are also missing copyrights for the m4/* files.

Please use dh-autoreconf

Please manually wrap debian/menu one item per line.

Please delete Vcs-* from debian/control since they are commented out
and don't seem to work.

Please run wrap-and-sort -s to wrap debian/control properly.

I would suggest debian/compat be bumped to 9 and same for the
debhelper build-dep.

The package description needs to be filled out a bit.

You need to file an ITP:

http://www.debian.org/devel/wnpp/#l1


Since you are upstream, please read these:

http://tieguy.org/blog/2012/03/17/on-the-importance-of-per-file-license-information/
http://wiki.debian.org/UpstreamGuide
http://www.freedesktop.org/wiki/Games/Upstream

 The upstream gen-src-release.sh uses tar manually, this is wrong, you
should use the `make distcheck` provided by automake instead.

configure.scan / autoscan.log doesn't belong in the source package.

You can replace the commands in autogen.sh with this:

autoreconf --force --install --symlink --warnings=all

You should not hard-code the install path in the desktop file, just do
Icon=4dtris instead, the desktop environments will do the rest.

These two files are duplicates, delete the first one:
doc/icon/4dtris.png doc/icon/4DTRIS_icon_256.png

doc/icon/4DTRIS_icon_*.png should be installed as
/usr/share/icons/hicolor/*/apps/4dtris.png

Looking at doc/concept/4dtris-sw-struct.html it seems there are some
SVG files missing from the source package.

Automated checks:

POFileSpell finds a number of errors in several translations.

gcc:

src/4dt_ai.c: In function 'aiSetActive':
src/4dt_ai.c:65:5: warning: passing argument 2 of 'setTimerCallback'
from incompatible pointer type [enabled by default]
In file included from src/4dt_ai.c:13:0:
src/4dt_main.h:21:13: note: expected 'int (*)(int,  void *)' but
argument is of type 'int (*)(int,  struct tEngGame *)'
src/4dt_eng.c: In function 'engUpdateScore':
src/4dt_eng.c:115:5: warning: passing argument 2 of 'engEqLevel' from
incompatible pointer type [enabled by default]
src/4dt_eng.c:84:12: note: expected 'char (*)[2][2]' but argument is
of type 'const char (*)[2][2]'
src/4dt_eng.c: In function 'engDropSolid':
src/4dt_eng.c:142:3: warning: passing argument 2 of 'setTimerCallback'
from incompatible pointer type [enabled by default]
In file included from src/4dt_eng.c:17:0:
src/4dt_main.h:21:13: note: expected 'int (*)(int,  void *)' but
argument is of type 'int (*)(int,  struct tEngGame *)'
src/4dt_eng.c: In function 'engResetGame':
src/4dt_eng.c:348:5: warning: passing argument 2 of 'setTimerCallback'
from incompatible pointer type [enabled by default]
In file included from src/4dt_eng.c:17:0:
src/4dt_main.h:21:13: note: expected 'int (*)(int,  void *)' but
argument is of type 'int (*)(int,  struct tEngGame *)'
src/4dt_eng.c: In function 'engLowerSolid':
src/4dt_eng.c:503:9: warning: passing argument 2 of 'setTimerCallback'
from incompatible pointer type [enabled by default]
In file included from src/4dt_eng.c:17:0:
src/4dt_main.h:21:13: note: expected 'int (*)(int,  void *)' but
argument is of type 'int (*)(int,  struct tEngGame *)'
src/4dt_eng.c: In function 'engTurn':
src/4dt_eng.c:572:9: warning: passing argument 2 of 'setTimerCallback'
from incompatible pointer type [enabled by default]
In file included from src/4dt_eng.c:17:0:
src/4dt_main.h:21:13: note: expected 'int (*)(int,  void *)' but
argument is of type 'int (*)(int,  struct tEngGame *)'
src/4dt_main.c: In function 'setTimerCallback':
src/4dt_main.c:101:3: warning: passing argument 2 of 'SDL_AddTimer'
from incompatible pointer type [enabled by default]
In file included from /usr/include/SDL/SDL.h:42:0,
                 from src/4dt_main.c:49:
/usr/include/SDL/SDL_timer.h:109:60: note: expected
'SDL_NewTimerCallback' but argument is of type 'int (*)(int,  void *)'
src/4dt_main.c:101:3: warning: return from incompatible pointer type
[enabled by default]
src/4dt_main.c: In function 'clearTimerCallback':
src/4dt_main.c:107:3: warning: passing argument 1 of 'SDL_RemoveTimer'
from incompatible pointer type [enabled by default]
In file included from /usr/include/SDL/SDL.h:42:0,
                 from src/4dt_main.c:49:
/usr/include/SDL/SDL_timer.h:115:57: note: expected 'SDL_TimerID' but
argument is of type 'int *'
src/4dt_scn.c: In function 'scnDrawGamespace':
src/4dt_scn.c:281:21: warning: passing argument 3 of 'g4dDraw4DCube'
discards 'const' qualifier from pointer target type [enabled by
default]
In file included from src/4dt_scn.c:20:0:
src/4dt_g4d.h:37:13: note: expected 'float *' but argument is of type
'const float *'
src/4dt_scn.c: In function 'scnDrawBottomLevel':
src/4dt_scn.c:303:21: warning: passing argument 3 of 'g4dDraw4DCube'
discards 'const' qualifier from pointer target type [enabled by
default]
In file included from src/4dt_scn.c:20:0:
src/4dt_g4d.h:37:13: note: expected 'float *' but argument is of type
'const float *'
src/4dt_scn.c: In function 'scnDrawObject':
src/4dt_scn.c:333:19: warning: passing argument 3 of 'g4dDraw4DCube'
discards 'const' qualifier from pointer target type [enabled by
default]
In file included from src/4dt_scn.c:20:0:
src/4dt_g4d.h:37:13: note: expected 'float *' but argument is of type
'const float *'

lintian:

P: 4dtris source: unversioned-copyright-format-uri
http://dep.debian.net/deps/dep5
I: 4dtris: extended-description-is-probably-too-short

desktop-file-validate:

4dtris.desktop: warning: boolean key "Terminal" in group "Desktop
Entry" has value "0", which is deprecated: boolean values should be
"false" or "true"
4dtris.desktop: error: value "Game;LogicGame" for string list key
"Categories" in group "Desktop Entry" does not have a semicolon (';')
as trailing character

msgfmt:

msgfmt: po/4dtris.pot: warning: source file contains fuzzy translation
po/4dtris.pot:23: empty `msgstr' entry ignored
po/4dtris.pot:28: empty `msgstr' entry ignored
po/4dtris.pot:33: empty `msgstr' entry ignored
po/4dtris.pot:37: empty `msgstr' entry ignored
msgfmt: po/4dtris.pot: warning: PO file header fuzzy
                                                warning: older
versions of msgfmt will give an error on this
msgfmt: found 5 fatal errors


-- 
bye,
pabs

http://wiki.debian.org/PaulWise

Reply to:

References:
- new package 4dtris looking for sponsor
  - From: Simon Laszlo <laszlo.simon@gmail.com>

Prev by Date: new package 4dtris looking for sponsor
Next by Date: Bug#672853: RM: tremulous,tremulous-data -- ROM; old fork of Quake 3, security issues likely, dormant upstream, unmaintained
Previous by thread: new package 4dtris looking for sponsor
Next by thread: Bug#672853: RM: tremulous,tremulous-data -- ROM; old fork of Quake 3, security issues likely, dormant upstream, unmaintained
Index(es):
- Date
- Thread