Re: Bug#660519: Re[2]: Bug#660519: RFS: manaplus/1.2.2.19
On Tue, Mar 6, 2012 at 8:43 AM, andrei karas wrote:
> Now i not sure. For me now task add manaplus to debian, after we will see.
Ok, I would encourage you to join the team and help out with other games too.
> For now no, but in future yes.
> Now server not in state for packaging, need many work for adapt it to work from separate directories.
> Also it can work only in 32 bit version. Server from what it forked storing pointers in int and have
> some other 64 bit issues.
Fair enough.
> Registration is simple, In game client need press register and enter login and password.
> I can create preregistered account but not sure what password i can put in public, because some one can
> change it after.
Gotcha.
> SVG image was not drawed for manaplus, but used same as in mana. I removed it
> For other one image i add xcf file, but sad it in 2.7 gimp format or like this.
> I also removed some themes because license GPL and i dont have response from
> author about sources.
> Other themes relicensed from GPL to CC-BY-SA.
> Other themes from data/graphics/gui is a bit modified theme from mana client/package
> data/themes/wood is theme from tmw package (branding for mana)
> tmw and mana now in debian and i think if it accepted, then this themes here
> can be accepted too.
...
> It based in one of ogg files from The Mana World sounds. I simple cut and add delay
> to one channel.
> I can include ogg file as source if need.
> Also in new version i add sounds from psiplus package converted to ogg and some renamed.
> Should i also include source wav files?
It sounds like you have included the source as you are using it and prefer it.
I would encourage you to reconsider what the most useful form for
modification of your audio/graphics is; personally I would not
consider premixed audio or prerendered graphics to be my preferred
form for modification:
http://www.freedesktop.org/wiki/Games/Upstream#Source
> Manaplustest need for autocheck graphics settings/speed and add it to configuration.
> Desktop file removed.
Thanks.
> I thinking about SDL-Pango not sure is it good to use it here.
Since you are using SDL-TTF, SDL-Pango is the best choice here IMO.
> About fontconfig. Is possible with it create link to fonts with given names?
Search for fontconfig in this code that I wrote, it is pretty easy:
http://chromium-bsu.git.sourceforge.net/git/gitweb.cgi?p=chromium-bsu/chromium-bsu;a=blob;f=src/TextFTGL.cpp
> I left system call for now, but strict text what can be given to it.
> (only static or always safe strings allowed)
Good, please consider switching to exec in the future though.
> I thinking about this. This possible in future versions.
Cool.
> I removed most duplicates. Some left because this files accessed by physfs and
> in physfs soft links not allowed. I allow it only for fonts enumeration.
I see, please file a bug on physfs upstream about this issue.
> This is all false positives.
The first one is definitely not since the destructor does not delete
the OpenGLGraphicsVertexes object.
The second one indeed seems to be a false positive, please file a bug
on cppcheck upstream.
> Some "dont" fixed other is by design in internal commands/events.
Ah, OK. If you want to add an explanation for that you can override
the lintian warning and add a comment in the override file.
> current dsc file: http://mentors.debian.net/debian/pool/main/m/manaplus/manaplus_1.2.3.4-1.dsc
Here is an updated review:
In the registration process there is an option for Male or Female. I
would suggest removing that or adding an Other category since both
gender and biological sex have more options than that. Often people
who do not fit into either of these categories will be very offended
to have to label themselves as Male or Female.
The initial download when logging into a server is quite big, is that
a per-server thing like with web browsers or can it be added to
Debian?
The first line in debian/copright should point at this URL instead now:
http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
You might want to switch to debhelper compat 9 so that manaplus gets
built with security hardening compiler flags. This is especially
important since manaplus is a network client.
--
bye,
pabs
http://wiki.debian.org/PaulWise
Reply to: