Re: vavoom, updated version
[CCed you because I'm not sure if you are subscribed]
On Wed, Feb 29, 2012 at 7:06 AM, gustavo panizzo <gfa> wrote:
> i've updated vavoom to close 2 bugs
> #661232 and #661233
> http://mentors.debian.net/debian/pool/main/v/vavoom/vavoom_1.33-2.dsc
>
> can anybody upload it?
>
> Pabs, you opened those ;)
Uploaded.
Some issues you might want to look at for the next upload:
If you contact upstream as a result of this review, please include
these two links in your email:
http://www.freedesktop.org/wiki/Games/Upstream
http://wiki.debian.org/UpstreamGuide
You might want to run wrap-and-sort -s to make diffs of debian/control
and other files more readable.
You might want to manually wrap and sort debian/vavoom.menu for the
same purpose.
Your watch file should probably use "+" instead of "*" and "\d[\d\.]"
instead of "." and you might want to make it cope with these
extensions too: zip tgz tbz txz tar.bz2 tar.xz
Your packaging isn't committed to the games team VCS repos:
http://wiki.debian.org/Games/VCS
Please check if vavoom works with libpng1.5 as indicated by the PTS page:
http://packages.qa.debian.org/v/vavoom.html
Please edit the debtags for vavoom:
http://debtags.debian.net/edit/vavoom
There are some build log issues:
https://buildd.debian.org/~brlink/packages/v/vavoom.html
The package FTBFS on Hurd due to the use of PATH_MAX:
https://buildd.debian.org/status/package.php?p=vavoom
https://www.gnu.org/software/hurd/hurd/porting/guidelines.html
I don't think it is appropriate to recommend contrib/non-free deps,
please move heretic-wad, game-data-packager to Suggests:
http://qa.debian.org/debcheck.php?dist=unstable&package=vavoom
The patch headers are a bit weird, they include snippets from
debian/changelog and duplicated DEP-3 headers. Please delete them all
and write some DEP-3 headers from scratch:
http://dep.debian.net/deps/dep3/
Please forward the patches, manual pages and desktop file upstream and
add DEP-3 headers or comments indicating where they have been
forwarded.
The upstream docs/vavoom.txt file includes installation instructions,
which isn't useful for users of binary packages. Please ask upstream
to split those out into README.install.
You may want to make the copyright file machine-readable:
http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Some of the upstream code contains the incorrect FSF address. I would
suggest that upstream should point at the GNU website instead, as
suggested by GNU:
https://www.gnu.org/licenses/gpl-howto.html
I note that upstream uses system() in one file. In this case the usage
seems safe since it is only run during the build process, but you
should ensure that future uses of this function are safe or switch to
the exec*() family of functions.
GCC warnings, these are repeated many times:
utils/vlaunch/vlaunch.xpm:292:1: warning: deprecated conversion from
string constant to 'char*' [-Wwrite-strings]
source/gl_model.cpp:317:70: warning: cast to pointer from integer of
different size [-Wint-to-pointer-cast]
lintian complaints:
W: vavoom source: out-of-date-standards-version 3.9.2 (current is 3.9.3)
W: vavoom: binary-without-manpage usr/games/vlaunch
cppcheck warnings:
[libs/core/str.h:355]: (error) Uninitialized variable: Len
[libs/core/str.h:356]: (error) Uninitialized variable: Len
[libs/core/name.cpp:72]: (error) Uninitialized variable: Size
[libs/core/stream.cpp:262]: (error) Uninitialized variable: B
[libs/core/stream.cpp:263]: (error) Uninitialized variable: B
[core/stream.cpp:264]: (error) Uninitialized variable: B
[libs/core/stream.cpp:265]: (error) Uninitialized variable: B
[libs/core/xml.cpp:79]: (error) Throwing exception in destructor
[libs/core/map.h:105]: (error) Throwing exception in destructor
[source/files.cpp:773]: (error) Throwing exception in destructor
[source/files.cpp:666]: (error) Throwing exception in destructor
[source/fs_zip.cpp:296]: (error) Throwing exception in destructor
[source/fs_zip.cpp:710]: (error) Throwing exception in destructor
[source/fs_zip.cpp:163]: (error) Uninitialized variable: Signature
[source/fs_zip.cpp:165]: (error) Uninitialized variable: number_disk
[source/fs_zip.cpp:167]: (error) Uninitialized variable: number_disk_with_CD
[source/fs_zip.cpp:174]: (error) Uninitialized variable: number_disk_with_CD
[source/fs_zip.cpp:171]: (error) Uninitialized variable: number_entry_CD
[source/fs_zip.cpp:173]: (error) Uninitialized variable: number_entry_CD
[source/fs_zip.cpp:182]: (error) Uninitialized variable: size_central_dir
[source/fs_zip.cpp:186]: (error) Uninitialized variable: size_central_dir
[source/fs_zip.cpp:183]: (error) Uninitialized variable: offset_central_dir
[source/fs_zip.cpp:186]: (error) Uninitialized variable: offset_central_dir
[source/fs_zip.cpp:212]: (error) Uninitialized variable: Magic
[source/fs_zip.cpp:229]: (error) Uninitialized variable: Magic
[source/fs_zip.cpp:213]: (error) Uninitialized variable: version
[source/fs_zip.cpp:214]: (error) Uninitialized variable: version_needed
[source/fs_zip.cpp:217]: (error) Uninitialized variable: dosDate
[source/fs_zip.cpp:222]: (error) Uninitialized variable: size_file_extra
[source/fs_zip.cpp:223]: (error) Uninitialized variable: size_file_comment
[source/fs_zip.cpp:224]: (error) Uninitialized variable: disk_num_start
[source/fs_zip.cpp:225]: (error) Uninitialized variable: internal_fa
[source/fs_zip.cpp:226]: (error) Uninitialized variable: external_fa
[source/fs_zip.cpp:737]: (error) Uninitialized variable: Magic
[source/fs_zip.cpp:748]: (error) Uninitialized variable: Magic
[source/fs_zip.cpp:741]: (error) Uninitialized variable: DateTime
[source/fs_zip.cpp:742]: (error) Uninitialized variable: Crc
[source/fs_zip.cpp:743]: (error) Uninitialized variable: ComprSize
[source/fs_zip.cpp:744]: (error) Uninitialized variable: UncomprSize
[source/fs_zip.cpp:738]: (error) Uninitialized variable: Version
[source/fs_zip.cpp:739]: (error) Uninitialized variable: Flags
[source/fs_zip.cpp:740]: (error) Uninitialized variable: ComprMethod
[source/fs_zip.cpp:754]: (error) Uninitialized variable: ComprMethod
[source/fs_zip.cpp:745]: (error) Uninitialized variable: FileNameSize
[source/fs_zip.cpp:746]: (error) Uninitialized variable: ExtraFieldSize
[source/in_alleg.cpp:159]: (error) Throwing exception in destructor
[source/in_sdl.cpp:200]: (error) Throwing exception in destructor
[source/in_win32.cpp:540]: (error) Throwing exception in destructor
[source/level.cpp:239]: (error) Uninitialized variable: angle
[source/level.cpp:240]: (error) Uninitialized variable: polyX
[source/level.cpp:244]: (error) Uninitialized variable: polyX
[source/level.cpp:241]: (error) Uninitialized variable: polyY
[source/level.cpp:245]: (error) Uninitialized variable: polyY
[source/net_channel.cpp:101]: (error) Throwing exception in destructor
[source/net_channel_level.cpp:795]: (error) Uninitialized variable: a
[source/net_channel_level.cpp:796]: (error) Uninitialized variable: a
[source/net_channel_level.cpp:806]: (error) Uninitialized variable: Radius
[source/net_channel_level.cpp:806]: (error) Uninitialized variable: Colour
[source/net_channel_level.cpp:893]: (error) Uninitialized variable: Start
[source/net_channel_level.cpp:893]: (error) Uninitialized variable: End
[source/net_channel_level.cpp:893]: (error) Uninitialized variable: SrcStart
[source/net_channel_level.cpp:893]: (error) Uninitialized variable: SrcEnd
[source/net_channel_level.cpp:906]: (error) Uninitialized variable: Start
[source/net_channel_level.cpp:906]: (error) Uninitialized variable: End
[source/net_channel_level.cpp:906]: (error) Uninitialized variable: R1
[source/net_channel_level.cpp:906]: (error) Uninitialized variable: G1
[source/net_channel_level.cpp:906]: (error) Uninitialized variable: B1
[source/net_channel_level.cpp:906]: (error) Uninitialized variable: R2
[source/net_channel_level.cpp:906]: (error) Uninitialized variable: G2
[source/net_channel_level.cpp:906]: (error) Uninitialized variable: B2
[source/net_channel_level.cpp:929]: (error) Uninitialized variable: TrStart
[source/net_channel_level.cpp:929]: (error) Uninitialized variable: TrEnd
[source/net_channel_object_map.cpp:207]: (error) Uninitialized
variable: NumNames
[source/net_channel_object_map.cpp:210]: (error) Uninitialized
variable: NumClasses
[source/net_channel_thinker.cpp:87]: (error) Throwing exception in destructor
[source/net_connection.cpp:127]: (error) Throwing exception in destructor
[source/net_connection.cpp:344]: (error) Memory leak: Chan
[source/net_connection.cpp:810]: (error) Memory leak: Chan
[source/net_connection.cpp:224]: (error) Uninitialized variable: Sequence
[source/net_connection.cpp:230]: (error) Uninitialized variable: Sequence
[source/net_connection.cpp:257]: (error) Uninitialized variable: AckSeq
[source/net_connection.cpp:258]: (error) Uninitialized variable: AckSeq
[source/net_datagram.cpp:1058]: (error) Throwing exception in destructor
[source/net_demo.cpp:152]: (error) Uninitialized variable: MsgSize
[source/net_demo.cpp:155]: (error) Uninitialized variable: MsgSize
[source/net_connection.cpp:110]: (error) Throwing exception in destructor
[source/net_loopback.cpp:296]: (error) Throwing exception in destructor
[source/p_clip.cpp:87]: (error) Throwing exception in destructor
[source/p_acs.cpp:1272]: (error) Throwing exception in destructor
[source/p_acs.cpp:524]: (error) Throwing exception in destructor
[source/p_acs.cpp:1758]: (error) Uninitialized variable: NewSize
[source/p_acs.cpp:1804]: (error) Uninitialized variable: TmpInt
[source/p_acs.cpp:1805]: (error) Uninitialized variable: TmpInt
[source/p_setup.cpp:603]: (error) Uninitialized variable: x
[source/p_setup.cpp:603]: (error) Uninitialized variable: y
[source/p_setup.cpp:619]: (error) Uninitialized variable: x
[source/p_setup.cpp:619]: (error) Uninitialized variable: y
[source/p_setup.cpp:630]: (error) Uninitialized variable: x
[source/p_setup.cpp:631]: (error) Uninitialized variable: x
[source/p_setup.cpp:630]: (error) Uninitialized variable: y
[source/p_setup.cpp:631]: (error) Uninitialized variable: y
[source/p_setup.cpp:663]: (error) Uninitialized variable: floorheight
[source/p_setup.cpp:663]: (error) Uninitialized variable: ceilingheight
[source/p_setup.cpp:684]: (error) Uninitialized variable: ceilingheight
[source/p_setup.cpp:666]: (error) Uninitialized variable: lightlevel
[source/p_setup.cpp:666]: (error) Uninitialized variable: special
[source/p_setup.cpp:666]: (error) Uninitialized variable: tag
[source/p_setup.cpp:847]: (error) Uninitialized variable: textureoffset
[source/p_setup.cpp:847]: (error) Uninitialized variable: rowoffset
[source/p_setup.cpp:851]: (error) Uninitialized variable: sector
[source/p_setup.cpp:853]: (error) Uninitialized variable: sector
[source/p_setup.cpp:952]: (error) Uninitialized variable: v1
[source/p_setup.cpp:954]: (error) Uninitialized variable: v1
[source/p_setup.cpp:952]: (error) Uninitialized variable: v2
[source/p_setup.cpp:958]: (error) Uninitialized variable: v2
[source/p_setup.cpp:952]: (error) Uninitialized variable: flags
[source/p_setup.cpp:952]: (error) Uninitialized variable: special
[source/p_setup.cpp:952]: (error) Uninitialized variable: tag
[source/p_setup.cpp:952]: (error) Uninitialized variable: side0
[source/p_setup.cpp:952]: (error) Uninitialized variable: side1
[source/p_setup.cpp:1010]: (error) Uninitialized variable: v1
[source/p_setup.cpp:1013]: (error) Uninitialized variable: v1
[source/p_setup.cpp:1010]: (error) Uninitialized variable: v2
[source/p_setup.cpp:1017]: (error) Uninitialized variable: v2
[source/p_setup.cpp:1010]: (error) Uninitialized variable: flags
[source/p_setup.cpp:1010]: (error) Uninitialized variable: special
[source/p_setup.cpp:1010]: (error) Uninitialized variable: arg1
[source/p_setup.cpp:1010]: (error) Uninitialized variable: arg2
[source/p_setup.cpp:1010]: (error) Uninitialized variable: arg3
[source/p_setup.cpp:1010]: (error) Uninitialized variable: arg4
[source/p_setup.cpp:1011]: (error) Uninitialized variable: arg5
[source/p_setup.cpp:1011]: (error) Uninitialized variable: side0
[source/p_setup.cpp:1011]: (error) Uninitialized variable: side1
[source/p_setup.cpp:1153]: (error) Uninitialized variable: linedef
[source/p_setup.cpp:1162]: (error) Uninitialized variable: linedef
[source/p_setup.cpp:1195]: (error) Uninitialized variable: linedef
[source/p_setup.cpp:1153]: (error) Uninitialized variable: side
[source/p_setup.cpp:1153]: (error) Uninitialized variable: v1
[source/p_setup.cpp:1153]: (error) Uninitialized variable: v2
[source/p_setup.cpp:1153]: (error) Uninitialized variable: partner
[source/p_setup.cpp:1162]: (error) Uninitialized variable: v1
[source/p_setup.cpp:1162]: (error) Uninitialized variable: v2
[source/p_setup.cpp:1162]: (error) Uninitialized variable: flags
[source/p_setup.cpp:1165]: (error) Uninitialized variable: flags
[source/p_setup.cpp:1162]: (error) Uninitialized variable: partner
[source/p_setup.cpp:1277]: (error) Uninitialized variable: numsegs
[source/p_setup.cpp:1277]: (error) Uninitialized variable: firstseg
[source/p_setup.cpp:1284]: (error) Uninitialized variable: numsegs
[source/p_setup.cpp:1284]: (error) Uninitialized variable: firstseg
[source/p_setup.cpp:1343]: (error) Uninitialized variable: x
[source/p_setup.cpp:1343]: (error) Uninitialized variable: y
[source/p_setup.cpp:1343]: (error) Uninitialized variable: dx
[source/p_setup.cpp:1343]: (error) Uninitialized variable: dy
[source/p_setup.cpp:1353]: (error) Uninitialized variable: child0
[source/p_setup.cpp:1353]: (error) Uninitialized variable: child1
[source/p_setup.cpp:1433]: (error) Uninitialized variable: OrgVerts
[source/p_setup.cpp:1435]: (error) Uninitialized variable: OrgVerts
[source/p_setup.cpp:1433]: (error) Uninitialized variable: NewVerts
[source/p_setup.cpp:1435]: (error) Uninitialized variable: NewVerts
[source/p_setup.cpp:1458]: (error) Uninitialized variable: x
[source/p_setup.cpp:1459]: (error) Uninitialized variable: x
[source/p_setup.cpp:1458]: (error) Uninitialized variable: y
[source/p_setup.cpp:1459]: (error) Uninitialized variable: y
[source/p_setup.cpp:1473]: (error) Uninitialized variable: NumSubSegs
[source/p_setup.cpp:1493]: (error) Uninitialized variable: v1
[source/p_setup.cpp:1495]: (error) Uninitialized variable: v1
[source/p_setup.cpp:1493]: (error) Uninitialized variable: partner
[source/p_setup.cpp:1493]: (error) Uninitialized variable: linedef
[source/p_setup.cpp:1501]: (error) Uninitialized variable: linedef
[source/p_setup.cpp:1493]: (error) Uninitialized variable: side
[source/p_setup.cpp:1551]: (error) Uninitialized variable: x
[source/p_setup.cpp:1551]: (error) Uninitialized variable: y
[source/p_setup.cpp:1551]: (error) Uninitialized variable: dx
[source/p_setup.cpp:1551]: (error) Uninitialized variable: dy
[source/p_setup.cpp:1667]: (error) Uninitialized variable: Tmp
[source/p_setup.cpp:1668]: (error) Uninitialized variable: Tmp
[source/p_setup.cpp:1915]: (error) Uninitialized variable: x
[source/p_setup.cpp:1915]: (error) Uninitialized variable: y
[source/p_setup.cpp:1915]: (error) Uninitialized variable: angle
[source/p_setup.cpp:1915]: (error) Uninitialized variable: type
[source/p_setup.cpp:1915]: (error) Uninitialized variable: options
[source/p_setup.cpp:1921]: (error) Uninitialized variable: options
[source/p_setup.cpp:1923]: (error) Uninitialized variable: options
[source/p_setup.cpp:1960]: (error) Uninitialized variable: tid
[source/p_setup.cpp:1960]: (error) Uninitialized variable: x
[source/p_setup.cpp:1960]: (error) Uninitialized variable: y
[source/p_setup.cpp:1960]: (error) Uninitialized variable: height
[source/p_setup.cpp:1960]: (error) Uninitialized variable: angle
[source/p_setup.cpp:1960]: (error) Uninitialized variable: type
[source/p_setup.cpp:1960]: (error) Uninitialized variable: options
[source/p_setup.cpp:1969]: (error) Uninitialized variable: options
[source/p_setup.cpp:1970]: (error) Uninitialized variable: options
[source/p_setup.cpp:1971]: (error) Uninitialized variable: options
[source/p_setup.cpp:1961]: (error) Uninitialized variable: special
[source/p_setup.cpp:1961]: (error) Uninitialized variable: arg1
[source/p_setup.cpp:1961]: (error) Uninitialized variable: arg2
[source/p_setup.cpp:1961]: (error) Uninitialized variable: arg3
[source/p_setup.cpp:1961]: (error) Uninitialized variable: arg4
[source/p_setup.cpp:1961]: (error) Uninitialized variable: arg5
[source/p_setup.cpp:2199]: (error) Uninitialized variable: Num
[libs/core/stream.h:133]: (error) Uninitialized variable: Val
[libs/core/stream.h:134]: (error) Uninitialized variable: Val
[source/r_main.cpp:376]: (error) Throwing exception in destructor
[source/r_main.cpp:392]: (error) Throwing exception in destructor
Probably more cppcheck issues exist, I killed cppcheck at this point
because it uses so much CPU.
dpkg-shlibdeps warnings:
The wxWidgets ones are probably the fault of that, not vavoom. The
other ones should probably be fixed in the upstream build system
dpkg-shlibdeps: warning: dependency on libwx_gtk2u_richtext-2.8.so.0
could be avoided if "debian/vavoom/usr/games/vlaunch" were not
uselessly linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libwx_gtk2u_html-2.8.so.0 could
be avoided if "debian/vavoom/usr/games/vlaunch" were not uselessly
linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libwx_baseu_xml-2.8.so.0 could
be avoided if "debian/vavoom/usr/games/vlaunch" were not uselessly
linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libwx_gtk2u_aui-2.8.so.0 could
be avoided if "debian/vavoom/usr/games/vlaunch" were not uselessly
linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libdl.so.2 could be avoided if
"debian/vavoom/usr/lib/vavoom/vavoom.bin" were not uselessly linked
against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libwx_gtk2u_qa-2.8.so.0 could
be avoided if "debian/vavoom/usr/games/vlaunch" were not uselessly
linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libwx_gtk2u_xrc-2.8.so.0 could
be avoided if "debian/vavoom/usr/games/vlaunch" were not uselessly
linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libwx_gtk2u_adv-2.8.so.0 could
be avoided if "debian/vavoom/usr/games/vlaunch" were not uselessly
linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libFLAC.so.8 could be avoided
if "debian/vavoom/usr/lib/vavoom/vavoom.bin" were not uselessly linked
against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libwx_baseu_net-2.8.so.0 could
be avoided if "debian/vavoom/usr/games/vlaunch" were not uselessly
linked against it (they use none of its symbols).
There are some duplicate files. Not sure if unduplicating them is
possible or useful to do upstream. The Debian manual pages should not
be duplicate, instead they should use symlinks or the .SO mechanism.
basev/heretic/graphics/fonta30.lmp
basev/hexen/graphics/fonta30.lmp
basev/heretic/graphics/fonta63.lmp
basev/hexen/graphics/fonta63.lmp
basev/heretic/skyboxes.txt
basev/hexen/skyboxes.txt
basev/doom/skyboxes.txt
basev/strife/skyboxes.txt
basev/hexen/graphics/croshai1.lmp
basev/doom/graphics/croshai1.lmp
basev/common/glshaders/shadows_fog.vs
basev/common/glshaders/surf_zbuf.vs
basev/common/glshaders/shadows_texture.vs
basev/common/glshaders/surf_masked.vs
basev/common/glshaders/surf_sky.vs
basev/common/glshaders/draw_fixed_col.vs
basev/common/glshaders/shadows_ambient.vs
basev/common/glshaders/shadows_model_ambient.vs
basev/common/glshaders/shadows_model_textures.vs
basev/plutonia/basepak.ls.in
basev/tnt/basepak.ls.in
basev/freedoom/basepak.ls.in
progs/doom/cgame/MenuScreenControls2.vc
progs/heretic/cgame/MenuScreenControls2.vc
progs/hexen/cgame/MenuScreenControls2.vc
progs/doom/cgame/MenuScreenMultiplayer.vc
progs/heretic/cgame/MenuScreenMultiplayer.vc
progs/hexen/cgame/MenuScreenMultiplayer.vc
progs/strife/cgame/MenuScreenMultiplayer.vc
progs/hexen/cgame/MenuScreenGameplayOptions.vc
progs/heretic/cgame/MenuScreenGameplayOptions.vc
progs/hexen/cgame/MenuScreenOptions.vc
progs/strife/cgame/MenuScreenOptions.vc
progs/heretic/cgame/MenuScreenOptions.vc
progs/doom/cgame/MenuScreenOptions.vc
utils/editing/dbuilder2/Includes/Strife_Texturesets.cfg
utils/editing/dbuilder2/Includes/Hexen_Texturesets.cfg
debian/vavoom.6
debian/vavoom-dedicated.6
basev/plutonia/base.txt
basev/freedoom/base.txt
basev/doom1/base.txt
basev/doom2/base.txt
--
bye,
pabs
http://wiki.debian.org/PaulWise
Reply to: