[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: naev

Hi Michael,

Thanks for the review. Please also consider reviewing my most
up-to-date packaging in the Debian Games svn repository; my Naev
packaging at mentors.d.n is heavily outdated at the moment, mostly
because I'm getting tired of having to upload a 200 MB tarball every
time I want to make a minor change to my packaging.

$ svn co svn://svn.debian.org/svn/pkg-games/packages/trunk/naev/

> - What about the file in build/?

Added it to debian/copyright in svn, thanks!

> - The contents of dat/ is a bit dangerous: the font files appear to lack the
>  sources that they were generated from!?

This is already addressed in svn; naev now depends on ttf-freefont and
links to the fonts contained in that package.

> - In src/, a few files contain copyright and license information. Those
>  copyright holders (and licenses) are not reflected in debian/copyright.

Upstream has added copyright/license info to every source file since
the latest Naev 0.5.0 release, so this shouldn't be an issue.

> - Your debian/changelog file gives pointers to further potential issues.

And I'd gladly accept any help in resolving those issues.

> Aside these missing bits, it would be preferable if licenses found in
> /usr/share/common-licenses were not quoted in full; I'm asking for this because
> the copyright file is already huge anyhow.

None of the various Creative Commons licenses (which take up the bulk
of debian/copyright) are found under /usr/share/common-licenses.

Thanks again for your review!

Kind regards,
- Vincent Cheng

Reply to: