[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: libclanlib2.2


On Tue, Nov 2, 2010 at 11:56 AM, Givors Fabien
<fabien.givors@chezlefab.net> wrote:
> Dear mentors,
> I am looking for a sponsor for my package "libclanlib2.2".

Non-DD review:

1) An earlier version of this package is already in Debian. I think
you really should (probably must) talk with the previous maintainers.
You can see if they'd be willing to have you as a co-maintainer or to
be main maintainer as part of the debian games team. This is important
because they already maintain the package libclanlib-dev, which might
be confusing to your users (since it points to the old library).

Additionally, the original maintainers probably would not want to add
a new version of their library into unstable during freeze. This would
be a good time to plan out how you'd like to release it after squeeze.

2) Your package also closes bug:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=570884, it would be
good close it in your changelog.

3) You are using source format 3.0 (quilt). The quilt dependency and
debian/readme.source are not needed

4) The patch in debian/series/patches is missing a description. See  DEP-3 [1]

5) Consider formatting the debian/copyright per DEP-5 [2]. No really
required to do, but if making a new package it won't hurt.

6) You don't list yourself as an uploader. (something you have to work
out with previous maintainers)

7) From a Debian-games team perspective, you should use a vcs [3].
(libclanlib is already in the debian games svn, but you can talk to
previous maintainers if you want to start a new repo for the new
library version)

8) From the changelog, this isn't a NMU but either a new package or a
Team upload [4]. Again, talk with the current maintainers about how to
handle this.

9) lintian report is below. All of them should be fixable, but one in
particular is probably needed: W: libclanlib2.2:
package-name-doesnt-match-sonames. You should probably create separate
binary packages for the libraries they mentioned below, and name them
accordingly (e.g. libclan22GL1-2.2-1, libclan22MikMod-2.2-1, etc.).
This way users (and depending applications) will only depend on the
exact library they need and not have to pull in all your libraries. Of
course the -dev package would depend on all of those additional
binaries. This is something to check with the original maintainers (or
the debian games team).

$ lintian --pedantic -Ii
I: libclanlib2.2 source: quilt-patch-missing-description noreftest
N:    quilt patch files should start with a description of patch. All lines
N:    before the start of the patch itself are considered part of the
N:    description. You can edit the description with quilt header -e when the
N:    patch is at the top of the stack.
N:    As well as a description of the purpose and function of the patch, the
N:    description should ideally contain author information, a URL for the bug
N:    report (if any), Debian or upstream bugs fixed by it, upstream status,
N:    the Debian version and date the patch was first included, and any other
N:    information that would be useful if someone were investigating the patch
N:    and underlying problem. Please consider using the DEP-3 format for this
N:    information.
N:    Refer to http://dep.debian.net/deps/dep3/ for details.
N:    Severity: wishlist, Certainty: certain

[below are ok, they don't give you one]
P: libclanlib2.2-doc: no-upstream-changelog
P: libclanlib2.2: no-upstream-changelog
P: libclanlib2.2-dev: no-upstream-changelog

I: libclanlib2.2: no-symbols-control-file usr/lib/libclan22GL-2.2.so.1.0.0
N:    Although the package includes a shared library, the package does not
N:    have a symbols control file.
N:    dpkg can use symbols files in order to generate more accurate library
N:    dependencies for applications, based on the symbols from the library
N:    that are actually used by the application.
N:    Refer to the dpkg-gensymbols(1) manual page and
N:    http://wiki.debian.org/UsingSymbolsFiles for details.
N:    Severity: wishlist, Certainty: certain
I: libclanlib2.2: no-symbols-control-file usr/lib/libclan22Network-2.2.so.1.0.0
I: libclanlib2.2: no-symbols-control-file usr/lib/libclan22App-2.2.so.1.0.0
I: libclanlib2.2: no-symbols-control-file usr/lib/libclan22GUI-2.2.so.1.0.0
I: libclanlib2.2: no-symbols-control-file usr/lib/libclan22Display-2.2.so.1.0.0
I: libclanlib2.2: no-symbols-control-file usr/lib/libclan22Sqlite-2.2.so.1.0.0
I: libclanlib2.2: no-symbols-control-file usr/lib/libclan22MikMod-2.2.so.1.0.0
I: libclanlib2.2: no-symbols-control-file usr/lib/libclan22GL1-2.2.so.1.0.0
I: libclanlib2.2: no-symbols-control-file usr/lib/libclan22SWRender-2.2.so.1.0.0
I: libclanlib2.2: no-symbols-control-file usr/lib/libclan22RegExp-2.2.so.1.0.0
I: libclanlib2.2: no-symbols-control-file
I: libclanlib2.2: no-symbols-control-file usr/lib/libclan22Core-2.2.so.1.0.0
I: libclanlib2.2: no-symbols-control-file usr/lib/libclan22Sound-2.2.so.1.0.0
I: libclanlib2.2: no-symbols-control-file usr/lib/libclan22Vorbis-2.2.so.1.0.0
I: libclanlib2.2: no-symbols-control-file usr/lib/libclan22Database-2.2.so.1.0.0

W: libclanlib2.2: package-name-doesnt-match-sonames libclan22App-2.2-1
libclan22CSSLayout-2.2-1 libclan22Core-2.2-1 libclan22Database-2.2-1
libclan22Display-2.2-1 libclan22GL-2.2-1 libclan22GL1-2.2-1
libclan22GUI-2.2-1 libclan22MikMod-2.2-1 libclan22Network-2.2-1
libclan22RegExp-2.2-1 libclan22SWRender-2.2-1 libclan22Sound-2.2-1
libclan22Sqlite-2.2-1 libclan22Vorbis-2.2-1
N:    The package name of a library package should usually reflect the soname
N:    of the included library. The package name can determined from the
N:    library file name with the following code snippet:
N:     $ objdump -p /path/to/libfoo-bar.so.1.2.3 | sed -n
-e's/^[[:space:]]*SONAME[[:space:]]*//p' | sed
-e's/\([0-9]\)\.so\./\1-/; s/\.so\.//'
N:    Refer to Debian Library Packaging Guide chapter 5 (shared library
N:    packages) for details.
N:    Severity: normal, Certainty: possible

[1] http://dep.debian.net/deps/dep3/
[2] http://dep.debian.net/deps/dep5/
[3] http://wiki.debian.org/Games/VCS
[4] http://wiki.debian.org/TeamUpload

Reply to: