Re: RFS: alien-arena (updated package)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Michael Gilbert schrieb:
> Hi,
>
> I am looking for a sponsor for the new version 7.33-1 of alien-arena
> and alien-arena-data.
>
> The package appears to be lintian clean.
>
> The upload would fix these bugs: 437461, 467387, 513659, 530040,
> 552038, 592770 (one of which is a fairly serious security issue).
>
> The packages can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/contrib/a/alien-arena
> - URL: http://mentors.debian.net/debian/pool/non-free/a/alien-arena-data
>
> I would be glad if someone uploaded this package for me.
Hello,
======================
review of alien-arena:
======================
+ * New upstream release with many feature enhancments
+ (closes: #592770, #467387, #437461).
Could you please list the items like:
* New upstream (Closes: #123)
- Also fixed blubb (Closes: #456)
- And yeah this! (Closes: #789)
* I also think, that this patch here is wrong:
patches/debian-changes-7.33-1 | 1485
++++++++++++++++++++++++++
* This change should be mentioned in debian news:
11 * Config directory has been moved to '~/.config/alien-arena' to adhere
12 to the latest freedesktop standards.
* Depends for alien-arena says: alien-arena-data (= 7.33-1)
Why are you so strictly depending on the debian revision?
How would it like >= 7.33 or = 7.33?
Also my examples are bad, because you have to increase them with each
new upstream release, so on use (>= ${source:Version})
Also a question:
alien-arena (= ${binary:Version})
Does the alien-arena-server realy needs alien-arena to run? :o
* Also here a few lintian warnings to fix:
I: alien-arena source: quilt-patch-missing-description
kill-runaway-crded_tool_debianization.patch
I: alien-arena source: quilt-patch-missing-description
rcon_tool_debianization.patch
I: alien-arena source: quilt-patch-missing-description
home_as_game_dir.patch
I: alien-arena source: quilt-patch-missing-description
fix-CVE-2007-4754-CVE-2007-4755.patch
I: alien-arena source: quilt-patch-missing-description
makefile_modifications.patch
P: alien-arena: copyright-refers-to-symlink-license
usr/share/common-licenses/GPL
I: alien-arena: copyright-with-old-dh-make-debian-copyright
P: alien-arena-server: copyright-refers-to-symlink-license
usr/share/common-licenses/GPL
I: alien-arena-server: copyright-with-old-dh-make-debian-copyright
===========================
review of alien-arena-data:
===========================
It is okay, only:
I: alien-arena-data: copyright-with-old-dh-make-debian-copyright
If you have got free time, fix it :)
But I will wait with uploading the -data package, until alien-arena is
clean.
- --
/*
Mit freundlichem Gruß / With kind regards,
Patrick Matthäi
GNU/Linux Debian Developer
E-Mail: pmatthaei@debian.org
patrick@linux-dev.org
Comment:
Always if we think we are right,
we were maybe wrong.
*/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iEYEARECAAYFAktHBL8ACgkQ2XA5inpabMc/ZACfY3lfukwJdN8KAyDNfz2RrAac
JnwAn2kgFCtzSJFzBAS0LmSD3Mw3K/Hv
=qUne
-----END PGP SIGNATURE-----
Reply to: