Re: Easiest way to Debianise a package?
Hello,
I'm not a DD, but here are the first impressions I got from a quick review:
- There are lots of unnecessary files (all the .ex stuff, empty ones,
and otherwise unnecessary files). Also, yatc/trunk/debian/dirs lists
some directories which probably don't need to be created explictly.
- It's recommended to have a debian/watch file or a get-orig-source
in debian/rules to download the upstream tarball.
- Both packages have "Priority: extra" in debian/control. You
probably want "optional" there; see
/usr/share/doc/debian-policy/policy.html/ch-archive.html#s-priorities
for an explanation about all possible values.
- I haven't really checked, but on a first glance it seems like yatc
misses some build dependencies. Have you tried if it builds correctly
in a chroot (like for example with pbuilder)?
- Why is the binary package tibia-data set as architecture dependent
("Architecture: any" means that it should be compiled for all
available architectures; you probably want "all" there, which means
that it is architecture independent and the .deb only needs to be
build on one architecture).
- Please don't say which packages it requires in yatc's description.
- The descriptions could take some spell checking ("an MMORPG" -> "a
MMORPG"; "2d" -> "2D"), and I think that they are too short.
- You can remove lines 3-7 from debian/rules, the commented examples
stuff in build-stamp and the comments from binary-arch.
- tibia-data could suggest or recommend yatc.
- The current standards version is 3.7.3, not 3.7.2.
- This is only a personal preference, but if a package is licensed
under "GPL version 2 or later" I prefer to refer to
"/usr/share/common-licenses/GPL" instead of
"/usr/share/common-licenses/GPL-2" (was GPL links to the latest one,
which is that one which the FSF recommends).
But anyway, good work. I know that packaging can be quite difficult at start :).
Regards,
--
Siegfried-Angel Gevatter Pujals (RainCT)
Ubuntu Developer
Reply to: