Re: Uploaded grep 2.1-7 (source i386) to master
On Sun, Apr 05, 1998 at 12:38:13PM +0200, wakkerma@debian.org wrote:
>
> * Fix wrong patch for Bug# 20284. Note to self: don't trust
> received patches! (Bug# 20573, 20592, 20541)
This is the patch I sent you:
==============================================================
--- src/grep.c. Sat Sep 13 17:48:39 1997
+++ src/grep.c Mon Mar 30 21:00:05 1998
@@ -928,7 +928,7 @@
so we stat the file before we attempt to open it. */
struct stat st;
- if (stat (argv[optind], &st) < 0 || S_ISDIR(st.st_mode))
+ if (stat (argv[optind], &st) == 0 && S_ISDIR(st.st_mode))
{
++optind;
continue;
==============================================================
And this is the patch you applied:
==============================================================
--- grep-2.1.orig/src/grep.c
+++ grep-2.1/src/grep.c
@@ -928,7 +928,7 @@
so we stat the file before we attempt to open it. */
struct stat st;
- if (stat (argv[optind], &st) < 0 || S_ISDIR(st.st_mode))
+ if (stat (argv[optind], &st) == 0 || S_ISDIR(st.st_mode))
{
++optind;
continue;
==============================================================
They are not the same.
I agree with your sentence: don't trust received patches; but
the patch I sent you was right.
Thanks.
--
Juan Cespedes
--
To UNSUBSCRIBE, email to debian-devel-changes-request@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Reply to: