[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Closing bugs in removed packages



On Sun, Mar 23, 2003 at 07:39:26PM -0600, Adam Heath wrote:
> On Sun, 23 Mar 2003, Colin Watson wrote:
> > Adam Heath wrote:
> > > Adding reopening of archived bugs is really rather trival.  So trivial
> > > that no one has done it.
> >
> > I tried and got lost in your real-time database code, I'm afraid. :( If
> > you feel like doing that half I'll do the other half.
> 
> What real-time code?  Nothing official is using the code in ~doogie/debbugs/.

Sure, but that doesn't mean I think it's OK to break it.

> Looking at the code, it appears it may already handle it.  The large
> if block in notebug() is against the current state of the bug.  You'll
> then notice that once this is figured out, it deletes the old state,
> whether it's now archived, but wasn't previously, or is now active,
> and was archived before.

I assumed we'd need a new type in debbugs.trace (to go with 'new',
'change', and 'archive'). Looking at it harder, though, that field seems
to be purely cosmetic: nothing touches it.

Could you please change makeindex.pl to recognize 'unarchive' as well as
those three? I'd prefer to keep the operations separate.

--- makeindex.pl.orig	Sun Mar 23 20:26:40 2003
+++ makeindex.pl	Sun Mar 23 20:27:38 2003
@@ -650,7 +650,7 @@
 			open( DIFF, "diff -Nu '$gIndexDir/debbugs.trace' '$gIndexDir/debbugs.trace.new'|" );
 			while ( <DIFF> ) {
 				chomp;
-				$bugs{ $2 } = 1 if ( m/^[+](new|change|archive) (\d+)$/ );
+				$bugs{ $2 } = 1 if ( m/^[+](new|change|archive|unarchive) (\d+)$/ );
 			}
 			push @moveCode, sub { move( "$gIndexDir/debbugs.trace.new", "$gIndexDir/debbugs.trace" ); };
 		} elsif ( $opt eq "-allbug" ) {

-- 
Colin Watson                                  [cjwatson@flatline.org.uk]



Reply to: