On Fri, Apr 06, 2001 at 11:11:58AM +0200, Wichert Akkerman wrote: > Previously Anthony Towns wrote: > > postinst: > > if [ "$1" = "configure" -a "$2" = "" ]; then > > update-inetd add cvspserver tcp /usr/sbin/cvs-pserver --hint=tcpd > > elif [ "$1" = "configure" ]; then > > update-inetd enable cvspserver tcp /usr/sbin/cvs-pserver remove-cvs > > fi > This is wrong: upgrading a package should not re-enable a service if the > admin disabled it. This doesn't do that. If the admin disables a service, she either adds a # in front of the appropriate line in /etc/inetd.conf, or types: # update-inetd disable cvspserver tcp /usr/sbin/cvs-pserver (note the lack of a fourth argument) > I also doubt that add should imply enable, Installing the package providing a service almost always implies enabling the service. Support's there for the exceptional cases (the --disable parameter to "add"). Optimise for the normal case, etc. > This would have the advantage that it doesn't override an admins choice > to disable a service or use a different version of it. The admin's decisions about disabling and enabling a service are completely separate from the package's decisions: that's why all the enable/disable things a package does have "reasons" (like remove-exim, or upgrade-exim, or alternative-finger). Cheers, aj -- Anthony Towns <aj@humbug.org.au> <http://azure.humbug.org.au/~aj/> I don't speak for anyone save myself. GPG signed mail preferred. ``_Any_ increase in interface difficulty, in exchange for a benefit you do not understand, cannot perceive, or don't care about, is too much.'' -- John S. Novak, III (The Humblest Man on the Net)
Attachment:
pgpmf30jacGOU.pgp
Description: PGP signature