Re: Bug#843727: fix inside

[Aurélien COUDERC <zecoucou@free.fr>]

Le jeudi 10 novembre 2016, 10:27:26 CET Eric Valette a écrit :
> On 11/09/2016 10:53 PM, Aurélien COUDERC wrote:
> > control: tags -1 pending
> >
> > Le mercredi 9 novembre 2016, 22:45:32 CET Eric Valette a écrit :
> >> the wrong code is calling "which update-initramfs" outside of if
> >> because then the set -e catch an error and there is no way the
> >> test on $? can work
> >>
> >> correct code is:
> >>
> >>      if which update-initramfs > /dev/null; then
> >>          update-initramfs -u
> >>      fi
> >
> > Yes, was preparing that already after reading your last mail. :-)
> >
> > It’s now committed to SVN and will be in the next upload.
> 
> 
> While you are at it, maybe it is time to replace update-grub2 by 
> update-grub because the move is complete even for jessie...

Committed, thanks.

@all, in postinst I see that update-grub is called with
         update-grub || true
to ensure package installation succeeds even if it returns an error.

Shouldn't we do the same with update-initramfs -u ?
Currently it's called as is so if returns non-zero it'll break package install like #843727 due to set -e.


Thanks,
--Aurélien