tags 680583 + patch thanks Hi Paul! On Fri, 06 Jul 2012 18:57:11 -0600, Paul Tagliamonte wrote: > Two things off the bat: > > it's not a major effect of the usability -- most installs will find > librsvg2-common on the system anyway, and it's only a few megs of space. > Most ARM machines I have have at least 4 gigs of space, and I'd not worry > too much about stuff like this. I worry, and not only because I worked in the past on ARM machines (Debian on the Openmokos), but because I really want Depends: to be what they mean. It seems that in these days of "disk is cheap" my reasoning is not so common, though. > I understand an unneeded dep is annoying and can cause problems, but I > don't see the 'important' severity. If you're that crunched, kill off > desktop-base entirely -- it's just themes ;) It is not *just* themes, it is the default Debian graphical dress, so something I consider important. Please note that I discovered this bug while trying to have a very minimal installation of the Debian Installer BabelBox for automatic tests: given that I am very low on local disk space (less than 2GB), every MB counts. > I'm happy to change it back if you can justify it ;) No need, I explained my point, so I am fine with it and you are the maintainer, not the other way around ;-) > Secondly, while you did include a changelog update, you forgot to > include the control file update -- please re-send with an attached patch > + fix the control tags :) Sorry, the illness hitting DebCamp12 was the cause: --8<---------------cut here---------------start------------->8--- Index: debian/control =================================================================== --- debian/control (revision 294) +++ debian/control (working copy) @@ -17,8 +17,8 @@ Package: desktop-base Architecture: all -Depends: librsvg2-common Pre-Depends: dpkg (>= 1.15.7.2~) +Recommends: librsvg2-common Suggests: gnome | kde-standard | xfce4 | wmaker Description: common files for the Debian Desktop This package contains various miscellaneous files which are used by Index: debian/changelog =================================================================== --- debian/changelog (revision 294) +++ debian/changelog (working copy) @@ -5,8 +5,12 @@ * Fix typo in plymouth theme. (Closes: #679357) * Updated ink-splated kde wallpaper, to fix alignment issues. - -- Eshat Cakar <info@eshat.de> Wed, 27 Jun 2012 22:08:35 +0200 + [ Luca Capello ] + * debian/control: + + demote librsvg2-common to Recommends (Closes: #680583). + -- + desktop-base (7.0.0) unstable; urgency=low [ Eshat Cakar ] --8<---------------cut here---------------end--------------->8--- > After we get an ACK (read more below), i'll happily apply it. > > On Fri, Jul 06, 2012 at 06:10:45PM -0600, Luca Capello wrote: >> However, so far I have failed to understand what "SVG support" means, >> given that it does not seems to be needed at all and actually it brings >> a lot of (useless) dependencies: > > It appears it's 60 or so megs unpacked, it's a few, but not a lot IMHO. As I explained above, it is a lot if you consider what is actually needed. >> At reboot, GRUB2 shows the SpaceFun theme. The same is true for wheezy: >> desktop-base *installs* fine without librsvg2-common. IMHO this > > That might be the case, but it appears to be a runtime thing, we need to > be careful not to needlessly klobber something, desktop-base is a pretty > monolithic package to begin with, so making judgements like this is > always a bit tricky. I was discussing with Didier Raboud (Bcc:ed) about that here at DebConf12: desktop-base does not use librsvg2-common in their maintainer scripts, so IMHO that strict dependency is not even a runtime one. Instead, any other package depending on desktop-base and using SVG files should Depends: on librsvg2-common. >> dependency should be reflected by those packages *using* SVG files, not >> by desktop-base, which only ships them: > > What an interesting report, thank you! (Also, SpaceFun is no longer the > default in Wheezy, I suggest you update ;) ) The Debian Installer's BabelBox where I found this bug is a stable showcase, so SpaceFun is the correct theme. And as I wrote, I tried on wheezy: same problem ;-) > The interesting part is this - librsvg2-common provides SVG rendering > for GTK+ applications, which appears to be included as a Depends: on GDM > (although not KDM, because I'm guessing it has it's own special sauce > for Qt / SVG) Thank you for the check. I tested KDM on a clean virtual wheezy (DI-a1-amd64). Actually, after an `apt-get install kdm` (Recommends: on) there is no librsvg2-common installed, but all this latter's dependencies are already installed and there is libqt4-svg. Forcing the installation of desktop-base alone results in a correct joy-enabled KDM, tested with Didier's full KDE installation. If I am right, this should mean that desktop-base should have a "Recommends: librsvg2-common | libqt4-svg". I also tested lightdm (again, Recommends: on), which actually is a no-problem given that it Recommends: desktop-base ;-) > I'm willing to entertain this change, but I'd much rather know why it > was added in the first place. I'd hate to reintroduce a bug (esp post > freeze). > > It's only a few megs, but I understand the concern. Actually, librsvg2-common is only 210kB, but all its Depends: are huge! > I've CC'd lool to see if he remembers anything about this situation. Thank you. Bonus point: still speaking about SVG support, I found out that the commented librsvg2-bin Build-Depends: was for usplash (r127), so I guess now it could be safely removed ;-) Thx, bye, Gismo / Luca
Attachment:
pgpPCw79oxtDN.pgp
Description: PGP signature