[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#605116: kde: lots of non-wallpaper pictures show up in kde background selector



Hi,

Alle sabato 27 novembre 2010, Yves-Alexis Perez ha scritto:
> On sam., 2010-11-27 at 17:47 +0100, Michael Biebl wrote:
> > On 27.11.2010 16:34, Yves-Alexis Perez wrote:
> > > On sam., 2010-11-27 at 16:01 +0100, Michael Biebl wrote:
> > >> In the KDE wallpaper selector, a lot of non-wallpaper files
> > >> started showing up with the update of desktop-base:
> > >> grub images, login splash images etc.
> > >> 
> > >> Also, several images are shown with different resolutions.
> > >> 
> > >> This clutters the wallpaper selector significantly.
> > > 
> > > I have to admit I don't really care, this was requested by Pino
> > > Toscano (CC:ed) so it'd be easier to select wallpapers.
> > 
> > It's not making it easier but harder.
> 
> I won't argue on this, maybe Pino has a comment.

This is because of the mixup, I guess.
I did a simple patch (attached, tested) which, instead of adding 
/u/s/images/desktop-base to the wallpaper paths, symlinks the 
backgrounds in /u/s/wallpapers (and removes dir_wallpaper from 
kdeglobals).
Note this still leaves the duplicates wallapers in case they are both in 
SVG and PNG format, maybe Yves-Alexis has an idea for removing the 
duplicates, preferring the SVGs.

> > It looks to me as if the right way to do this in KDE is to install
> > a desktop file in /usr/share/wallpapers/SpaceFun/metadata.desktop,
> > create a subfolder images/, and provide the images for the
> > different resolutions (which could be symlinks, I guess).
> 
> That looks too complicated for me. I have no intent to spent time on
> the KDE part if no KDE people is interested either. If you think it
> useless, I'll just drop that on a future upload.

I thought about doing this as well, but I wanted to automate the 
creation procedure for similar wallpaper structures, either for both the 
naming and the size of the wallpaper files inside the wallpaper 
packages. (Also, it would require metadata.desktop files with name/email 
of the creator(s) and the license, but I guess this wouldn't be an 
issue.)

-- 
Pino Toscano
Index: profiles/kde-profile/kdeglobals
===================================================================
--- profiles/kde-profile/kdeglobals     (revision 211)
+++ profiles/kde-profile/kdeglobals     (working copy)
@@ -1,3 +1,2 @@
 [Directories]
 dir_config=/usr/share/desktop-base/profiles/kde-profile/share/config/
-dir_wallpaper=/usr/share/images/desktop-base
Index: Makefile
===================================================================
--- Makefile    (revision 211)
+++ Makefile    (working copy)
@@ -24,6 +24,10 @@
        mkdir -p $(DESTDIR)/usr/share/images/desktop-base
        $(INSTALL) $(BACKGROUNDS) $(DESTDIR)/usr/share/images/desktop-base
        cd $(DESTDIR)/usr/share/images/desktop-base && ln -s $(DEFAULT_BACKGROUND) default
+       mkdir -p $(DESTDIR)/usr/share/wallpapers
+       for wp in $(filter-out $(wildcard backgrounds/*grub*),$(BACKGROUNDS)) ; do \
+           ln -s /usr/share/images/desktop-base/`basename $${wp}` /usr/share/wallpapers/ ; \
+       done
        # splash files
        $(INSTALL) $(SPLASH) $(DESTDIR)/usr/share/images/desktop-base
        # emblems

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: