review of release_2.6
Hello Don,
I found two debbugs git repos:
https://bugs.debian.org/debbugs-source/debbugs.git/
https://salsa.debian.org/debbugs-team/debbugs.git
Which one is the canonical one ?
I have reviewed the branch release_2.6.
debbugs is missing a Build-Depends on libmail-message-perl
(you already added a Depends in fe90d1cbac)
I join 5 patches to be applied with "git am".
The one before last update the changelog.
I really suggest to remove the build-dependency on inkscape
and just add the png to the git repos.
Installing inkscape and all its dependency slowdown pbuilder
too much.
A smaller alternative is cairosvg, but even that seems too
much.
In the BTS there are 6 bugs marked as fixed but not closed.
Maybe it is time to close them ?
Cheers,
--
Bill. <ballombe@debian.org>
Imagine a large red swirl here.
>From 0cea1269c60d48c868d94734feb58bba39afe2d4 Mon Sep 17 00:00:00 2001
From: Bill Allombert <Bill.Allombert@math.u-bordeaux.fr>
Date: Tue, 5 Nov 2024 18:06:08 +0100
Subject: [PATCH 1/5] Fix typo psuedoheader -> pseudoheader
---
Debbugs/Config.pm | 2 +-
debian/changelog | 2 +-
scripts/process | 4 ++--
t/06_mail_handling.t | 2 +-
4 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/Debbugs/Config.pm b/Debbugs/Config.pm
index a02072c..a9d79f0 100644
--- a/Debbugs/Config.pm
+++ b/Debbugs/Config.pm
@@ -614,7 +614,7 @@ set_default(\%config,'package_version_re',
=item default_package
This is the name of the default package. If set, bugs assigned to
-packages without a maintainer and bugs missing a Package: psuedoheader
+packages without a maintainer and bugs missing a Package: pseudoheader
will be assigned to this package instead.
Defaults to unset, which is the traditional debbugs behavoir
diff --git a/debian/changelog b/debian/changelog
index 0e3917e..5ce5191 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,6 +1,6 @@
debbugs (2.6.1) unstable; urgency=medium
- * Add support for a Done: psuedoheader (closes: #950133)
+ * Add support for a Done: pseudoheader (closes: #950133)
* Fix unescaped From (closes: #983847)
* Actually return message/rfc822 when there is a single message instead
of mbox (closes: #1009181)
diff --git a/scripts/process b/scripts/process
index 6e0a247..0bb5759 100755
--- a/scripts/process
+++ b/scripts/process
@@ -222,7 +222,7 @@ if (@bodylines and $bodylines[0] =~ /^-----BEGIN PGP SIGNED/) {
map { s/^- // } @bodylines;
}
-#psuedoheaders
+#pseudoheaders
my %pheader;
my @control_bits;
my @usertag_bits;
@@ -233,7 +233,7 @@ for my $phline (@bodylines)
# Fixes #488554
$phline =~ s/\xef\xbb\xbf//g;
$phline =~ s/\N{U+FEFF}//g;
- last if $phline !~ m/^([\w-]+): # psuedoheader
+ last if $phline !~ m/^([\w-]+): # pseudoheader
(?:\s|\N{U+00A0})* # zero or more spaces, including
# non-breaking space
(\S.*)/x; # pseudoheader value
diff --git a/t/06_mail_handling.t b/t/06_mail_handling.t
index 2f8f452..0501c93 100644
--- a/t/06_mail_handling.t
+++ b/t/06_mail_handling.t
@@ -113,7 +113,7 @@ my $status = read_bug(bug=>1);
ok($status->{subject} eq 'new title','bug 1 retitled');
ok($status->{severity} eq 'wishlist','bug 1 wishlisted');
-# now check to see if we can close a bug using a psuedoheader done
+# now check to see if we can close a bug using a pseudoheader done
send_message(to => '1-done@bugs.something',
headers => [To => 'control@bugs.something',
From => 'foo@bugs.something',
--
2.39.5
>From 3dae25f9fb268cd81ee8a517e6d842699eb29ae8 Mon Sep 17 00:00:00 2001
From: Bill Allombert <Bill.Allombert@math.u-bordeaux.fr>
Date: Wed, 6 Nov 2024 10:59:06 +0100
Subject: [PATCH 2/5] debian/control: add Build-Dependency on
libmail-message-perl
---
debian/control | 1 +
1 file changed, 1 insertion(+)
diff --git a/debian/control b/debian/control
index bcd78a5..8018a63 100644
--- a/debian/control
+++ b/debian/control
@@ -13,6 +13,7 @@ Build-Depends-Indep: libparams-validate-perl,
libhttp-server-simple-perl, libtest-www-mechanize-perl,
libmail-rfc822-address-perl, libsafe-hole-perl, libuser-perl,
libconfig-simple-perl, libtest-pod-perl, liblist-allutils-perl,
+ libmail-message-perl,
# used by Debbugs::Libravatar and libravatar.cgi
libfile-libmagic-perl, libgravatar-url-perl, libwww-perl, imagemagick,
libtext-template-perl, graphviz, libtext-iconv-perl, libnet-server-perl,
--
2.39.5
>From 74f74f2edadab4c19a1677555eeb07dc3fe1d515 Mon Sep 17 00:00:00 2001
From: Bill Allombert <Bill.Allombert@math.u-bordeaux.fr>
Date: Wed, 6 Nov 2024 11:39:48 +0100
Subject: [PATCH 3/5] debbugs-local: Depends on sensible-utils
---
debian/control | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/debian/control b/debian/control
index 8018a63..75b5955 100644
--- a/debian/control
+++ b/debian/control
@@ -89,7 +89,8 @@ Depends:
${perl:Depends},
${misc:Depends},
libdebbugs-perl, debbugs-web, libconfig-simple-perl,
- libuser-perl, rsync, libhttp-server-simple-perl, libnet-server-perl
+ libuser-perl, rsync, libhttp-server-simple-perl, libnet-server-perl,
+ sensible-utils
Description: Run and maintains a local mirror of the Debian BTS
Debian has a bug tracking system which files details of bugs reported
by users and developers. Each bug is given a number, and is kept on
--
2.39.5
>From 24cef5f7f3c6cb067a8a3000d792dbfa6026345d Mon Sep 17 00:00:00 2001
From: Bill Allombert <Bill.Allombert@math.u-bordeaux.fr>
Date: Wed, 6 Nov 2024 11:01:51 +0100
Subject: [PATCH 4/5] debian/changelog: Update to reflect changes
---
debian/changelog | 28 ++++++++++++++++++++++++++--
1 file changed, 26 insertions(+), 2 deletions(-)
diff --git a/debian/changelog b/debian/changelog
index 5ce5191..638a120 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,15 +1,39 @@
debbugs (2.6.1) unstable; urgency=medium
+ [ Otto Kekäläinen ]
+ * Fix filename in install: UPGRADE -> UPGRADE.md (closes: #903413)
+
+ [ Don Armstrong ]
* Add support for a Done: pseudoheader (closes: #950133)
* Fix unescaped From (closes: #983847)
+ * Support 7 digit bugs in bugspam.cgi
* Actually return message/rfc822 when there is a single message instead
of mbox (closes: #1009181)
+ * Include non-free-firmware; thanks to Cyril Brulebois for the patch
* Fix missing escaping of comma in address fields (closes: #1041638)
- * Sort blocked-by (closes: 751808), thanks to Tim Landscheidt.
+ * Sort blocked-by (closes: #751808), thanks to Tim Landscheidt.
+ * add WSDL contributed by Michael Albinus and Felix Lechner
* Don't linkify trailing ; in bug messages (closes: #1076323), thanks to
Blair Noctis.
- -- Don Armstrong <don@debian.org> Fri, 09 Mar 2018 11:17:10 -0800
+ [ Chris Lamb ]
+ * Don't print strange-looking "Usertags are now: ." message when removing all
+ usertags.
+
+ [ Paul Wise ]
+ * Add support for setting usertags for multiple users in new bugs
+ (closes: #582171)
+ * Prevent usertags created at submit time from including invalid trailing
+ chars
+ * Use a checkbox and CSS to show info messages instead of JavaScript
+ * Allow exporting of debbugs responses to mbox format when requested
+
+ [ Bill Allombert ]
+ * Add Build-Depends-Indep on libmail-message-perl for running the test-suite
+ * debbugs-local: add Depends on sensible-utils
+ * Actually upload the package (closes: #477182, #1079842)
+
+ -- Bill Allombert <ballombe@debian.org> Tue, 05 Nov 2024 19:08:52 +0100
debbugs (2.6.0) unstable; urgency=medium
--
2.39.5
>From 169d79f016ec887d03edd8be5167addcca50cd69 Mon Sep 17 00:00:00 2001
From: Bill Allombert <Bill.Allombert@math.u-bordeaux.fr>
Date: Wed, 6 Nov 2024 11:52:45 +0100
Subject: [PATCH 5/5] Add myself (Bill) as Uploader
---
debian/control | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/debian/control b/debian/control
index 75b5955..e93e32f 100644
--- a/debian/control
+++ b/debian/control
@@ -2,7 +2,8 @@ Source: debbugs
Section: misc
Priority: optional
Maintainer: Debbugs developers <debian-debbugs@lists.debian.org>
-Uploaders: Colin Watson <cjwatson@debian.org>, Don Armstrong <don@debian.org>
+Uploaders: Colin Watson <cjwatson@debian.org>, Don Armstrong <don@debian.org>,
+ Bill Allombert <ballombe@debian.org>
Standards-Version: 4.1.3
Vcs-Browser: https://salsa.debian.org/debbugs-team/debbugs
Vcs-Git: https://salsa.debian.org/debbugs-team/debbugs.git
--
2.39.5
Reply to: