[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[PATCH] removed unused *List config options



$gRequestList
$gSubmitterList
$gControlList
$gMaintList

In learning to run debbugs, they were a frustrating waste of my time. I
looked into the git history for 2 of them, they were introduced around
the year 2000 and never got used.

How I searched for their usage:

shopt -s extglob
grep -riE '(control|maint|submitter|request).?list' !(.git)
---
 devel/debbugs.cfg         |  4 ----
 devel/predef.tags         |  4 ----
 examples/config           |  4 ----
 examples/config.debian    |  4 ----
 examples/debbugs.cfg      |  4 ----
 examples/debbugs.cfg.2    |  4 ----
 lib/Debbugs/Config.pm     | 16 ++--------------
 scripts/config.in.default |  4 ----
 8 files changed, 2 insertions(+), 42 deletions(-)

diff --git a/devel/debbugs.cfg b/devel/debbugs.cfg
index 3d44550..4214864 100644
--- a/devel/debbugs.cfg
+++ b/devel/debbugs.cfg
@@ -18,13 +18,9 @@ Template Dir = "template-dir"
 Not-Don-Con = "not-don-con"
 Maintainer File = "maintainer-file"
 Submit List = "submit-list"
-Maint List = "maint-list"
 Quiet List = "quiet-list"
 Forwarded List = "forwarded-list"
 Done List = "done-list"
-Request List = "request-list"
-Submitter List = "submitter-list"
-Control List = "control-list"
 Summary List = "summary-list"
 Mirror List = "mirror-list"
 Mailer = "mailer"
diff --git a/devel/predef.tags b/devel/predef.tags
index edc2d7d..b9cfbb7 100644
--- a/devel/predef.tags
+++ b/devel/predef.tags
@@ -13,13 +13,9 @@ LIST_DOMAIN		List Domain		Globals->list-domain
 WEB_DOMAIN		Web Domain		Globals->web-domain
 CGI_DOMAIN		CGI Domain		Globals->cgi-domain
 SUBMIT_LIST		Submit List		Globals->submit-list
-MAINT_LIST		Maint List		Globals->maint-list
 QUIET_LIST		Quiet List		Globals->quiet-list
 FORWARDED_LIST		Forwarded List		Globals->forwarded-list
 DONE_LIST		Done List		Globals->done-list
-REQUEST_LIST		Request List		Globals->request-list
-SUBMITTER_LIST		Submitter List		Globals->submitter-list
-CONTROL_LIST		Control List		Globals->control-list
 SUMMARY_LIST		Summary List		Globals->summary-list
 MIRROR_LIST		Mirror List		Globals->mirror-list
 MIRROS			Mirrors			Globals->mirrors
diff --git a/examples/config b/examples/config
index fa7c838..ad53d33 100644
--- a/examples/config
+++ b/examples/config
@@ -36,14 +36,10 @@ $gUnknownMaintainerEmail = "$gMaintainerEmail";		# e.g. unknown-package@qa.debia
 # if you don't want lists, set them all to $gMaintainerEmail
 # if you don't want that mail at all, filter it out somehow :)
 $gSubmitList = "bug-submit-list";		# e.g. debian-bugs-dist
-$gMaintList = "bug-maint-list";			# e.g. debian-bugs-dist
 $gQuietList = "bug-quiet-list";			# e.g. debian-bugs-dist
 $gForwardList = "bug-forward-list";		# e.g. debian-bugs-forwarded
 $gDoneList = "bug-done-list";			# e.g. debian-bugs-closed
-$gRequestList = "bug-request-list";		# e.g. debian-bugs-dist
-$gSubmitterList = "bug-submitter-list";		# e.g. debian-bugs-dist
 $gStrongList = "bug-strong-list";		# e.g. debian-bugs-dist
-$gControlList = "bug-control-list";		# e.g. debian-bugs-dist
 $gSummaryList = "bug-summary-list";		# e.g. debian-bugs-reports
 $gMirrorList = "bug-mirrors-list";		# sends to all mirrors
 
diff --git a/examples/config.debian b/examples/config.debian
index 193e7b5..23435d6 100644
--- a/examples/config.debian
+++ b/examples/config.debian
@@ -21,13 +21,9 @@ $gMaintainerEmail = "owner\@bugs.debian.org";
 
 # BTS mailing lists, at $gListDomain
 $gSubmitList = "debian-bugs-dist";
-$gMaintList = "debian-bugs-dist";
 $gQuietList = "debian-bugs-dist";
 $gForwardList = "debian-bugs-forwarded";
 $gDoneList = "debian-bugs-closed";
-$gRequestList = "debian-bugs-dist";
-$gSubmitterList = "debian-bugs-dist";
-$gControlList = "debian-bugs-dist";
 $gSummaryList = "debian-bugs-reports";
 $gMirrorList = "debian-bugs-mirror";			# sends to all mirrors
 $gStrongList = "debian-bugs-rc";
diff --git a/examples/debbugs.cfg b/examples/debbugs.cfg
index 37f691d..de9522e 100644
--- a/examples/debbugs.cfg
+++ b/examples/debbugs.cfg
@@ -36,13 +36,9 @@ Not-Don-Con = notify-done-control.txt
 # Lists                                                                  #
 ##########################################################################
 Submit List = project-bugs-dist
-Maint List = project-bugs-private
 Quiet List = project-bugs-private
 Forwarded List = project-bugs-forwarded
 Done List = project-bugs-closed
-Request List = project-bugs-request
-Submitter List = project-bugs-submitter
-Control List = project-bugs-dist
 Summary List = project-bugs-reports
 Mirror List = bts-mirrors
 
diff --git a/examples/debbugs.cfg.2 b/examples/debbugs.cfg.2
index abb7bec..317707e 100644
--- a/examples/debbugs.cfg.2
+++ b/examples/debbugs.cfg.2
@@ -13,13 +13,9 @@ Web Dir = /var/lib/debbugs/www
 Doc Dir = /var/lib/debbugs/www/txt
 Maintainer File = /etc/debbugs/Maintainers
 Pseudo Description File = /etc/debbugs/pseudo-packages.description
-Maint List = doogbugs-maint
 Quiet List = doogbugs-quiet
 Forwarded List = doogbugs-forwarded
 Done List = doogbugs-done
-Request List = doogbugs-request
-Submitter List = doogbugs-submitter
-Control List = doogbugs-control
 Summary List = doogbugs-summary
 Mirror List = doogbugs-mirrors
 Mailer = exim
diff --git a/lib/Debbugs/Config.pm b/lib/Debbugs/Config.pm
index bfddacc..bf73f67 100644
--- a/lib/Debbugs/Config.pm
+++ b/lib/Debbugs/Config.pm
@@ -53,8 +53,8 @@ BEGIN {
 				 qw($gPackagePages $gSubscriptionDomain $gProject $gProjectTitle),
 				 qw($gMaintainer $gMaintainerWebpage $gMaintainerEmail $gUnknownMaintainerEmail),
 				 qw($gPackageTrackingDomain $gUsertagPackageDomain),
-				 qw($gSubmitList $gMaintList $gQuietList $gForwardList),
-				 qw($gDoneList $gRequestList $gSubmitterList $gControlList),
+				 qw($gSubmitList $gQuietList $gForwardList),
+				 qw($gDoneList),
 				 qw($gStrongList),
 				 qw($gBugSubscriptionDomain),
 				 qw($gPackageVersionRe),
@@ -341,18 +341,10 @@ set_default(\%config,'machine_name',sub {Sys::Hostname::hostname()});
 
 =item submit_list
 
-=item maint_list
-
 =item forward_list
 
 =item done_list
 
-=item request_list
-
-=item submitter_list
-
-=item control_list
-
 =item summary_list
 
 =item mirror_list
@@ -362,13 +354,9 @@ set_default(\%config,'machine_name',sub {Sys::Hostname::hostname()});
 =cut
 
 set_default(\%config,   'submit_list',   'bug-submit-list');
-set_default(\%config,    'maint_list',    'bug-maint-list');
 set_default(\%config,    'quiet_list',    'bug-quiet-list');
 set_default(\%config,  'forward_list',  'bug-forward-list');
 set_default(\%config,     'done_list',     'bug-done-list');
-set_default(\%config,  'request_list',  'bug-request-list');
-set_default(\%config,'submitter_list','bug-submitter-list');
-set_default(\%config,  'control_list',  'bug-control-list');
 set_default(\%config,  'summary_list',  'bug-summary-list');
 set_default(\%config,   'mirror_list',   'bug-mirror-list');
 set_default(\%config,   'strong_list',   'bug-strong-list');
diff --git a/scripts/config.in.default b/scripts/config.in.default
index f8c03b2..01e2147 100644
--- a/scripts/config.in.default
+++ b/scripts/config.in.default
@@ -28,13 +28,9 @@ $gPseudoDescFile = "/etc/debbugs/pseudo-packages.description";
 
 #lists
 $gSubmitList = "submit.list";			#debian-bugs-dist@lists
-$gMaintList = "maint.list";				#
 $gQuietList = "quiet.list";				#
 $gForwardList = "forward.list";			#debian-bugs-forwarded@lists
 $gDoneList = "done.list";				#debian-bugs-closed@lists
-$gRequestList = "request.list";
-$gSubmitterList = "submitter.list";
-$gControlList = "control.list";
 $gMirrorList = "mirrors.list";          #sends to all mirrors
 
 #config
-- 
2.34.1


Reply to: