Bug#910360: debbugs: get_bug_log SOAP operation truncates message
On Mon, 08 Oct 2018, Michael Albinus wrote:
> Well, get_bug_log is already prepared to return the attachments, it
> just returns an empty array for the time being. As proof of concept,
> I've implemented attachments for this function, see attached patch.
> This needs *much* more polishing. On debbugs.gnu.org, we run a very
> old version of the debbugs software, so I needed to merge my changes
> into the recent version from the debbugs git repository, and I
> couldn't test that result. Furthermore, I did only some very short
> test runs (with the example which triggered this bug report); I'm
> pretty sure the MIME multipart handling needs much more attention.
There are two main reasons why I didn't really complete this part of the
interface:
1) Returning large attachments in get_mail_log() would be fairly
surprising to existing users of that interface; it should really return
some kind of record of the MIME structure which could then be retrieved
using a second interface
2) MIME messages are much more complicated than just a list of
attachments; there could be additional messages with more attachments
within them
So instead of completing the engineering, I punted, and provided the
important part of the interface (access to the main text part of the
message), and left the unimportant part for as technical debt.
I'd be happy to accept a patch which modified get_mail_log to also
include the mime structure in attachments (or something like that), and
a second SOAP API which provided a mechanism to retrieve those
attachments. [As I think SOAP is a technical dead end, I also think that
a REST API should probably do the same thing... but I'm really short on
time.]
--
Don Armstrong https://www.donarmstrong.com
Grimble left his mother in the food store and went to the launderette
and watched the clothes go round. It was a bit like color television
only with less plot.
-- Clement Freud _Grimble_
Reply to: