[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#688344: marked as done (Handling of gSubscriptionDomain and gBugSubscriptionDomain)



Your message dated Mon, 26 Mar 2018 18:50:17 +0000
with message-id <E1f0XCD-0001Tb-Kx@fasolo.debian.org>
and subject line Bug#688344: fixed in debbugs 2.6.0
has caused the Debian Bug report #688344,
regarding Handling of gSubscriptionDomain and gBugSubscriptionDomain
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
688344: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=688344
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: debbugs
Severity: normal
Version: 2.4.2~exp2
Tags: patch

Hi Don,

attached is a patch against your latest Git repos that fixes the handline of undefined (or defined as "") variables gSubscriptionDomain and gBugSubscriptionDomain.

In my setup the process script sent out mails like hell, though I had the variables defined as "" in the config file.

Mike


--

DAS-NETZWERKTEAM
mike gabriel, rothenstein 5, 24214 neudorf-bornstein
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb
>From 7c95815e7b47588e4982238e099fa48eb2e78ee3 Mon Sep 17 00:00:00 2001
From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
Date: Fri, 21 Sep 2012 21:57:14 +0200
Subject: [PATCH 2/2] Make sure that mails to gSubscriptionDomain and
 gBugSubscriptionDomain are only sent out if the
 variables in config are defined and have a lenght < 0.

---
 debian/changelog |    3 +++
 scripts/process  |   22 ++++++++++++++++------
 2 files changed, 19 insertions(+), 6 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index 786f92b..1d062f9 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -41,6 +41,9 @@ debbugs (2.4.2~exp2) UNRELEASED; urgency=low
   * Update postfix section in Readme.mail. Closes: #688109.
   * Provide gStrongList configuration option in config file to make
     a site admin aware of its existence.
+  * Make sure that mails to gSubscriptionDomain and gBugSubscriptionDomain
+    are only sent out if the variables in config are defined and
+    have a lenght < 0.
 
  -- Don Armstrong <don@debian.org>  Wed, 25 Aug 2010 01:57:38 -0700
 
diff --git a/scripts/process b/scripts/process
index 4dd56fd..9fb2c2f 100755
--- a/scripts/process
+++ b/scripts/process
@@ -447,8 +447,16 @@ if ($codeletter eq 'D' || $codeletter eq 'F')
 
 	# Add bug mailing list to $generalbcc as appropriate
  	# This array is used to specify bcc in the cases where we're using create_mime_message.
- 	my @generalbcc = (@generalcc,@addsrcaddrs,"bugs=$ref\@$gListDomain");
-	my $generalbcc = join(', ', $generalcc, @addsrcaddrs,"bugs=$ref\@$gListDomain");
+	my @generalbcc = @generalcc;
+	my $generalbcc = $generalcc;
+	if (defined $config{subscription_domain} and length $config{subscription_domain}) {
+	    my @generalbcc = (@generalbcc, @addsrcaddrs);
+	    my $generalbcc = join(', ', $generalbcc, @addsrcaddrs);
+	}
+	if (defined $config{bug_subscription_domain} and length $config{bug_subscription_domain}) {
+	    my @generalbcc = (@generalbcc, "bugs=$ref\@$config{bug_subscription_domain}");
+	    my $generalbcc = join(', ', $generalbcc, "bugs=$ref\@$config{bug_subscription_domain}");
+	}
 	$generalbcc =~ s/\s+\n\s+/ /g;
 	$generalbcc =~ s/^\s+/ /; $generalbcc =~ s/\s+$//;
 	if (length $generalbcc) {$generalbcc = "Bcc: $generalbcc\n"};
@@ -721,7 +729,9 @@ if (defined $gStrongList and isstrongseverity($data->{severity})) {
 }
 
 # Send mail to the per bug list subscription too
-#push @bccs, "bugs=$ref\@$gListDomain";
+if (defined $config{bug_subscription_domain} and length $config{bug_subscription_domain}) {
+    push @bccs, "bugs=$ref\@$config{bug_subscription_domain}";
+}
 
 if (defined $pheader{source}) {
     # Prefix source versions with the name of the source package. They
@@ -1260,15 +1270,15 @@ sub checkmaintainers {
 	$p =~ /((?:src:)?[a-z0-9.+-]+)/;
 	$p = $1;
 	next unless defined $p;
-	if (defined $gSubscriptionDomain) {
+        if (defined $config{subscription_domain} and length $config{subscription_domain}) {
 	    my @source = binary_to_source(binary => $p,
 					  source_only => 1,
 					 );
 	    if (@source) {
 		push @addsrcaddrs,
-		    map {"$_\@$gSubscriptionDomain"} @source;
+		    map {"$_\@$config{subscription_domain}"} @source;
 	    } else {
-		push @addsrcaddrs, "$p\@$gSubscriptionDomain";
+		push @addsrcaddrs, "$p\@$config{subscription_domain}";
 	    }
 	}
 	# this is utter hackery until we switch to Debbugs::Recipients
-- 
1.7.10

Attachment: pgpqcsy7Bozbd.pgp
Description: Digitale PGP-Unterschrift


--- End Message ---
--- Begin Message ---
Source: debbugs
Source-Version: 2.6.0

We believe that the bug you reported is fixed in the latest version of
debbugs, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 688344@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Don Armstrong <don@debian.org> (supplier of updated debbugs package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 26 Feb 2018 11:31:48 -0800
Source: debbugs
Binary: debbugs libdebbugs-perl debbugs-web debbugs-local
Architecture: source all
Version: 2.6.0
Distribution: unstable
Urgency: medium
Maintainer: Debbugs developers <debian-debbugs@lists.debian.org>
Changed-By: Don Armstrong <don@debian.org>
Description:
 debbugs    - bug tracking system based on the active Debian BTS
 debbugs-local - Run and maintains a local mirror of the Debian BTS
 debbugs-web - web scripts for the active Debian BTS
 libdebbugs-perl - modules used by the active Debian BTS
Closes: 49228 208130 412815 485697 539691 546383 584922 593804 609687 656371 662228 665001 670411 670456 670555 670556 670568 672432 686928 686940 686943 688109 688344 688345 688745 690408 691573 703300 717967 719205 721569 728034 762967 766354 767327 782740 785405 790716 798092 800287 820044 836613 856991 858671 861234 864725 871784 881903 890338 892060 892135
Changes:
 debbugs (2.6.0) unstable; urgency=medium
 .
   [ Don Armstrong ]
   * Hack around elinks css bug (closes: #593804)
   * affects now appends packages by default (closes: #656371). Thanks to
     Andreas Beckmann and Julien Cristau.
   * Fix spacing in owner block (closes: #670411)
   * Fix double encoding issues (closes: #672432)
   * Fix encoding in cgi
   * Fix installation of templates (closes: #686928). Thanks to Mike
     Gabriel.
   * Only remove list headers if the message appears to have traversed a
     mailing list to get to us. (closes: #690408)
   * Fix lack of archive support in pkgindex.cgi.
   * Output notice to transcript when there is a malformed command.
     (closes: #691573). Thanks to Jonathan Nieder.
   * Fix failure to forcibly merge/merge when found/fixed is not qualified
     (closes: #670456). Thanks to Jonathan Nieder and Bernhard Schmidt.
   * Add libravatar support.
   * Fix double encoding of attachments (closes: #703300)
   * uri_escape e-mails in libravatar (closes: #728034). Thanks to Fabien
     Givors for pointing this out and providing a patch.
   * Fix title of $gBug (closes: #546383). Thanks to Jakub Wilk.
   * Support CVEs surrounded by parenthesis (closes: #662228). Thanks to
     Ari Pollak.
   * Add reply links to individual bug messages with headers (closes:
     #412815). Thanks to martin krafft, Paul Wise, and Julien Valroff.
   * Fix XSS in version.cgi, thanks to Vlad Constantin (Closes: #762967).
   * Add affects to bugreport.cgi package info header (Closes: #609687).
   * Stop URLs at &quot; too. Thanks to Vincent Lefevre (Closes: #766354).
   * Allow for more complicated selectors in user categories.
   * Support control at submit time. (Closes: #49228).
   * Add the limit command which constrains control@ (Closes: #208130).
   * Depend on libmime-tools-perl instead of libmime-perl. (Closes: #665001).
   * Fix SOAP module hack to work around Date/Time encoding which broke in
     newer versions of SOAP::Lite. (Closes: #785405)
   * Add patch to do singular/plural in error messages from Rafael.
     (Closes: #790716)
   * Fix (and test) setting summary/outlook in Control: messages (Closes:
     #836613).
   * Fix clone removing all other blocks instead of adding them (Closes:
     #820044). Thanks to James Clarke.
   * Use a supported version of debhelper and switch to dh $@ style rules
     (Closes: #800287)
   * debbugs-web now Breaks/Replaces debbugs (<< 2.4.2) (Closes: #717967)
   * Split source file properly (Closes: #858671). Thanks to James McCoy.
   * Prefix 'src:' to all source package names.
   * cdn.libravatar.org no longer sends Content-Type. Switch to verifying
     the content-type using libmagic instead (which we probably should have
     been doing from the beginning anyway). (Closes: #856991)
   * Reply sent messages (-forwarded and -done) are not informational messages.
     (Closes: #864725)
   * Pluralize singular tag and usertag in pseudoheaders (Closes: #861234).
     Thanks to James Clarke
   * Include link to the location of the debbugs source (Closes: #721569).
   * Add envelope_from configuration variable so sites can set a valid return
     path if the sendmail default is wrong. (Closes: #719205)
   * Fix links to merged and blocked bugs. (Closes: #539691)
   * Strip out Mail-Followup-To: (Closes: #798092)
   * Include references from the original message in replies. (Closes: #485697)
     Thanks to Julien Cristau
   * Use pass-through for rewrites of URLs to hide implementation (Closes:
     #871784) Thanks to Ridier 'OdyX' Raboud
   * Use foo <bar@baz.com> instead of bar@baz.com (foo) for From: (Closes:
     #881903). Thanks to Michael Stapelberg.
   * Add rel="canonical" links to bug pages (Closes: #890338). Thanks to Chris
     Lamb.
   * Fix blocks/blockedby of archived bugs (Closes: #892060). Thanks to Laurent Bigonville.
   * Provide informative error message when unarchive fails because the bug is
     not archived. (Closes: #892135). Thanks to Dan Jacobson.
   * Update standards version to 4.1.3; add Testsuite, fix Homepage and git repos
     links, update priority.
 .
   [ Niels Thykier ]
   * quitcgi() now returns 400/500 status codes instead of 200 (Closes: #584922)
 .
   [Thanks to Arnout Engelen: ]
   * Add Homepage (closes: #670555).
   * Fix VCS in control (closes: #670556).
   * Link to blocked bugs (closes: #670568).
 .
   [ Mike Gabriel ]
   * /debian/control:
     + Add ${misc:Depends} to Depends.
   * /examples/apache.conf:
     - Assure in apache.conf example that documentation html pages get loaded
       (closes: #686943).
     - Rewrite rule example: http://<webhost>/<nnn> -> show bug report for
       bug <nnn>.
     - Be more generic, comment out rewrite rule that directly redirects
       http://<debbugs-webhost>/ to http://www.debian.org/Bugs.
     - Extend examples/apache.conf, add directory rules. Esp. allow Indexes to be
       overridden in /var/lib/debbugs/www/db to allow mod_expires apache
       configuration options in .htaccess.
   * Load bugs.css file in documentation html pages.
   * Fix sani function in scripts/errorlib. Generate html entities correctly
     (prepend ampersand, append semicolon).
   * Fix pkgindex.cgi concerning several issues: load proper Perl modules,
     replace usage of src_url and pkg_url by package_links, use
     html_tail from templates, use count_bugs everywhere, load bugs.css,
     fix global variable usage in html header (closes: #686940).
   * Add empty $gBugSubscriptionDomain variable to config file template.
   * Remove mailing list markers of the form [<list-name>] from the subject
     line to avoid duplication (and more) of the bug number when replying to
     bug postings.
   * Update postfix section in Readme.mail (closes: #688109).
   * Provide gStrongList configuration option in config file to make
     a site admin aware of its existence (closes: #688345).
   * Make sure that mails to gSubscriptionDomain and gBugSubscriptionDomain
     are only sent out if the variables in config are defined and
     have a length < 0 (closes: #688344).
   * Use locale independent date format for mail processing and service mail
     generation (closes: #688745).
   * Fix spelling error in /debian/changelog.
   * Fix lintian issue: description-synopsis-starts-with-article.
   * Fix lintian issues: debian-rules-missing-recommended-target build-arch,
     debian-rules-missing-recommended-target build-indep.
   * Switch to debian/source/format: 3.0 (native).
   * Fix lintian issue: debbugs source: duplicate-in-relation-field in
     libdebbugs-perl depends: libtext-template-perl, libtext-template-perl.
   * Fix lintian issues: debbugs source:
     debian-rules-makemaker-prefix-is-deprecated line 44,
     debian-rules-makemaker-prefix-is-deprecated line 56.
   * Fix lintian issues: libdebbugs-perl: spelling-error-in-manpage for:
     + usr/share/man/man3/Debbugs::Recipients.3pm.gz
     + usr/share/man/man3/Debbugs::SOAP.3pm.gz
     + usr/share/man/man3/Debbugs::Status.3pm.gz
   * Raise Standards to 3.9.4 (after fixing several lintian issues).
   * Pass param bug=<NNN> to bugreport.html call in bugreport.cgi.
 .
   [Frank Lichtenheld]
   * Fix broken link in changed forwarded-to address (closes: #782740)
   * Fix package links in reassigned message (closes: #767327)
Checksums-Sha1:
 8c6595d9321b9134fd77b6cdca124c7465e5098c 2362 debbugs_2.6.0.dsc
 5b23a34b6fa006320b1d1bd4ab5a023995701543 250896 debbugs_2.6.0.tar.xz
 2c91b71069a42307bb3eacf536a57ef66d96b775 24000 debbugs-local_2.6.0_all.deb
 9be35213aba640f5633612481e79159ea560d293 58972 debbugs-web_2.6.0_all.deb
 68daca8ecb20c9f56fb81e78b653a4f42b6e4404 74700 debbugs_2.6.0_all.deb
 44d7b4466f04488b8584ae183a77e891dc6a8077 12802 debbugs_2.6.0_amd64.buildinfo
 6fd1b3f1c45c4cef2081cf25dc4e4f3116e42a6a 188976 libdebbugs-perl_2.6.0_all.deb
Checksums-Sha256:
 24bf44d2440c2fe88a5cc8dae844a5b66ca4000c22d3187e0dca908d0e51a957 2362 debbugs_2.6.0.dsc
 df919d53d80dab04a58a0937f06cee20f6321e74ea944c9ac24746a02181b419 250896 debbugs_2.6.0.tar.xz
 18e8022ffb63c90ed3532b0c55b46c815c62ea26af885101214687e173bed056 24000 debbugs-local_2.6.0_all.deb
 b7a8dae7e103875916b57178fbdc2fff2b1969610ba6001732b996fb2133d552 58972 debbugs-web_2.6.0_all.deb
 b4f37c392508c0e5cd0ef912668b65c5dafad4f3d616e8b04f3cfa86a4776902 74700 debbugs_2.6.0_all.deb
 1a991ba758d5b82e3f7b2db980c5a16f2fd5de340159be33885340f372060be4 12802 debbugs_2.6.0_amd64.buildinfo
 9e1fd168e6e7a5a1494f24ceeb6db8a1ffebb23dba13c9b24a268dca3519b421 188976 libdebbugs-perl_2.6.0_all.deb
Files:
 e18937f80ff2065a40dd33e35af98f87 2362 misc optional debbugs_2.6.0.dsc
 85b97cc9602fb3be1b69486d2f883754 250896 misc optional debbugs_2.6.0.tar.xz
 e72c960d50cf4a77efe3bca5d6d0f65e 24000 misc optional debbugs-local_2.6.0_all.deb
 595d92ccd83e0bc816465adbb6df5d9a 58972 misc optional debbugs-web_2.6.0_all.deb
 ed5d971e75245c85d2409a99edf8dd88 74700 misc optional debbugs_2.6.0_all.deb
 53bd0fd82e1f6d8bc50f964c8ef6630c 12802 misc optional debbugs_2.6.0_amd64.buildinfo
 5306a50c52ac3c1de4f0d1c67ee0c820 188976 perl optional libdebbugs-perl_2.6.0_all.deb

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEN5QgYeBoIEyihVyW9VAlZYpmvz8FAlqh0lEACgkQ9VAlZYpm
vz9cZw//QY2wiZNGEi2XIa/7pKnPCm5CY4AZiL2DxixxhZz+h/Hb4kRDbntQDDZY
q2KBiMi2YnmdTzAPS9Rla5JASQcZnasGK8eRow9ne17TLUq8JuZ40OeMQIo9hgzg
3iXJIf5d08sB/uFR/V3xNM9Z5kHe9in4Wd+ndgOmk4eeQd8ot2qz/zBz4Rhm4Anj
Mw/+o+Kmjl5S5VUeelVn+Aw7vNfywmoJhj991qVjYS5jEcTzlrAwzM0O3qHQFjxX
QNLFDOfBoC+p1p1/zvqXwIpJxgoKrlj9y6SPZtnAVqb8k8DkvMj51SDHUiBCm9Qn
GMuPXR6PMRHzQVZs0U17MKBtI7pelyRmanWqcx4oNtgodZ6FHpxjvetECINNyfsq
9QEgtetZBZqkXbm5+z5Anc9L2KgGvvXFcfS7K3DKaENP85ohPAz+LLHyQI5NYhXm
bOYsUOczf3KouXjxkfSZlnhYVGLCiZlE0Ci3/nNl2b+oUxkEOnloOPrmozOuyrxg
LD7j167MSDwbiWBQiTnTMEra3iK4jvPDsHThEnf0WfkQJyFSj5Ha/j96RQE0/ZsW
gwQWQE1NfTkEmjuBHsRHbL5C7nZ40cL7jE+OKos0SClnkT/blIJ8eCRfTCgwVWxN
Gvj2mnTJQptsqoqepV5DsfO+36yvnYmDTi5eNjF7cq6tiCZRaOk=
=9DNq
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: