[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#139697: Wrong generated urls - domain added twice



On Sun, Mar 24, 2002 at 10:51:42AM +0100, Kamil Politowicz wrote:
> Package: debbugs
> Version: 2.3-4
> 
> I came to this problem, when trying to open a bug page from a list of bugs
> found for the project.
> 
> The solution was to correct all *url subs (e.g. sub pkgurl) in Common.pl CGI
> script in the following way:
> 
> #was#    return urlsanit($debbugs::gCGIDomain . "pkgreport.cgi" . "?" .
> "$params");
> #is #    return urlsanit("pkgreport.cgi" . "?" . "$params");

This has been applied in CVS for other reasons, but more generally I'm
concerned about the $gCGIDomain mess. config.debian includes the leading
"http://";, and the code requires that, while config.in doesn't.

I think it would be more consistent with the other $g*Domain variables
to leave off the leading "http://";, and make the code add that in. Any
objections?

-- 
Colin Watson                                  [cjwatson@flatline.org.uk]



Reply to: