[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[Git][ftp-team/dak][master] control_suite.py: do not use integer as a version number



Title: GitLab

Ansgar pushed to branch master at Debian FTP Team / dak

Commits:

  • 29a16ef0
    by Ansgar at 2022-09-18T18:52:07+02:00
    control_suite.py: do not use integer as a version number
    
    There is no comparison operator between `debversion` and integers on
    the Postgres side.
    
    Also do not assume that "0" is the lowest version number as people are
    too creative for that to be true.
    

1 changed file:

Changes:

  • dak/control_suite.py
    ... ... @@ -128,12 +128,12 @@ def britney_changelog(packages, suite, session):
    128 128
                 if apt_pkg.version_compare(current[p], old[p]) > 0:
    
    129 129
                     new[p] = [current[p], old[p]]
    
    130 130
             else:
    
    131
    -            new[p] = [current[p], 0]
    
    131
    +            new[p] = [current[p], None]
    
    132 132
     
    
    133 133
         params = {}
    
    134 134
         query = "SELECT source, changelog FROM changelogs WHERE"
    
    135 135
         for n, p in enumerate(new.keys()):
    
    136
    -        query += f" source = :source_{n} AND version > :version1_{n} AND version <= :version2_{n}"
    
    136
    +        query += f" source = :source_{n} AND (:version1_{n} IS NULL OR version > :version1_{n}) AND version <= :version2_{n}"
    
    137 137
             query += " AND architecture LIKE '%source%' AND distribution in \
    
    138 138
                       ('unstable', 'experimental', 'testing-proposed-updates') OR"
    
    139 139
             params[f'source_{n}'] = p
    


  • Reply to: