[Git][ftp-team/dak][master] manage-build-queues: only update `last_changed` when something changed

[Ansgar <ansgar@debian.org>]

Title: GitLab

Ansgar pushed to branch master at Debian FTP Team / dak

Commits:

• 9d2cd388
  by 😸 at 2020-09-18T08:47:01+02:00

  manage-build-queues: only update `last_changed` when something changed
  
  The condition was always true as `binaries` and `sources` are query
  objects and not lists.  We only want to update `last_changed` when
  either query actually returned something.
  

1 changed file:

• dak/manage_build_queues.py

Changes:

dak/manage_build_queues.py

---

...	...	@@ -65,6 +65,7 @@ def clean(build_queue, transaction, now=None):
65	65
66	66	delete_before = now - timedelta(seconds=build_queue.stay_of_execution)
67	67	suite = build_queue.suite
	68	+ suite_was_changed = False
68	69
69	70	# Remove binaries subject to the following conditions:
70	71	# 1. Keep binaries that are in policy queues.
...	...	@@ -93,6 +94,7 @@ def clean(build_queue, transaction, now=None):
93	94	for binary in binaries:
94	95	Logger.log(["removed binary from build queue", build_queue.queue_name, binary.package, binary.version])
95	96	transaction.remove_binary(binary, suite)
	97	+ suite_was_changed = True
96	98
97	99	# Remove sources
98	100	# Conditions are similar as for binaries, but we also keep sources
...	...	@@ -125,8 +127,9 @@ def clean(build_queue, transaction, now=None):
125	127	for source in sources:
126	128	Logger.log(["removed source from build queue", build_queue.queue_name, source.source, source.version])
127	129	transaction.remove_source(source, suite)
	130	+ suite_was_changed = True
128	131
129		- if binaries or sources:
	132	+ if suite_was_changed:
130	133	suite.update_last_changed()
131	134
132	135

—
View it on GitLab.
You're receiving this email because of your account on salsa.debian.org. If you'd like to receive fewer emails, you can adjust your notification settings.