[Git][ftp-team/dak][master] 2 commits: process-upload: catch InvalidChangesException

[Joerg Jaspert <joerg@debian.org>]

Title: GitLab

Joerg Jaspert pushed to branch master at Debian FTP Team / dak

Commits:

• 5d4721ff
  by Emilio Pozuelo Monfort at 2018-10-23T18:34:53Z

  process-upload: catch InvalidChangesException
  
  Creating a Changes object doesn't parse it immediately, so we
  were not catching InvalidChangesException here. Force the
  parsing so we can detect invalid changes and stop processing
  them, otherwise process-upload explodes and no further changes
  are processed after the broken one.
  

• 360853bd
  by Joerg Jaspert at 2018-10-23T18:35:36Z

  Merge branch 'invalid-changes' into 'master'
  
  process-upload: catch InvalidChangesException
  
  See merge request ftp-team/dak!94

1 changed file:

• dak/process_upload.py

Changes:

dak/process_upload.py

---

...	...	@@ -498,6 +498,9 @@ def process_changes(changes_filenames):
498	498	try:
499	499	directory, filename = os.path.split(fn)
500	500	c = daklib.upload.Changes(directory, filename, keyring_files)
	501	+ # Force parsing the .changes so we can catch InvalidChangesException now
	502	+ #pylint: disable=pointless-statement
	503	+ c.byhand_files
501	504	changes.append([directory, c])
502	505	except Exception as e:
503	506	Logger.log([filename, "Error while loading changes: {0}".format(e)])

—
View it on GitLab.
You're receiving this email because of your account on salsa.debian.org. If you'd like to receive fewer emails, you can adjust your notification settings.