[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[dak/master] debianqueued: use `POSIX::mkfifo` instead of external program



---
 tools/debianqueued-0.9/config-backports           | 1 -
 tools/debianqueued-0.9/config-security            | 1 -
 tools/debianqueued-0.9/config-security-disembargo | 1 -
 tools/debianqueued-0.9/config-security-embargoed  | 1 -
 tools/debianqueued-0.9/config-upload              | 1 -
 tools/debianqueued-0.9/config-usper               | 1 -
 tools/debianqueued-0.9/debianqueued               | 7 +++----
 7 files changed, 3 insertions(+), 10 deletions(-)

diff --git a/tools/debianqueued-0.9/config-backports b/tools/debianqueued-0.9/config-backports
index c95dc25..08f1b2d 100644
--- a/tools/debianqueued-0.9/config-backports
+++ b/tools/debianqueued-0.9/config-backports
@@ -13,7 +13,6 @@ $scp       = "/usr/bin/scp";
 $ssh_agent = "/usr/bin/ssh-agent";
 $ssh_add   = "/usr/bin/ssh-add";
 $mail      = "/usr/sbin/sendmail";
-$mkfifo    = "/usr/bin/mkfifo";
 $gzip      = "/bin/gzip";
 $cp        = "/bin/cp";
 
diff --git a/tools/debianqueued-0.9/config-security b/tools/debianqueued-0.9/config-security
index 2cf670f..9fb2ac8 100644
--- a/tools/debianqueued-0.9/config-security
+++ b/tools/debianqueued-0.9/config-security
@@ -13,7 +13,6 @@ $scp       = "/usr/bin/scp";
 $ssh_agent = "/usr/bin/ssh-agent";
 $ssh_add   = "/usr/bin/ssh-add";
 $mail      = "/usr/sbin/sendmail";
-$mkfifo    = "/usr/bin/mkfifo";
 $gzip      = "/bin/gzip";
 $cp        = "/bin/cp";
 
diff --git a/tools/debianqueued-0.9/config-security-disembargo b/tools/debianqueued-0.9/config-security-disembargo
index 3b794f2..9690e4a 100644
--- a/tools/debianqueued-0.9/config-security-disembargo
+++ b/tools/debianqueued-0.9/config-security-disembargo
@@ -13,7 +13,6 @@ $scp       = "/usr/bin/scp";
 $ssh_agent = "/usr/bin/ssh-agent";
 $ssh_add   = "/usr/bin/ssh-add";
 $mail      = "/usr/sbin/sendmail";
-$mkfifo    = "/usr/bin/mkfifo";
 $gzip      = "/bin/gzip";
 $cp        = "/bin/cp";
 
diff --git a/tools/debianqueued-0.9/config-security-embargoed b/tools/debianqueued-0.9/config-security-embargoed
index 07b0dba..8fbe6a9 100644
--- a/tools/debianqueued-0.9/config-security-embargoed
+++ b/tools/debianqueued-0.9/config-security-embargoed
@@ -13,7 +13,6 @@ $scp       = "/usr/bin/scp";
 $ssh_agent = "/usr/bin/ssh-agent";
 $ssh_add   = "/usr/bin/ssh-add";
 $mail      = "/usr/sbin/sendmail";
-$mkfifo    = "/usr/bin/mkfifo";
 $gzip      = "/bin/gzip";
 $cp        = "/bin/cp";
 
diff --git a/tools/debianqueued-0.9/config-upload b/tools/debianqueued-0.9/config-upload
index edfba7b..2b06bb5 100644
--- a/tools/debianqueued-0.9/config-upload
+++ b/tools/debianqueued-0.9/config-upload
@@ -13,7 +13,6 @@ $scp       = "/usr/bin/scp";
 $ssh_agent = "/usr/bin/ssh-agent";
 $ssh_add   = "/usr/bin/ssh-add";
 $mail      = "/usr/sbin/sendmail";
-$mkfifo    = "/usr/bin/mkfifo";
 $gzip      = "/bin/gzip";
 $cp        = "/bin/cp";
 
diff --git a/tools/debianqueued-0.9/config-usper b/tools/debianqueued-0.9/config-usper
index 839c307..7a7b1cc 100644
--- a/tools/debianqueued-0.9/config-usper
+++ b/tools/debianqueued-0.9/config-usper
@@ -13,7 +13,6 @@ $scp       = "/usr/bin/scp";
 $ssh_agent = "/usr/bin/ssh-agent";
 $ssh_add   = "/usr/bin/ssh-add";
 $mail      = "/usr/sbin/sendmail";
-$mkfifo    = "/usr/bin/mkfifo";
 $gzip      = "/bin/gzip";
 $cp        = "/bin/cp";
 
diff --git a/tools/debianqueued-0.9/debianqueued b/tools/debianqueued-0.9/debianqueued
index e398471..387048b 100755
--- a/tools/debianqueued-0.9/debianqueued
+++ b/tools/debianqueued-0.9/debianqueued
@@ -179,7 +179,7 @@ do {
 # check if all programs exist
 my $prg;
 foreach $prg ( $conf::gpg, $conf::ssh, $conf::scp, $conf::ssh_agent,
-               $conf::ssh_add, $conf::mail, $conf::mkfifo )
+               $conf::ssh_add, $conf::mail )
 {
   die "Required program $prg doesn't exist or isn't executable\n"
     if !-x $prg;
@@ -1737,9 +1737,8 @@ sub fork_statusd() {
   $SIG{"CHLD"} = "DEFAULT";
 
   rm($conf::statusfile);
-  $errs = `$conf::mkfifo $conf::statusfile`;
-  die "$main::progname: cannot create named pipe $conf::statusfile: $errs"
-    if $?;
+  POSIX::mkfifo($conf::statusfile, 0644)
+    or die "Cannot create named pipe $conf::statusfile: $!\n";
   chmod( 0644, $conf::statusfile )
     or die "Cannot set modes of $conf::statusfile: $!\n";
 
-- 
2.1.4



Reply to: