[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[PATCH 1/2] dep11: Don't check for quoted strings



Hi!
This removes some validation hints we actually can't do anything about
because they are issues in upstream's code and need to be fixed by
packaged software.
So showing this in dak is pretty pointless, and also no fundamental error.

This patch gets rid of the noise.

>From ff1a1b98b3cf1653f1e9e143e19754dab94b0d51 Mon Sep 17 00:00:00 2001
From: Matthias Klumpp <matthias@tenstral.net>
Date: Tue, 20 Jun 2017 22:01:20 +0200
Subject: [PATCH 1/2] dep11: Don't check for quoted strings

---
 scripts/debian/dep11-basic-validate.py | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/scripts/debian/dep11-basic-validate.py
b/scripts/debian/dep11-basic-validate.py
index 6ee3042b1..6f338e1d2 100755
--- a/scripts/debian/dep11-basic-validate.py
+++ b/scripts/debian/dep11-basic-validate.py
@@ -55,9 +55,6 @@ def test_custom_objects(lines):
             ret = False
     return ret

-def is_quoted(s):
-        return (s.startswith("\"") and s.endswith("\"")) or
(s.startswith("\'") and s.endswith("\'"))
-
 def test_localized_dict(doc, ldict, id_string):
     ret = True
     for lang, value in ldict.items():
@@ -67,8 +64,6 @@ def test_localized_dict(doc, ldict, id_string):
             add_issue("[%s][%s]: %s" % (doc['ID'], id_string, "Found
cruft locale: xx"))
         if lang.endswith('.UTF-8'):
             add_issue("[%s][%s]: %s" % (doc['ID'], id_string,
"AppStream locale names should not specify encoding (ends with
.UTF-8)"))
-        if is_quoted(value):
-            add_issue("[%s][%s]: %s" % (doc['ID'], id_string, "String
is quoted: '%s' @ %s" % (value, lang)))
         if " " in lang:
             add_issue("[%s][%s]: %s" % (doc['ID'], id_string, "Locale
name contains space: '%s'" % (lang)))
             # this - as opposed to the other issues - is an error
-- 
2.11.0
From ff1a1b98b3cf1653f1e9e143e19754dab94b0d51 Mon Sep 17 00:00:00 2001
From: Matthias Klumpp <matthias@tenstral.net>
Date: Tue, 20 Jun 2017 22:01:20 +0200
Subject: [PATCH 1/2] dep11: Don't check for quoted strings

---
 scripts/debian/dep11-basic-validate.py | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/scripts/debian/dep11-basic-validate.py b/scripts/debian/dep11-basic-validate.py
index 6ee3042b1..6f338e1d2 100755
--- a/scripts/debian/dep11-basic-validate.py
+++ b/scripts/debian/dep11-basic-validate.py
@@ -55,9 +55,6 @@ def test_custom_objects(lines):
             ret = False
     return ret
 
-def is_quoted(s):
-        return (s.startswith("\"") and s.endswith("\"")) or (s.startswith("\'") and s.endswith("\'"))
-
 def test_localized_dict(doc, ldict, id_string):
     ret = True
     for lang, value in ldict.items():
@@ -67,8 +64,6 @@ def test_localized_dict(doc, ldict, id_string):
             add_issue("[%s][%s]: %s" % (doc['ID'], id_string, "Found cruft locale: xx"))
         if lang.endswith('.UTF-8'):
             add_issue("[%s][%s]: %s" % (doc['ID'], id_string, "AppStream locale names should not specify encoding (ends with .UTF-8)"))
-        if is_quoted(value):
-            add_issue("[%s][%s]: %s" % (doc['ID'], id_string, "String is quoted: '%s' @ %s" % (value, lang)))
         if " " in lang:
             add_issue("[%s][%s]: %s" % (doc['ID'], id_string, "Locale name contains space: '%s'" % (lang)))
             # this - as opposed to the other issues - is an error
-- 
2.11.0


Reply to: