[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[dak/master] daklib/checks.py: include all not allowed binary architectures in error.



---
 daklib/checks.py |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/daklib/checks.py b/daklib/checks.py
index 81bd629..fcb5a32 100644
--- a/daklib/checks.py
+++ b/daklib/checks.py
@@ -389,9 +389,9 @@ class ACLCheck(Check):
                 uploaded_arches = set(upload.changes.architectures)
                 uploaded_arches.discard('source')
                 allowed_arches = set(a.arch_string for a in acl.architectures)
-                for a in uploaded_arches:
-                    if a not in allowed_arches:
-                        return False, "uploads for architecture {0} are not allowed".format(a)
+                forbidden_arches = uploaded_arches - allowed_arches
+                if len(forbidden_arches) != 0:
+                    return False, "uploads for architecture(s) {0} are not allowed".format(", ".join(forbidden_arches))
         if not acl.allow_hijack:
             for suite in upload.final_suites:
                 does_hijack, hijacked_binary, hijacked_from = self._does_hijack(session, upload, suite)
-- 
1.7.2.5



Reply to: