Re: [PATCH] Handle non-critical SIG_SUBPACKET per RFC4880

[Torsten Werner <twerner@debian.org>]

Hi,

I've looked again at your patch but it seems to be incorrect.

Am 21.04.2010 05:42, schrieb Jeremy T. Bouse:
>> diff --git a/daklib/utils.py b/daklib/utils.py
>> index 0896d57..fb6b8b0 100755
>> --- a/daklib/utils.py
>> +++ b/daklib/utils.py
>> @@ -1205,6 +1205,8 @@ def process_gpgv_output(status):
>>          if keywords.has_key(keyword) and keyword not in [ "NODATA", "SIGEXPIRED", "KEYEXPIRED" ]:
>>              internal_error += "found duplicate status token ('%s').\n" % (keyword)
>>              continue
>> +        if keyword in [ "SIG_SUBPACKET" ] and args[1] != 2:
>> +            continue
>>          else:
>>              keywords[keyword] = args

The else was formerly connected to the
    if keywords.has_key(keyword)...
but now it is connected to
    if keyword in [ "SIG_SUBPACKET" ]...
That looks wrong.

BTW, shouldn't you add something to internal_error
    if keyword in [ "SIG_SUBPACKET" ] and args[1] == 2
?

Torsten