[dak/master] Rewrite so that it uses mktemp. also let a trap for the cleanup function handle the rm of the tempfile, we save on the whole if then
Signed-off-by: Joerg Jaspert <joerg@debian.org>
---
config/debian/cron.daily | 17 ++++++++++-------
1 files changed, 10 insertions(+), 7 deletions(-)
diff --git a/config/debian/cron.daily b/config/debian/cron.daily
index 1815260..16d9d9d 100755
--- a/config/debian/cron.daily
+++ b/config/debian/cron.daily
@@ -9,14 +9,17 @@ export SCRIPTVARS=/srv/ftp-master.debian.org/dak/config/debian/vars
################################################################################
+TMPFILE=$( mktemp -p ${TMPDIR} )
+
+function cleanup {
+ ERRVAL=$?
+ rm -f ${TMPFILE}
+ exit ${ERRVAL}
+}
+trap cleanup SIGHUP SIGINT SIGPIPE SIGTERM EXIT ERR
# get the latest list of wnpp bugs and their source packages
-if $( wget -q -O/srv/ftp-master.debian.org/scripts/masterfiles/wnpp_rm.tmp http://qa.debian.org/data/bts/wnpp_rm ) ; then
- mv /srv/ftp-master.debian.org/scripts/masterfiles/wnpp_rm.tmp /srv/ftp-master.debian.org/scripts/masterfiles/wnpp_rm
-else
- if [ -f /srv/ftp-master.debian.org/scripts/masterfiles/wnpp_rm.tmp ] ; then
- rm /srv/ftp-master.debian.org/scripts/masterfiles/wnpp_rm.tmp
- fi
-fi
+wget -q -O${TMPFILE} http://qa.debian.org/data/bts/wnpp_rm
+mv ${TMPFILE} /srv/ftp-master.debian.org/scripts/masterfiles/wnpp_rm
################################################################################
--
1.5.6.5
Reply to: