Re: On colourizing RC bug fixes with different colours
> In <87aan8rzo0.fsf@gkar.ganneff.de>, you had said that you wanted to
> "highlight packages in NEW fixing rc bugs". I thought I could take a
> stab at that.
Great, thanks.
(Im moving this to debian-dak@lists.d.o so more people can have a look
at it.)
> Frankly, I have zero experience with Dak code, but I came up with a
> rudimentary hack, for which patch is attached. Now, I am 100% sure
> that you would want more checks to be in place, but I wanted some
> feedback and advice from you, so that I could put the code in the
> right place and send you a good patch the second time.
> The code is "tested" only as individual functions; I don't know how to
> test out the dak code myself (could you point me to the right place,
> please?).
> Please let me know if this helps.
Well, you need a dak instance to really test stuff, and in case of
queue-report also access to the queues.
Should you dive more into coding for dak we can arrange something, but for a
one-off contribution its a bit much work... :)
> This commit adds some functions to query the BTS Soap interface to
> determine if the package closes an RC bug or not. If it does close an
> RC bug, it allows for differently colourizing the package line.
> --- a/dak/queue_report.py
> +++ b/dak/queue_report.py
> @@ -43,6 +43,7 @@ from daklib.queue import Upload
> from daklib.dbconn import DBConn, has_new_comment, DBChange, DBSource, get_uid_from_fingerprint
> from daklib.textutils import fix_maintainer
> from daklib.dak_exceptions import *
> +import SOAPpy
At another place we already use python-debianbts. (rm and
bts-categorize). Unless there is a good reason against it I would want
to keep the number of additional libraries small, so could you look if
you can use that too?
Besides this it does look good, except: Whats it doing when the BTS is
unreachable? We dont like exceptions in that case and should probably
just continue (and dont have rc foo hilighted).
Also, you do this in the html output only. How about fetching this data
earlier in the data gathering state, so its just an entry in the entries
dict and we could also output it on the normal report (like, having an
extra flag for the text report).
--
bye, Joerg
It's not easy to juggle a pregnant wife and a troubled child, but
somehow I managed to fit in eight hours of TV a day.
Reply to: