[dak/master 14/23] Update comment about our monkeypatching of commands.getstatusoutput.
Signed-off-by: Chris Lamb <lamby@debian.org>
---
daklib/utils.py | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/daklib/utils.py b/daklib/utils.py
index 0c628fb..50a0682 100755
--- a/daklib/utils.py
+++ b/daklib/utils.py
@@ -62,8 +62,9 @@ key_uid_email_cache = {} #: Cache for email addresses from gpg key uids
known_hashes = [("sha1", apt_pkg.sha1sum, (1, 8)),
("sha256", apt_pkg.sha256sum, (1, 8))] #: hashes we accept for entries in .changes/.dsc
-# Monkeypatch commands.getstatusoutput as it returns a "0" exit code in
-# all situations under lenny's Python.
+# Monkeypatch commands.getstatusoutput as it may not return the correct exit
+# code in lenny's Python. This also affects commands.getoutput and
+# commands.getstatus.
def dak_getstatusoutput(cmd):
pipe = subprocess.Popen(cmd, shell=True, universal_newlines=True,
stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
--
1.6.3.3
Reply to: