[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH] [db] Rename "version" to "source_version" when it refers to source packages



* Roger Leigh [Thu, 05 Mar 2009 23:32:14 +0000]:

> On Mon, Mar 02, 2009 at 08:01:01PM +0100, Adeodato Simó wrote:
> > I've recently started using a DB with a schema very similar to
> > wanna-build's for my own purposes. Queries felt very natural, except
> > when wanting to cross binary packages with their source packages.

> > When joining such tables, the "JOIN ... ON b.source = s.source AND
> > b.source_version = s.version" had to be used, as opposed to "JOIN ...
> > USING(source, source_version)".

> > I'd appreciate if this change could be applied, if nobody has reasoned
> > objections to it.

> Applied, thanks.

Great, thanks.

> For consistency, would it be better to make this change for binaries
> as well, so we have binary_version to complement source_version?

I think it's reasonable to at least keep "version", which is short and
concise, useful for at least one of the two cases. Or maybe is that I'm
used to writing (package, version, arch) in all of my queries, and don't
want to change that. ;-)

But I think the first argument is a good one, really. Let's hear if
other people have comments?

Cheers,

-- 
Adeodato Simó                                     dato at net.com.org.es
Debian Developer                                  adeodato at debian.org
 
Faced with the choice between changing one's mind and proving that there
is no need to do so, almost everyone gets busy with the proof.
                -- J.K. Galbraith


Reply to: