[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

ftpmaster-dak r1074: Merge Thomas branch to change NEWs layout



------------------------------------------------------------
revno: 1074
committer: Joerg Jaspert <joerg@debian.org>
branch nick: upstream
timestamp: Sat 2008-05-03 16:07:49 +0200
message:
  Merge Thomas branch to change NEWs layout
added:
  web/
  web/style.css
modified:
  ChangeLog
  dak/examine_package.py
  dak/show_new.py
    ------------------------------------------------------------
    revno: 1055.1.1
    committer: Thomas Viehmann <tv@beamnet.de>
    branch nick: nicer-new
    timestamp: Sat 2008-04-26 11:03:31 +0000
    message:
      started nicer NEW .html pages
    modified:
      dak/examine_package.py
      dak/show_new.py
    ------------------------------------------------------------
    revno: 1055.1.2
    committer: Thomas Viehmann <tv@beamnet.de>
    branch nick: nicer-new
    timestamp: Mon 2008-04-28 22:45:03 +0000
    message:
      finish exterior css'ing
    modified:
      dak/examine_package.py
    ------------------------------------------------------------
    revno: 1055.1.3
    committer: Thomas Viehmann <tv@beamnet.de>
    branch nick: nicer-new
    timestamp: Mon 2008-04-28 23:22:27 +0000
    message:
      remove checksums- from .dsc display
    modified:
      dak/examine_package.py
    ------------------------------------------------------------
    revno: 1055.1.4
    committer: Thomas Viehmann <tv@beamnet.de>
    branch nick: nicer-new
    timestamp: Sat 2008-05-03 10:18:26 +0000
    message:
      show-new/examine-package: html updates, ordering, and html formatting fixes
    modified:
      dak/examine_package.py
      dak/show_new.py
    ------------------------------------------------------------
    revno: 1055.1.5
    committer: Thomas Viehmann <tv@beamnet.de>
    branch nick: nicer-new
    timestamp: Sat 2008-05-03 10:25:00 +0000
    message:
      merge ftpmaster branch
    added:
      scripts/debian/import_testing.sh
    modified:
      ChangeLog
      config/debian-security/apt.conf
      config/debian-security/cron.buildd
      config/debian-security/cron.daily*
      config/debian-security/dak.conf
      config/debian/cron.buildd
      config/debian/cron.daily
      config/debian/cron.weekly
      config/debian/dak.conf
      config/debian/extensions.py
      config/debian/pseudo-packages.description
      config/debian/pseudo-packages.maintainers
      config/debian/vars
      dak/check_archive.py*
      dak/check_overrides.py*
      dak/check_proposed_updates.py*
      dak/clean_proposed_updates.py*
      dak/clean_queues.py*
      dak/clean_suites.py*
      dak/compare_suites.py*
      dak/control_overrides.py*
      dak/control_suite.py*
      dak/cruft_report.py*
      dak/dak.py*
      dak/decode_dot_dak.py*
      dak/examine_package.py*
      dak/find_null_maintainers.py*
      dak/generate_index_diffs.py*
      dak/generate_releases.py*
      dak/import_archive.py*
      dak/import_keyring.py*
      dak/import_ldap_fingerprints.py*
      dak/import_users_from_passwd.py*
      dak/init_db.py*
      dak/init_dirs.py*
      dak/ls.py*
      dak/make_maintainers.py*
      dak/make_overrides.py*
      dak/make_suite_file_list.py*
      dak/mirror_split.py*
      dak/new_security_install.py*
      dak/override.py*
      dak/poolize.py*
      dak/process_accepted.py*
      dak/process_new.py*
      dak/process_unchecked.py*
      dak/queue_report.py*
      dak/reject_proposed_updates.py*
      dak/rm.py*
      dak/security_install.py*
      dak/show_new.py*
      dak/split_done.py*
      dak/stats.py*
      dak/symlink_dists.py*
      dak/test/001/test.py*
      dak/test/002/test.py*
      dak/transitions.py*
      daklib/extensions.py
      daklib/logging.py
      daklib/queue.py*
      daklib/utils.py*
      scripts/debian/insert_missing_changedby.py*
      setup/init_pool.sql
    ------------------------------------------------------------
    revno: 1055.1.6
    committer: Thomas Viehmann <tv@beamnet.de>
    branch nick: nicer-new
    timestamp: Sat 2008-05-03 10:28:42 +0000
    message:
      changelog for nicer-new fixes
    modified:
      ChangeLog
    ------------------------------------------------------------
    revno: 1055.1.7
    committer: Thomas Viehmann <tv@beamnet.de>
    branch nick: nicer-new
    timestamp: Sat 2008-05-03 13:28:13 +0000
    message:
      add web/,web/style.css
    added:
      web/
      web/style.css
    modified:
      ChangeLog
    ------------------------------------------------------------
    revno: 1055.1.8
    committer: Thomas Viehmann <tv@beamnet.de>
    branch nick: nicer-new
    timestamp: Sat 2008-05-03 14:01:40 +0000
    message:
      add CSS for show_new
    modified:
      dak/show_new.py
      web/style.css
=== modified file 'ChangeLog'
--- a/ChangeLog	2008-05-03 11:35:35 +0000
+++ b/ChangeLog	2008-05-03 14:07:49 +0000
@@ -8,6 +8,13 @@
 
 2008-05-03  Thomas Viehmann  <tv@beamnet.de>
 
+	* web/,web/style.css: add web dir and current style.css
+
+	* dak/examine_package.py, dak/show_new.py: improve NEW html pages,
+	remove Checksums-* from examine-package output
+
+2008-05-03  Thomas Viehmann  <tv@beamnet.de>
+
 	* dak/process_unchecked.py (check_hashes): Reject on error while
 	parsing Checksums-*.
 

=== modified file 'dak/examine_package.py'
--- a/dak/examine_package.py	2008-05-02 15:21:35 +0000
+++ b/dak/examine_package.py	2008-05-03 10:25:00 +0000
@@ -93,13 +93,18 @@
 
 def escape_if_needed(s):
     if use_html:
-        return re_html_escaping.sub(html_escaping.get, s)
+        return re_html_escaping.sub(lambda x: html_escaping.get(x.group(0)), s)
     else:
         return s
 
-def headline(s, level=2):
+def headline(s, level=2, bodyelement=None):
     if use_html:
-        print "<h%d>%s</h%d>" % (level, html_escape(s), level)
+        if bodyelement:
+            print """<thead>
+                <tr><th colspan="2" class="title" onclick="toggle('%(bodyelement)s', 'table-row-group', 'table-row-group')">%(title)s</th></tr>
+              </thead>"""%{"bodyelement":bodyelement,"title":html_escape(s)}
+        else:
+            print "<h%d>%s</h%d>" % (level, html_escape(s), level)
     else:
         print "---- %s ----" % (s)
 
@@ -128,17 +133,48 @@
     else:
         return ("%s%s%s" % (ansi_colours[colour], s, ansi_colours['end']))
 
-def print_escaped_text(s):
-    if use_html:
-        print "<pre>%s</pre>" % (s)
-    else:
-        print s
-
-def print_formatted_text(s):
-    if use_html:
-        print "<pre>%s</pre>" % (html_escape(s))
-    else:
-        print s
+def escaped_text(s, strip=False):
+    if use_html:
+        if strip:
+            s = s.strip()
+        return "<pre>%s</pre>" % (s)
+    else:
+        return s
+
+def formatted_text(s, strip=False):
+    if use_html:
+        if strip:
+            s = s.strip()
+        return "<pre>%s</pre>" % (html_escape(s))
+    else:
+        return s
+
+def output_row(s):
+    if use_html:
+        return """<tr><td>"""+s+"""</td></tr>"""
+    else:
+        return s
+
+def format_field(k,v):
+    if use_html:
+        return """<tr><td class="key">%s:</td><td class="val">%s</td></tr>"""%(k,v)
+    else:
+        return "%s: %s"%(k,v)
+
+def foldable_output(title, elementnameprefix, content, norow=False):
+    d = {'elementnameprefix':elementnameprefix}
+    if use_html:
+        print """<div id="%(elementnameprefix)s-wrap"><a name="%(elementnameprefix)s" />
+                   <table class="infobox rfc822">"""%d
+    headline(title, bodyelement="%(elementnameprefix)s-body"%d)
+    if use_html:
+        print """    <tbody id="%(elementnameprefix)s-body" class="infobody">"""%d
+    if norow:
+        print content
+    else:
+        print output_row(content)
+    if use_html:
+        print """</tbody></table></div>"""
 
 ################################################################################
 
@@ -194,9 +230,9 @@
         extracts = apt_inst.debExtractControl(deb_file)
         control = apt_pkg.ParseSection(extracts)
     except:
-        print_formatted_text("can't parse control info")
-        # TV-COMMENT: this will raise exceptions in two lines
-        control = ''
+        print formatted_text("can't parse control info")
+        deb_file.close()
+        raise
 
     deb_file.close()
 
@@ -240,32 +276,40 @@
 
     return (control, control_keys, section, depends, recommends, arch, maintainer)
 
-def read_dsc (dsc_filename):
+def read_changes_or_dsc (filename):
     dsc = {}
 
-    dsc_file = daklib.utils.open_file(dsc_filename)
+    dsc_file = daklib.utils.open_file(filename)
     try:
-        dsc = daklib.utils.parse_changes(dsc_filename)
+        dsc = daklib.utils.parse_changes(filename)
     except:
-        print_formatted_text("can't parse control info")
+        return formatted_text("can't parse .dsc control info")
     dsc_file.close()
 
-    filecontents = escape_if_needed(strip_pgp_signature(dsc_filename))
-
-    if dsc.has_key("build-depends"):
-        builddep = split_depends(dsc["build-depends"])
-        builddepstr = create_depends_string(builddep)
-        filecontents = re_builddep.sub("Build-Depends: "+builddepstr, filecontents)
-
-    if dsc.has_key("build-depends-indep"):
-        builddepindstr = create_depends_string(split_depends(dsc["build-depends-indep"]))
-        filecontents = re_builddepind.sub("Build-Depends-Indep: "+builddepindstr, filecontents)
-
-    if dsc.has_key("architecture") :
-        if (dsc["architecture"] != "any"):
-            newarch = colour_output(dsc["architecture"], 'arch')
-            filecontents = re_arch.sub("Architecture: " + newarch, filecontents)
-
+    filecontents = strip_pgp_signature(filename)
+    keysinorder = []
+    for l in filecontents.split('\n'):
+        m = re.match(r'([-a-zA-Z0-9]*):', l)
+        if m:
+            keysinorder.append(m.group(1))
+
+    for k in dsc.keys():
+        if k in ("build-depends","build-depends-indep"):
+            dsc[k] = create_depends_string(split_depends(dsc[k]))
+        elif k == "architecture":
+            if (dsc["architecture"] != "any"):
+                dsc['architecture'] = colour_output(dsc["architecture"], 'arch')
+        elif k in ("files","changes","description"):
+            if use_html:
+                dsc[k] = formatted_text(dsc[k], strip=True)
+            else:
+                dsc[k] = ('\n'+'\n'.join(map(lambda x: ' '+x, dsc[k].split('\n')))).rstrip()
+        else:
+            dsc[k] = escape_if_needed(dsc[k])
+
+    keysinorder = filter(lambda x: not x.lower().startswith('checksums-'), keysinorder)
+
+    filecontents = '\n'.join(map(lambda x: format_field(x,dsc[x.lower()]), keysinorder))+'\n'
     return filecontents
 
 def create_depends_string (depends_tree):
@@ -309,107 +353,103 @@
 def output_deb_info(filename):
     (control, control_keys, section, depends, recommends, arch, maintainer) = read_control(filename)
 
+    if control == '':
+        return formatted_text("no control info")
     to_print = ""
-    if control == '':
-        print_formatted_text("no control info")
-    else:
-        for key in control_keys :
-            output = " " + key + ": "
-            if key == 'Depends':
-                output += create_depends_string(depends)
-            elif key == 'Recommends':
-                output += create_depends_string(recommends)
-            elif key == 'Section':
-                output += section
-            elif key == 'Architecture':
-                output += arch
-            elif key == 'Maintainer':
-                output += maintainer
-            elif key == 'Description':
-                desc = control.Find(key)
-                desc = re_newlinespace.sub('\n ', desc)
-                output += escape_if_needed(desc)
-            else:
-                output += escape_if_needed(control.Find(key))
-            to_print += output + '\n'
-        print_escaped_text(to_print)
+    for key in control_keys :
+        if key == 'Depends':
+            field_value = create_depends_string(depends)
+        elif key == 'Recommends':
+            field_value = create_depends_string(recommends)
+        elif key == 'Section':
+            field_value = section
+        elif key == 'Architecture':
+            field_value = arch
+        elif key == 'Maintainer':
+            field_value = maintainer
+        elif key == 'Description':
+            desc = control.Find(key)
+            desc = re_newlinespace.sub('\n ', desc)
+            field_value = escape_if_needed(desc)
+        else:
+            field_value = escape_if_needed(control.Find(key))
+        to_print += " "+format_field(key,field_value)+'\n'
+    return to_print
 
 def do_command (command, filename, escaped=0):
     o = os.popen("%s %s" % (command, filename))
     if escaped:
-        print_escaped_text(o.read())
+        return escaped_text(o.read())
     else:
-        print_formatted_text(o.read())
+        return formatted_text(o.read())
 
 def do_lintian (filename):
     if use_html:
-        do_command("lintian --show-overrides --color html", filename, 1)
+        return do_command("lintian --show-overrides --color html", filename, 1)
     else:
-        do_command("lintian --show-overrides --color always", filename, 1)
+        return do_command("lintian --show-overrides --color always", filename, 1)
 
-def print_copyright (deb_filename):
+def get_copyright (deb_filename):
     package = re_package.sub(r'\1', deb_filename)
     o = os.popen("dpkg-deb -c %s | egrep 'usr(/share)?/doc/[^/]*/copyright' | awk '{print $6}' | head -n 1" % (deb_filename))
     copyright = o.read()[:-1]
 
     if copyright == "":
-        print_formatted_text("WARNING: No copyright found, please check package manually.")
-        return
+        return formatted_text("WARNING: No copyright found, please check package manually.")
 
     doc_directory = re_doc_directory.sub(r'\1', copyright)
     if package != doc_directory:
-        print_formatted_text("WARNING: wrong doc directory (expected %s, got %s)." % (package, doc_directory))
-        return
+        return formatted_text("WARNING: wrong doc directory (expected %s, got %s)." % (package, doc_directory))
 
     o = os.popen("dpkg-deb --fsys-tarfile %s | tar xvOf - %s 2>/dev/null" % (deb_filename, copyright))
     copyright = o.read()
     copyrightmd5 = md5.md5(copyright).hexdigest()
 
+    res = ""
     if printed_copyrights.has_key(copyrightmd5) and printed_copyrights[copyrightmd5] != "%s (%s)" % (package, deb_filename):
-        print_formatted_text( "NOTE: Copyright is the same as %s.\n" % \
-                (printed_copyrights[copyrightmd5]))
+        res += formatted_text( "NOTE: Copyright is the same as %s.\n\n" % \
+                               (printed_copyrights[copyrightmd5]))
     else:
         printed_copyrights[copyrightmd5] = "%s (%s)" % (package, deb_filename)
-
-    print_formatted_text(copyright)
+    return res+formatted_text(copyright)
 
 def check_dsc (dsc_filename):
-    headline(".dsc file for %s" % (dsc_filename))
-    (dsc) = read_dsc(dsc_filename)
-    print_escaped_text(dsc)
-    headline("lintian check for %s" % (dsc_filename))
-    do_lintian(dsc_filename)
+    (dsc) = read_changes_or_dsc(dsc_filename)
+    foldable_output(dsc_filename, "dsc", dsc, norow=True)
+    foldable_output("lintian check for %s" % dsc_filename, "source-lintian", do_lintian(dsc_filename))
 
 def check_deb (deb_filename):
     filename = os.path.basename(deb_filename)
+    packagename = filename.split('_')[0]
 
     if filename.endswith(".udeb"):
         is_a_udeb = 1
     else:
         is_a_udeb = 0
 
-    headline("control file for %s" % (filename))
-    #do_command ("dpkg -I", deb_filename)
-    output_deb_info(deb_filename)
-
-    if is_a_udeb:
-        headline("skipping lintian check for udeb")
-        print
-    else:
-        headline("lintian check for %s" % (filename))
-        do_lintian(deb_filename)
-
-    headline("contents of %s" % (filename))
-    do_command ("dpkg -c", deb_filename)
-
-    if is_a_udeb:
-        headline("skipping copyright for udeb")
-    else:
-        headline("copyright of %s" % (filename))
-        print_copyright(deb_filename)
-
-    headline("file listing of %s" % (filename))
-    do_command ("ls -l", deb_filename)
+
+    foldable_output("control file for %s" % (filename), "binary-%s-control"%packagename,
+                    output_deb_info(deb_filename), norow=True)
+
+    if is_a_udeb:
+        foldable_output("skipping lintian check for udeb", "binary-%s-lintian"%packagename,
+                        "")
+    else:
+        foldable_output("lintian check for %s" % (filename), "binary-%s-lintian"%packagename,
+                        do_lintian(deb_filename))
+
+    foldable_output("contents of %s" % (filename), "binary-%s-contents"%packagename,
+                    do_command("dpkg -c", deb_filename))
+
+    if is_a_udeb:
+        foldable_output("skipping copyright for udeb", "binary-%s-copyright"%packagename,
+                        "")
+    else:
+        foldable_output("copyright of %s" % (filename), "binary-%s-copyright"%packagename,
+                        get_copyright(deb_filename))
+
+    foldable_output("file listing of %s" % (filename),  "binary-%s-file-listing"%packagename,
+                    do_command("ls -l", deb_filename))
 
 # Read a file, strip the signature and return the modified contents as
 # a string.
@@ -439,10 +479,9 @@
     file.close()
     return contents
 
-# Display the .changes [without the signature]
-def display_changes (changes_filename):
-    headline(".changes file for %s" % (changes_filename))
-    print_formatted_text(strip_pgp_signature(changes_filename))
+def display_changes(changes_filename):
+    changes = read_changes_or_dsc(changes_filename)
+    foldable_output(changes_filename, "changes", changes, norow=True)
 
 def check_changes (changes_filename):
     display_changes(changes_filename)

=== modified file 'dak/show_new.py'
--- a/dak/show_new.py	2008-05-02 15:21:35 +0000
+++ b/dak/show_new.py	2008-05-03 14:01:40 +0000
@@ -44,54 +44,97 @@
 ################################################################################
 ################################################################################
 
-def html_header(name):
+def html_header(name, filestoexamine):
     if name.endswith('.changes'):
         name = ' '.join(name.split('_')[:2])
-    print """<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
-        <html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8">"""
-    print "<title>%s - Debian NEW package overview</title>" % (name)
-    print """<link type="text/css" rel="stylesheet" href="/style.css">
-        <link rel="shortcut icon" href="http://www.debian.org/favicon.ico";>
-        </head>
-        <body>
-        <div align="center">
-        <a href="http://www.debian.org/";>
-     <img src="http://www.debian.org/logos/openlogo-nd-50.png"; border="0" hspace="0" vspace="0" alt=""></a>
-        <a href="http://www.debian.org/";>
-     <img src="http://www.debian.org/Pics/debian.png"; border="0" hspace="0" vspace="0" alt="Debian Project"></a>
-        </div>
-        <br />
-        <table class="reddy" width="100%">
-        <tr>
-        <td class="reddy">
-    <img src="http://www.debian.org/Pics/red-upperleft.png"; align="left" border="0" hspace="0" vspace="0"
-     alt="" width="15" height="16"></td>"""
-    print """<td rowspan="2" class="reddy">Debian NEW package overview for %s</td>""" % (name)
-    print """<td class="reddy">
-    <img src="http://www.debian.org/Pics/red-upperright.png"; align="right" border="0" hspace="0" vspace="0"
-     alt="" width="16" height="16"></td>
-        </tr>
-        <tr>
-        <td class="reddy">
-    <img src="http://www.debian.org/Pics/red-lowerleft.png"; align="left" border="0" hspace="0" vspace="0"
-     alt="" width="16" height="16"></td>
-        <td class="reddy">
-    <img src="http://www.debian.org/Pics/red-lowerright.png"; align="right" border="0" hspace="0" vspace="0"
-     alt="" width="15" height="16"></td>
-        </tr>
-        </table>
-        """
+    print """<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
+<html xmlns="http://www.w3.org/1999/xhtml"; xml:lang="de" lang="de">
+  <head>
+    <meta http-equiv="content-type" content="text/xhtml+xml; charset=utf-8"
+    />
+    <title>%(name)s - Debian NEW package overview</title>
+    <link type="text/css" rel="stylesheet" href="/style.css" />
+    <link rel="shortcut icon" href="http://www.debian.org/favicon.ico"; />
+    <script type="text/javascript">
+      //<![CDATA[
+      <!--
+      function toggle(id, initial, display) {
+        var o = document.getElementById(id);
+        toggleObj(o, initial, display);
+      }
+      function show(id, display) {
+        var o = document.getElementById(id);
+        o.style.display = 'table-row-group';
+      }
+      function toggleObj(o, initial, display) {
+        if(! o.style.display)
+          o.style.display = initial;
+        if(o.style.display == display) {
+          o.style.display = "none";
+        } else {
+          o.style.display = display;
+        }
+      }
+      //-->
+      //]]>
+    </script>
+  </head>
+  <body id="NEW-details-page">
+    <div id="logo">
+      <a href="http://www.debian.org/";>
+        <img src="http://www.debian.org/logos/openlogo-nd-50.png";
+        alt="debian logo" /></a>
+      <a href="http://www.debian.org/";>
+        <img src="http://www.debian.org/Pics/debian.png";
+        alt="Debian Project" /></a>
+    </div>
+    <div id="titleblock">
+      <img src="http://www.debian.org/Pics/red-upperleft.png";
+      id="red-upperleft" alt="corner image"/>
+      <img src="http://www.debian.org/Pics/red-lowerleft.png";
+      id="red-lowerleft" alt="corner image"/>
+      <img src="http://www.debian.org/Pics/red-upperright.png";
+      id="red-upperright" alt="corner image"/>
+      <img src="http://www.debian.org/Pics/red-lowerright.png";
+      id="red-lowerright" alt="corner image"/>
+      <span class="title">
+        Debian NEW package overview for %(name)s
+      </span>
+    </div>
+    """%{"name":name}
+
+    # we assume only one source (.dsc) per changes here
+    print """
+    <div id="menu">
+      <p class="title">Navigation</p>
+      <p><a href="#changes" onclick="show('changes-body')">.changes</a></p>
+      <p><a href="#dsc" onclick="show('dsc-body')">.dsc</a></p>
+      <p><a href="#source-lintian" onclick="show('source-lintian-body')">source lintian</a></p>
+      """
+    for fn in filter(lambda x: x.endswith('.deb') or x.endswith('.udeb'),filestoexamine):
+        packagename = fn.split('_')[0]
+        print """
+        <p class="subtitle">%(pkg)s</p>
+        <p><a href="#binary-%(pkg)s-control" onclick="show('binary-%(pkg)s-control-body')">control file</a></p>
+        <p><a href="#binary-%(pkg)s-lintian" onclick="show('binary-%(pkg)s-lintian-body')">binary lintian</a></p>
+        <p><a href="#binary-%(pkg)s-contents" onclick="show('binary-%(pkg)s-contents-body')">.deb contents</a></p>
+        <p><a href="#binary-%(pkg)s-copyright" onclick="show('binary-%(pkg)s-copyright-body')">copyright</a></p>
+        <p><a href="#binary-%(pkg)s-file-listing" onclick="show('binary-%(pkg)s-file-listing-body')">file listing</a></p>
+        """%{"pkg":packagename}
+    print "    </div>"
 
 def html_footer():
-    print "<p class=\"validate\">Timestamp: %s (UTC)</p>" % (time.strftime("%d.%m.%Y / %H:%M:%S", time.gmtime()))
-    print """<a href="http://validator.w3.org/check?uri=referer";>
-    <img border="0" src="http://www.w3.org/Icons/valid-html401"; alt="Valid HTML 4.01!" height="31" width="88"></a>
-        <a href="http://jigsaw.w3.org/css-validator/check/referer";>
-    <img border="0" src="http://jigsaw.w3.org/css-validator/images/vcss"; alt="Valid CSS!"
-     height="31" width="88"></a>
-    """
-    print "</body></html>"
-
+    print """    <p class="validate">Timestamp: %s (UTC)</p>"""% (time.strftime("%d.%m.%Y / %H:%M:%S", time.gmtime()))
+    print """    <p><a href="http://validator.w3.org/check?uri=referer";>
+      <img src="http://www.w3.org/Icons/valid-html401"; alt="Valid HTML 4.01!"
+      style="border: none; height: 31px; width: 88px" /></a>
+    <a href="http://jigsaw.w3.org/css-validator/check/referer";>
+      <img src="http://jigsaw.w3.org/css-validator/images/vcss";
+      alt="Valid CSS!" style="border: none; height: 31px; width: 88px" /></a>
+    </p>
+  </body>
+</html>
+"""
 
 ################################################################################
 
@@ -115,19 +158,23 @@
     # do not generate html output if that source/version already has one.
     if not os.path.exists(os.path.join(Cnf["Show-New::HTMLPath"],htmlname)):
         sys.stdout = open(os.path.join(Cnf["Show-New::HTMLPath"],htmlname),"w")
-        html_header(changes["source"])
+
+        filestoexamine = []
+        for pkg in new.keys():
+            for fn in new[pkg]["files"]:
+                if ( files[fn].has_key("new") and not
+                     files[fn]["type"] in [ "orig.tar.gz", "orig.tar.bz2", "tar.gz", "tar.bz2", "diff.gz", "diff.bz2"] ):
+                    filestoexamine.append(fn)
+
+        html_header(changes["source"], filestoexamine)
 
         daklib.queue.check_valid(new)
         examine_package.display_changes(Upload.pkg.changes_file)
 
-        for pkg in new.keys():
-            for file in new[pkg]["files"]:
-                if ( files[file].has_key("new") and not
-                     files[file]["type"] in [ "orig.tar.gz", "orig.tar.bz2", "tar.gz", "tar.bz2", "diff.gz", "diff.bz2"] ):
-                    if file.endswith(".deb") or file.endswith(".udeb"):
-                        examine_package.check_deb(file)
-                    elif file.endswith(".dsc"):
-                        examine_package.check_dsc(file)
+        for fn in filter(lambda fn: fn.endswith(".dsc"), filestoexamine):
+            examine_package.check_dsc(fn)
+        for fn in filter(lambda fn: fn.endswith(".deb") or fn.endswith(".udeb"), filestoexamine):
+            examine_package.check_deb(fn)
 
         html_footer()
         if sys.stdout != stdout_fd:
@@ -139,6 +186,7 @@
 def usage (exit_code=0):
     print """Usage: dak show-new [OPTION]... [CHANGES]...
   -h, --help                show this help and exit.
+  -p, --html-path [path]    override output directory.
   """
     sys.exit(exit_code)
 
@@ -149,7 +197,8 @@
 
     Cnf = daklib.utils.get_conf()
 
-    Arguments = [('h',"help","Show-New::Options::Help")]
+    Arguments = [('h',"help","Show-New::Options::Help"),
+                 ("p","html-path","Show-New::HTMLPath","HasArg")]
 
     for i in ["help"]:
         if not Cnf.has_key("Show-New::Options::%s" % (i)):
@@ -183,7 +232,7 @@
         print "\n" + changes_file
         do_pkg (changes_file)
     files = set(os.listdir(Cnf["Show-New::HTMLPath"]))
-    to_delete = files.difference(sources)
+    to_delete = filter(lambda x: x.endswith(".html"), files.difference(sources))
     for file in to_delete:
         os.remove(os.path.join(Cnf["Show-New::HTMLPath"],file))
 

=== added directory 'web'
=== added file 'web/style.css'
--- a/web/style.css	1970-01-01 00:00:00 +0000
+++ b/web/style.css	2008-05-03 14:01:40 +0000
@@ -0,0 +1,277 @@
+p.note {
+ font-family: sans-serif;
+ color: #900;
+ text-align: center;
+ padding: 5px;
+ font-size: 11px;
+ font-weight: normal;
+}
+
+div.c1 {text-align: center}
+
+p.text {
+ font-family: sans-serif;
+ padding: 5px;
+ font-size: 105%;
+ font-weight: normal;
+}
+
+body {
+ font-family: Arial, Helvetica, sans-serif;
+ color: #000000;
+ background-color: #FFF;
+}
+
+table.reddy
+{
+ color: #000;
+ background-color: #000;
+ border: 0px solid #000;
+ border-collapse: collapse;
+}
+
+ul {
+ color: #222;
+ font-size: 115%;
+}
+
+td.reddy {
+ font-family: serif;
+ font-size: 24px;
+ font-weight: normal;
+ background-color: #DF0451;
+ color: #FFFF00;
+ border: 0px solid #DF0451;
+ vertical-align: middle;
+ text-align: center;
+ padding: 0px;
+}
+
+p.validate {
+ text-align: center;
+}
+
+table
+{
+ color: #000;
+ background-color: #000;
+ border: 0px solid #000;
+ border-collapse: separate;
+ border-spacing: 1px;
+}
+
+h1 {
+ font-size: 200%;
+ text-align: center;
+ color: #000;
+}
+
+h2 {
+ font-size: 160%;
+ color: #000;
+}
+
+p {
+ font-size: 100%;
+ font-weight: bold;
+ text-align: justify;
+ color: #222;
+}
+
+tr {
+ background-color: #FFF;
+}
+
+tr.odd {
+ background-color: #FFFFFF;
+}
+
+tr.even {
+ background-color: #e8e8e8;
+}
+
+td.sid {
+ color: #000;
+ text-align: left;
+}
+
+tr.experimental {
+ color: #cc0000;
+}
+
+tr.unstable {
+ color: #345677;
+}
+
+tr.sid_odd {
+ color: #000;
+}
+
+td.exp {
+ color: #cc0000;
+ text-align: left;
+}
+
+tr.exp_odd {
+ color: #900;
+}
+
+th {
+ font-size: 120%;
+ text-align: center;
+ font-weight: bold;
+ background-color: #BDF;
+ border: 0px solid #000;
+ padding-top: 10px;
+ padding-bottom: 10px;
+ padding-left: 6px;
+ padding-right: 6px;
+}
+
+th.reject {
+ font-size: 120%;
+ text-align: center;
+ font-weight: bold;
+ background-color: #BDF;
+ border: 0px solid #000;
+ padding-top: 10px;
+ padding-bottom: 10px;
+ padding-left: 6px;
+ padding-right: 6px;
+}
+
+td {
+ font-size: 105%;
+ border: 0px solid #000;
+ padding: 4px;
+ padding-left: 6px;
+ padding-right: 6px;
+}
+
+a:link {
+ color: #0000FF;
+ text-decoration: none;
+}
+
+a:visited {
+ color: #800080;
+ text-decoration: none;
+}
+
+a:active {
+ color: #FF0000;
+ text-decoration: none;
+}
+
+a:hover{
+ color: #0000FF;
+ text-decoration: underline;
+}
+
+.footer {
+ font-size: 90%;
+}
+
+/************* NEW details pages ************/
+#NEW-details-page a img {
+	text-decoration: none;
+	border: none;
+}
+#NEW-details-page #logo {
+	text-align: center;
+	margin-bottom: 1.5em;
+}
+#NEW-details-page #titleblock {
+	position: relative;
+	width: 100%;
+	text-align: center;
+	background-color: #DF0451;
+	color: #FFFF00;
+	padding: 0.2em;
+	margin-bottom: 1.5em;
+}
+#NEW-details-page #titleblock a {
+        color: #FFFF00;
+        text-decoration: none;
+}
+#NEW-details-page #titleblock a:hover {
+	color: #FFFF00;
+	text-decoration: underline;
+}
+#NEW-details-page #red-upperleft {
+	position: absolute;
+	top: 0px;
+	left: 0px;
+}
+#NEW-details-page #red-lowerleft {
+	position: absolute;
+	bottom: 0px;
+	left: 0px;
+}
+#NEW-details-page #red-upperright {
+	position: absolute;
+	top: 0px;
+	right: 0px;
+}
+#NEW-details-page #red-lowerright {
+	position: absolute;
+	bottom: 0px;
+	right: 0px;
+}
+#NEW-details-page #titleblock .title {
+	vertical-align: middle;
+        font-weight: normal;
+	font-family: serif;
+	font-size: 22px;
+}
+#NEW-details-page #menu {
+	font-size: 80%;
+	position: fixed;
+	bottom: 1em;
+	right: 0em;
+	background: #ddd;
+	width: 9%;
+	padding: 0.5em 0 0.5em 0.5em;
+}
+#NEW-details-page #menu p {
+	margin: 0px;
+}
+#NEW-details-page .infobox {
+	width: 80%;
+	border: solid black 2px;
+	margin: 1em auto;
+}
+#NEW-details-page #menu .title,.infobox .title {
+	text-align: center;
+	font-weight: bold;
+	border-bottom: dashed 1px black;
+	margin: 0.2em;
+}
+#NEW-details-page .infobox .subtitle { 
+	text-align: center;
+	font-weight: bold;
+	border-bottom: dashed 1px black;
+	margin: 0.2em;
+}
+#NEW-details-page table.infobox {
+	padding: 0 .5em 1em .5em;
+}
+#NEW-details-page div.infobody {
+	margin: .5em 1em;
+}
+#NEW-details-page .rfc822 .key,#NEW-details-page .val {
+	font-family: monospace;
+}
+#NEW-details-page .rfc822 .key {
+	vertical-align: baseline;
+}
+#NEW-details-page .rfc822 .val {
+}
+#NEW-details-page .copyright .infobody {
+	font-family: monospace;
+	white-space: pre;
+}
+
+#NEW-details-page td pre { 
+        margin: 0pt
+}


Reply to: