[dak/master] Make cross_suite_version_checks functional. OLD bug.
Signed-off-by: Joerg Jaspert <joerg@debian.org>
---
ChangeLog | 6 ++++++
daklib/queue.py | 4 ++--
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 927b416..051bd1d 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2008-11-30 Joerg Jaspert <joerg@debian.org>
+
+ * dak/daklib/queue.py (Upload.cross_suite_version_check): Add a
+ few () to make cross_suite_version_check finally work as
+ intended (well, we hope). Thanks to Philipp Kern for spotting this.
+
2008-11-28 Mark Hymers <mhy@debian.org>
* dak/new_security_install.py: Don't attempt to delete the .changes files
diff --git a/daklib/queue.py b/daklib/queue.py
index 813782e..6980334 100755
--- a/daklib/queue.py
+++ b/daklib/queue.py
@@ -855,8 +855,8 @@ distribution."""
# Check versions for each target suite
for target_suite in self.pkg.changes["distribution"].keys():
- must_be_newer_than = [ i.lower for i in self.Cnf.ValueList("Suite::%s::VersionChecks::MustBeNewerThan" % (target_suite)) ]
- must_be_older_than = [ i.lower for i in self.Cnf.ValueList("Suite::%s::VersionChecks::MustBeOlderThan" % (target_suite)) ]
+ must_be_newer_than = [ i.lower() for i in self.Cnf.ValueList("Suite::%s::VersionChecks::MustBeNewerThan" % (target_suite)) ]
+ must_be_older_than = [ i.lower() for i in self.Cnf.ValueList("Suite::%s::VersionChecks::MustBeOlderThan" % (target_suite)) ]
# Enforce "must be newer than target suite" even if conffile omits it
if target_suite not in must_be_newer_than:
must_be_newer_than.append(target_suite)
--
1.5.6.5
Reply to: