[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: I've gotten my ``build-simple-cdd'' script working again



On Fri, Oct 19, 2007 at 08:05:48AM -0700, Bruce Korb wrote:
> It turns out that the first time around I was running in my locally mounted
> private directory and all was fine.  When I tried to set up the build for
> my co-workers, I used shared directories because that's how we all share
> our work.  Unfortunately, the build-simple-cdd script must run as real
> root and not fakeroot.  That means that my NFS directories were trying
> to manipulate files as "nobody" and that was not working.  The symptom
> was that packages were reported missing, a la:

i strongly recommend against running build-simple-cdd as root. it is not
necessary. can you set the group permissions and umask properly instead?
 
>   ERROR: missing required packages from profile default:  less
> 
> and the truth was that deeply buried in nested layers of shell/python/perl/make
> script files was a failure saying "permission denied".  To find that message
> I had to run scripts with ``set -x'' and run make with verbose output.


> Attached is a patch to 0.3.5 source that makes no change other than:

it seems like there are unrelated and undocumented changes all in a
single patch(a lot of which seem to be whitespace-only changes). if the
issues could be separated out into separate patches, i would be more
able to review the merits of each idea.

> * is a little more readable

debateable :P

> * is a little more debuggable when ``set -x'' is active
>   (the ``:'' command shows up in stderr output)

if you could split those parts into it's own patch, this would be
preferrable.
 
> Please discard or adopt, at your choice.

the FAQ update seems incorrect to me.

i'm not fond of the way in which some single-line commands are broken
into multiple lines, especially some in ways that i think would require
bash.

> Thank you for the project, by the way.  Did save me a fair amount of trouble.
 
thanks for using it, and for the feedback, even though we may have a
different opinion on some of these issues. :)

live well,
  vagrant

p.s. please do not CC me, i read the debian-custom list, and would
prefer conversation to occur in public, so that others may benefit from
the conversation. see: http://www.debian.org/MailingLists/#codeofconduct

"When replying to messages on the mailing list, do not send a carbon
copy (CC) to the original poster unless they explicitly request to be
copied."



Reply to: