Bug#975381: Subject: libinih: drop Debian's custom vendorisation

[Andreas Metzler <ametzler@bebt.de>]

On 2020-11-21 Stephan Lachnit <stephanlachnit@protonmail.com> wrote:
[...]
> Because the library was designed for embedded use cases where every
> little bit of performance matters, the runtime patch was refused
> upstream. Dropping the runtime patch from Debian actually isn't
> problem, no reverse dependency of libinih uses compile time options
> anyway.

Hello,

goxel does.[1]

goxel-0.10.6/src/utils/ini.h:#define INI_HANDLER_LINENO 1

and gnutls would, too.

So imho inih upstream needs a interface that allows linking either
dynamically against system libinih or statically against the included
copy without changing the source with something equivalent to the
compile time options. The current Debian-patched version requires source
changes depending on what linkage is targeted, upstream's version of the
dynamic library just does not work when these compile time options are
needed. 

cu Andreas

[1] Which is probably why it actually uses the static copy although it
depends on libinih. (#978021)
-- 
`What a good friend you are to him, Dr. Maturin. His other friends are
so grateful to you.'
`I sew his ears on from time to time, sure'