[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#904558: What should happen when maintscripts fail to restart a service



Am 07.10.18 um 20:46 schrieb Michael Biebl:
> Let me add here, that a lot of sysv init scripts I looked at do not
> actually return proper error codes in case the service fails to start.
> Picking a random example, like anacron, I see for the start action:
> 
>     start-stop-daemon --start --exec /usr/sbin/anacron -- -s
>     log_end_msg 0
> 

And even if the init scripts use "log_end_msg $?"
most of them do not exit at this point but have an explicit
"exit 0" at the end of the script [1].
So while you get a log message on stdout which indicates failure, you
don't get a return code which would cause dpkg to abort.

IIRC, this basically was the reason why we used "|| true" in
dh_systemd_start to mimic the effective dh_installinit behaviour.

Michael

[1] IIRC not even the skeleton file which is shipped for sysvinit does
this correctly and as a result was copied and pasted into numerous packages.


-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: