Philip Hands <phil@hands.com> writes: > Steve McIntyre <steve@einval.com> writes: > >> On Sat, Dec 24, 2016 at 02:25:48AM +0100, Philip Hands wrote: >>>Raphael Hertzog <hertzog@debian.org> writes: >>>... >>>> So I agree with Cyril and the d-i team, we should be cautious here. >>>> >>>> Let's focus everybody's energy on getting Phil's patch merged instead >>>> of continuing this discussion. >>> >>>The latest incarnation of which I think is close to ready: >>> >>> https://anonscm.debian.org/cgit/d-i/pkgsel.git/log/?h=pu/simple_tasksel >>> >>>I've squashed the commits together, so we now have the first (aae3196) >>>which implements the feature, and would probably be fine as it is (once >>>comments to the translators have been added as appropriate). >>> >>>The second commit (1bb1feb) adds a level of indirection in the >>>template, with code to populate it from some new debconf settings, >>>which allows one to then customise the menu via preseeding. This is not >>>in any way essential to the task in hand, but might well be useful for >>>others. >> >> I'll be honest - that code scares me right now. If this was simple, >> obvious stuff then I'd be pushing to try and get this in. But it's >> not. Comments like >> >> + # there is no need to do this twice, and it breaks [back] behaviour if you do >> >> don't help, and I honestly don't understand what > > Fair point, and actually the code that comment applies to is only useful > when 'db_capb backup' is enabled, which for complicated reasons[0] it is > not at present, so I should just comment the lot out to avoid doubt. So, for simplicity, we should just consider this version: https://anonscm.debian.org/cgit/d-i/pkgsel.git/log/?h=pu/simple_tasksel2 I've left the fixup separate to make it easy to see that I've really just removed the redundant if, and added some more verbose comments. The commits in this branch should be squashed together if they ever get into master. The resulting code is here: https://anonscm.debian.org/cgit/d-i/pkgsel.git/tree/debian/postinst?h=pu/simple_tasksel2&id=3739e72f563f86a4a2cf539361c791520b96fa86#n49 HTH Cheers, Phil. -- |)| Philip Hands [+44 (0)20 8530 9560] HANDS.COM Ltd. |-| http://www.hands.com/ http://ftp.uk.debian.org/ |(| Hugo-Klemm-Strasse 34, 21075 Hamburg, GERMANY
Attachment:
signature.asc
Description: PGP signature