Re: Bug#766708: breaks multiarch cross building

[Colin Watson <cjwatson@debian.org>]

On Sun, Oct 26, 2014 at 03:51:00PM +0100, Helmut Grohne wrote:
> diff -u gcc-4.9-4.9.1/debian/rules.defs gcc-4.9-4.9.1/debian/rules.defs
> --- gcc-4.9-4.9.1/debian/rules.defs
> +++ gcc-4.9-4.9.1/debian/rules.defs
> @@ -125,6 +125,9 @@
>    $(error Invalid architecure.)
>  endif
> 
> +# Force this, people get confused about the default. See #760770.
> +with_deps_on_target_arch_pkgs :=
> +
>  # including unversiond symlinks for binaries
>  #with_unversioned = yes
> 
> @@ -1449,9 +1447,7 @@
>  #ifeq ($(trunk_build),yes)
>  #  no_biarch_libs := yes
>  #endif
> -ifdef DEB_CROSS_NO_BIARCH
> -  no_biarch_libs := yes
> -endif
> +no_biarch_libs :=
> 
>  ifeq ($(no_biarch_libs),yes)
>    with_lib64gcc                := no
> 
> Rationale:
> 
> Prior to these changes it was possible to build a gcc cross compiler
> with different properties from the default build by setting
> with_deps_on_target_arch_pkgs=yes and DEB_CROSS_NO_BIARCH=yes.

I may be missing something here.  It's true that this change sets
defaults for these make variables and overrides values set in the
environment.  However, since the "override" directive is not used, can't
you still override this by using command-line options to make?

(This message should not be read as encouragement to add the "override"
directive; the make documentation explicitly says that it "was not
invented for escalation in the war between makefiles and command
arguments".)

-- 
Colin Watson                                       [cjwatson@debian.org]