Am 19.01.2014 11:59, schrieb Bastian Blank: > On Sat, Jan 18, 2014 at 11:33:32PM +0100, Michael Biebl wrote: >> On Sat, Jan 18, 2014 at 01:20:41PM +0100, Bastian Blank wrote: >>> - lvm2.service is statically hooked to local-fs.target, as all local >>> mounts. >> lvm2.service is not a local mount, so that is not really a justification for >> enabling the service statically. > > Please show me a better target. This is what the generator does, so I > assume there exists none. This is a misunderstanding. The target is fine. I was just saying that using the target as justification for enabling the service statically is flawed. That said, I don't really care if you hook up the service statically. I'm just a bit surprised since you objected the generator as you wanted the possibility to disable the service. > >>> +ExecStartPre=/bin/udevadm settle >> Please don't run udevadm directly. This is a udev command. > > Can you please describe what will be broken by this? The more important question is: what are you trying to fix with this? The cryptsetup.target will only be active once all hooked up devices are ready. There is no point adding a udevadm settle. That is purely useless. So again, what are you trying to do/fix here? >> Wants=systemd-udev-settle.service >> After=systemd-udev-settle.service ... >> (as the original .service file does). > > The generated service files uses both variants: > - The pre-cryptsetup and pre-local-fs services uses > systemd-udev-settle.service. > - The pre-remote-fs service, which is not included here currently, uses > ExecStartPre. You don't include that service. And also, just because pre-remote-fs.service uses the ExecStartPre hack is no justification for using that in lvm2.service. pre-remote-fs.service is a completely different beast. If you need more information, please ask. But please don't cook up your own patch just for the sake of it. This bug has been open for far too long. Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth?
Attachment:
signature.asc
Description: OpenPGP digital signature