[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#727708: upstart and upgrading from sysvinit scripts

On Sat, 2013-12-28 at 17:24 -0800, Russ Allbery wrote:
> * systemd synchronization support added via sd_notify.
> * systemd socket activation support.

Does sd_notify() actually give any positive effect compared to just
using type=simple, given that you already have socket activation? The
UDP socket should buffer packets until the daemon reads them. Explicit
notify does have the negative effect that depending services can not be
started in parallel.

Or do you want to support running it as a systemd service but without
using socket activation (would seem rather pointless)? You ship
a .socket file by default, so it doesn't explain the use of type=notify
in the provided file at least.

I think the .service file should have a Requires= on the socket to make
the service fail in case the socket could not be opened (probably
doesn't matter otherwise). There's a typo "mutli-user.target".

Reply to: