[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#700759: Re: Bug#700677: Incorrect upstream versioning / ABI breakage



On Sun, Feb 17, 2013 at 01:57:46AM +0000, Dmitrijs Ledkovs wrote:
> On 16/02/13 05:36, Daniel Baumann wrote:
> > n 02/16/2013 03:40 AM, Colin Watson wrote:
> >> have ntfs-3g Provides: libntfs-3gSOVER (substituted as appropriate)

> > patches welcome.

> Here is the patch to implement this.
> Tested to work correctly as when rebuilding testdisk it gains correct
> dependency on the virtual package.

Daniel, are you happy applying this patch?  It looks correct to me; and the
current behavior, where ntfs-3g exports a shlibs file that induces incorrect
dependencies in packages that link against it, is definitely buggy.

If you're happy with this patch I don't see any reason that the tech ctte
needs to be involved in any sort of formal ruling here, and the policy
language polishing question can be referred to debian-policy for discussion.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek@ubuntu.com                                     vorlon@debian.org


> diff -Nru ntfs-3g-2013.1.13/debian/control ntfs-3g-2013.1.13/debian/control
> --- ntfs-3g-2013.1.13/debian/control	2013-02-14 16:23:20.000000000 +0000
> +++ ntfs-3g-2013.1.13/debian/control	2013-02-16 03:58:04.000000000 +0000
> @@ -14,6 +14,7 @@
>  Architecture: linux-any kfreebsd-any
>  Pre-Depends: multiarch-support, fuse [linux-any], fuse4bsd [kfreebsd-any]
>  Depends: ${misc:Depends}, ${shlibs:Depends}
> +Provides: ${ntfs:Provides}
>  Description: read/write NTFS driver for FUSE
>   NTFS-3G uses FUSE (Filesystem in Userspace) to provide support for the NTFS
>   filesystem used by Microsoft Windows.
> @@ -46,4 +47,5 @@
>  Section: debian-installer
>  Architecture: linux-any
>  Depends: ${misc:Depends}, ${shlibs:Depends}, fuse-udeb
> +Provides: ${ntfs-udeb:Provides}
>  Description: read/write NTFS driver for FUSE
> diff -Nru ntfs-3g-2013.1.13/debian/rules ntfs-3g-2013.1.13/debian/rules
> --- ntfs-3g-2013.1.13/debian/rules	2013-02-14 16:23:38.000000000 +0000
> +++ ntfs-3g-2013.1.13/debian/rules	2013-02-16 05:42:50.000000000 +0000
> @@ -11,6 +11,9 @@
>  CONFIGURE_FLAGS = --enable-posix-acls
>  endif
>  
> +# Or shall one use objdump?
> +SONAMEMAJ=$(shell find debian/ntfs-3g -name 'libntfs-3g.so*' -type f | cut -d. -f 3)
> +
>  upstream:
>  	lynx -dump http://jp-andre.pagesperso-orange.fr/changelog.html > debian/local/changelog
>  
> @@ -79,14 +82,13 @@
>  
>  override_dh_link:
>  	rm -rf debian/ntfs-3g-dev/usr/share/doc
> -
> -	# correcting symlink target
> -	dh_link -pntfs-3g-dev lib/$(DEB_HOST_MULTIARCH)/$$(basename $$(readlink debian/tmp/usr/lib/$(DEB_HOST_MULTIARCH)/libntfs-3g.so)) usr/lib/$(DEB_HOST_MULTIARCH)/libntfs-3g.so
> -
> -	dh_link --remaining-packages
> +	dh_link
>  
>  override_dh_makeshlibs:
> -	dh_makeshlibs --add-udeb=ntfs-3g-udeb
> +	dh_makeshlibs --add-udeb=ntfs-3g-udeb -V'libntfs-3g$(SONAMEMAJ)'
>  
>  override_dh_strip:
>  	dh_strip --dbg-package=ntfs-3g-dbg
> +
> +override_dh_gencontrol:
> +	dh_gencontrol -- -Vntfs:Provides="libntfs-3g$(SONAMEMAJ)" -Vntfs-udeb:Provides="libntfs-3g-udeb$(SONAMEMAJ)"



Attachment: signature.asc
Description: Digital signature


Reply to: