Bug#1116434: srt FTCBFS: does not check nocheck profile
Source: srt
Version: 1.5.4-2
Tags: patch
User: debian-cross@lists.debian.org
Usertags: ftcbfs
X-Debbugs-Cc: debian-cross@lists.debian.org, florian@debian.org
Dear Maintainer,
srt fails to cross-build because it enables unittests unconditionally
without checking the the nocheck profile. When nocheck is enabled, it
should not build tests and should not run them.
I've fixed this in the patch attached with the mail. Please consider applying.
Thanks
Nilesh
From aa4062285d71588eacbe67c341fa2a7406ee708a Mon Sep 17 00:00:00 2001
From: Nilesh Patra <nilesh@debian.org>
Date: Sat, 27 Sep 2025 14:13:49 +0530
Subject: [PATCH] cross
---
debian/control | 2 +-
debian/rules | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/debian/control b/debian/control
index 723be1b..f03eac0 100644
--- a/debian/control
+++ b/debian/control
@@ -5,7 +5,7 @@ Build-Depends: debhelper-compat (= 13),
cmake,
help2man,
libgnutls28-dev,
- libgtest-dev,
+ libgtest-dev <!nocheck>,
libssl-dev,
pkgconf,
Build-Depends-Indep: python3-sphinx
diff --git a/debian/rules b/debian/rules
index 2bd2bdc..d301365 100755
--- a/debian/rules
+++ b/debian/rules
@@ -6,7 +6,7 @@ export DEB_CFLAGS_MAINT_APPEND = -Wall -pedantic
# Standardized flags from /usr/share/perl5/Debian/Debhelper/Buildsystem/cmake.pm.
CMAKE_OPTS := -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_BUILD_TYPE=None -DCMAKE_INSTALL_SYSCONFDIR=/etc -DCMAKE_INSTALL_LOCALSTATEDIR=/var -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON
# Enable some features that are disabled by default
-EXTRA_OPTS := -DENABLE_SHOW_PROJECT_CONFIG=ON -DENABLE_UNITTESTS=ON # unit tests require libgtest-dev
+EXTRA_OPTS := -DENABLE_SHOW_PROJECT_CONFIG=ON -DENABLE_UINTTESTS=$(if $(filter nocheck,$(DEB_BUILD_OPTIONS)),OFF,ON) # unit tests require libgtest-dev
# -DENABLE_EXAMPLES=ON -> Example Apps -> will be installed in source form and handled via autopkgtests
# -DENABLE_TESTING=ON -> DEVEL APPS (testing), some with rather generic names -> no need to install
# Restrict upstream unit testing to architectures upstream focuses on (and some where the tests succeed nonetheless)
--
2.50.1
Reply to: