On 2022-10-16 00:39 +0530, Nilesh Patra wrote: > - It uses strip extensively. While for debian systems, simply removing the strip > call from all makefiles could be OK, since dh_strip will simply take care of it. > But, it'd be hard to make things upstream-able > if desired at some point. So I sent STRIP to the <arch-triplet-prefix>-strip for > cross builds. Thanks for fixing this. I have one minor suggestion. > +ifeq ($(DEB_BUILD_GNU_TYPE),$(DEB_HOST_GNU_TYPE)) > +STRIP := strip > +else > +STRIP := $(DEB_HOST_GNU_TYPE)-strip > +export PKG_CONFIG = $(DEB_HOST_GNU_TYPE)-pkg-config > +endif x86_64-linux-gnu-strip is shipped in binutils-x86-64-linux-gnu and so on for other arches, so the above test for setting strip with/without a prefix is not necessary. Just setting: STRIP := $(DEB_HOST_GNU_TYPE)-strip should always work and is a bit neater IMHO. Wookey -- Principal hats: Debian, Wookware, ARM http://wookware.org/
Attachment:
signature.asc
Description: PGP signature