[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1014624: marked as done (FTCBFS: uses build compiler instead of host)

Your message dated Sat, 09 Jul 2022 14:49:29 +0000
with message-id <E1oABlx-000DGU-1n@fasolo.debian.org>
and subject line Bug#1014624: fixed in verse 0.22.9
has caused the Debian Bug report #1014624,
regarding FTCBFS: uses build compiler instead of host
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1014624: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1014624
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: verse
Version: 0.22.8
Severity: normal
Tags: patch

Hi,

verse fails to cross build because:

- It hardcodes gcc in the Makefile rather than using
$(CC) which the cross build system could pass the host compiler
- It strips the verse binary using build architecture's strip.
IMHO this is not needed as we can simply let dh_strip do the job.

Please consider applying the attached patch.

-- System Information:
Debian Release: bookworm/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 5.14.0-2-amd64 (SMP w/8 CPU threads)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages verse depends on:
pn  dialog  <none>
ii  libc6   2.33-7

verse recommends no packages.

verse suggests no packages.

diff --git a/Makefile b/Makefile
index 5f2f8b0..c9b9a1e 100644
--- a/Makefile
+++ b/Makefile
@@ -6,6 +6,7 @@ CFLAGS = -Wall -g -O2 -ansi $(shell dpkg-buildflags --get CFLAGS)
 CPPFLAGS = $(shell dpkg-buildflags --get CPPFLAGS)
 LDFLAGS = $(shell dpkg-buildflags --get LDFLAGS)
 MAN_DIR = /usr/share/man/man1
+CC ?= gcc
 
 all : verse
 
@@ -15,8 +16,7 @@ clean :
 distclean : clean
 
 verse : verse.c
-	gcc $(CFLAGS) $(CPPFLAGS) $(LDFLAGS) -DVERSE_LIB=\"$(VERSE_LIB)$(VERSE_NAME)\" -o verse verse.c
-	strip verse
+	$(CC) $(CFLAGS) $(CPPFLAGS) $(LDFLAGS) -DVERSE_LIB=\"$(VERSE_LIB)$(VERSE_NAME)\" -o verse verse.c
 
 install : verse $(VERSE_NAME)
 	install -m 755 -d debian/verse/$(BIN_DIR)

--- End Message ---
--- Begin Message --- 
Source: verse
Source-Version: 0.22.9
Done: Roberto C. Sánchez <roberto@debian.org>

We believe that the bug you reported is fixed in the latest version of
verse, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1014624@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Roberto C. Sánchez <roberto@debian.org> (supplier of updated verse package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 09 Jul 2022 10:21:15 -0400
Source: verse
Architecture: source
Version: 0.22.9
Distribution: unstable
Urgency: medium
Maintainer: Roberto C. Sánchez <roberto@debian.org>
Changed-By: Roberto C. Sánchez <roberto@debian.org>
Closes: 1014624
Changes:
 verse (0.22.9) unstable; urgency=medium
 .
   * Improved support for cross-building, thanks to Nilesh Patra for the patch
     (Closes: #1014624)
   * Update to Standards-Version 4.6.1 (no changes)
   * Build with hardening flags enabled
Checksums-Sha1:
 ee39942a8b8bc623e72a6c0153a7e9d4323e5520 1385 verse_0.22.9.dsc
 1521f720ddb5ace1a795665f9bdc0375fdc2f7ce 28488 verse_0.22.9.tar.xz
 0dbd121c2eac93d89fad27f24080c53cd6511a4e 5992 verse_0.22.9_amd64.buildinfo
Checksums-Sha256:
 a1bdf32ec744f75ca4a7d30e0fa25c4551595dd23ee4d918414f15b21a36f8b0 1385 verse_0.22.9.dsc
 42434b46576a43377fae8018742be2a4eeb3f934a0d19a7d1e1dbe7272717269 28488 verse_0.22.9.tar.xz
 b040c303053a03b022ad326e0a0878c967df3b88ab3814f79888ccd49e9e9e7b 5992 verse_0.22.9_amd64.buildinfo
Files:
 705b518b23a0e5884ffaee0911eb63bb 1385 doc optional verse_0.22.9.dsc
 a30939bef6b4b2f8b403f17c06825a01 28488 doc optional verse_0.22.9.tar.xz
 53662c8c4fdd3453494077393756572e 5992 doc optional verse_0.22.9_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEIYZ1DR4ae5UL01q7ldFmTdL1kUIFAmLJkWsACgkQldFmTdL1
kUL/PhAAzgh3M7/kEP5EpP5Y5rQf6siQYEZFWFy1ayKdFk8MgBSZuAVGSFExBV09
wx8sppf/zCqTd9zgxQqzufy+hDyANtGua2mpJnPv/Ik1+u8SynQylVjuQ3mqzHv2
htTP1GSAaUnQuztZlwOtuB4vm0Cf1paCQY4hk9y2LSH24odF5Q7F/gcYMXmIrMBa
gFhv2qKOiiq/7ISV2QOqNUH4rZQnvs24N/vsVjF1I2GNoq2YqtD874xmubVaWexS
qcpNY6mb6FZH4hZnZyg/nakA8gxAxEC99D+ON6IJt0/Ahrri8XOKifE7Ga8v3Dys
Xtb+O1/NNJlonyhbLmUhMaao2+PrX5X+56Go8BYv2NLgVpeSJ1JG3XI6NraXqYP4
um9s/cNBD6SkxXrKe0kAIP48pm3oZMY/WLqajG8SYMb8glmHG1JCCtk7rsAAWLt/
oIr6ypqtb8rTFz2d+XE52hvnoYkeZbJOqtWaU2AkMi9/RhwKPEZeCNZ+mjOZr5RZ
TqWRYnqazXEGT9Upo+qoluOXtu4w+xWRSO2ZtglJgSi50ObKFmQim/o1vITiBi1y
UChg8QpuO1AqlnIcMCihwt0afu/sn6n4GS8FOaiQ36bU4nB70Zv5I8odTuXmy+CW
lCs4WiUZD2d75CwiBmiQ/+MXvSbGXXEMvixw4XvWg39tVTsuX84=
=MOAN
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: