Re: Bug#1024296: debhelper: makefile buildsystem: allow buildsystems to inherit cross-building powers

[Helmut Grohne <helmut@subdivi.de>]

Hi Niels and IOhannes,

On Thu, Nov 17, 2022 at 09:46:50AM +0100, IOhannes m zmölnig wrote:
> helmut suggested to check whether the buildsystem does something to
> 'dh_auto_configure' as a basis for this discrimination.
> It should be noted that this might be a good discriminator only, if only
> the buildsystem's changes to 'dh_auto_configure' were taken into account
> (as opposed to the user specifying 'override-dh_auto_configure' or the
> like).

How about replacing the check

    ref(this) eq '...::makefile'

with

    $this->can('configure') == Debian::Debhelper::Buildsystem->can('configure')

which is totally untested and based on my understanding of the
documentation. The intention is to express "has the configure method
remained unchanged from the base class?". For makefile this should yield
true-ish. For most others false-ish. I checked all derivative build
systems and they all replace configure with two exceptions:
 * mkcmake in package mk-configure. This needs to be looked into. Maybe
   it has to add a configure method.
 * pd_lib_builder. This is where we want it changed.

Helmut