[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#929433: lintian: warn on suspicious usage of dpkg-architecture variables



Hi Chris and Graham,

On Thu, May 23, 2019 at 03:01:01PM +0100, Chris Lamb wrote:
> tags 929433 + moreinfo

I concur that this bug report is not actionable.

> So, DEB_HOST_GNU_TYPE is used quite a bit already:
> 
>   https://codesearch.debian.net/search?q=DEB_BUILD_GNU_TYPE+path%3Adebian%2Frules&perpkg=1
> 
> My two questions at this point are:
> 
>   a) Should all of these really be DEB_HOST_MULTIARCH?

No! The majority of these are correct.

>   b) Are there any other "incorrect → correct" mappings?

Let me give you some patterns that are actually wrong:

https://codesearch.debian.net/search?q=--libdir%3D.*DEB_BUILD

These should all be using DEB_HOST_MULTIARCH.

https://sources.debian.org/src/go-dep/0.5.1-1/debian/rules/?hl=23#L23

Use DEB_HOST_GNU_TYPE.

https://sources.debian.org/src/libminc/2.4.03-2/debian/rules/?hl=7#L7

Use DEB_HOST_ARCH.

https://sources.debian.org/src/espresso/6.3-4/debian/rules/?hl=11#L11

Use DEB_HOST_ARCH_CPU.

https://sources.debian.org/src/gupnp/1.0.3-3/debian/rules/?hl=9#L9

Use DEB_HOST_ARCH_OS.


Using a quick codesearch, I was able to find maybe 10 occurrences. I
don't see any way to turn these examples into a common pattern. My
experience with filing cross issues is the this kind of issue is rare.
Around 1 in 100 cross bugs matches this kind of problem. We've mostly
sorted them out. I don't believe writing the lintian check is worth the
effort. We should just send patches for each of them and move on.

Graham, maybe you can send patches for each of these?

I'm in favour of wontfix.

Helmut


Reply to: