[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1012360: Please add support for systemd-binfmt



Package: cmucl
Version: 21d-1.1
Severity: wishlist
Tags: patch
User: pkg-systemd-maintainers@lists.alioth.debian.org
Usertags: systemd-binfmt

Hi,

your package cmucl declares a dependency (Recommends) on binfmt-support
and ships binfmt-support configuration files in /usr/share/binfmts/.

systemd provides a builtin, cross-distro facility named systemd-binfmt to
register binary formats.

You can read more about it at
https://www.freedesktop.org/software/systemd/man/systemd-binfmt.html
https://www.freedesktop.org/software/systemd/man/binfmt.d.html
https://www.kernel.org/doc/html/latest/admin-guide/binfmt-misc.html

The systemd package provides a dpkg file trigger so it is sufficient to
simply install configuration files in /usr/lib/binfmt.d/, no
modifications in the maintainer scripts are necessary.

The attached patch adds support for systemd-binfmt and adjusts the
dependency on binfmt-support accordingly, so binfmt-support is no longer
installed automatically if systemd is already installed.


Regards,
Michael


-- System Information:
Debian Release: bookworm/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (200, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.17.0-3-amd64 (SMP w/4 CPU threads; PREEMPT)
Kernel taint flags: TAINT_FIRMWARE_WORKAROUND
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages cmucl:i386 depends on:
ii  debconf [debconf-2.0]  1.5.79
ii  libc6                  2.33-7

Versions of packages cmucl:i386 recommends:
ii  binfmt-support  2.2.2-1

Versions of packages cmucl:i386 suggests:
pn  cmucl-docs    <none>
pn  cmucl-source  <none>
pn  ilisp         <none>
diff -Nru cmucl-21d/debian/changelog cmucl-21d/debian/changelog
--- cmucl-21d/debian/changelog	2021-01-19 01:51:40.000000000 +0100
+++ cmucl-21d/debian/changelog	2022-06-05 16:46:50.000000000 +0200
@@ -1,3 +1,9 @@
+cmucl (21d-1.2) UNRELEASED; urgency=medium
+
+  * Add support for systemd-binfmt
+
+ -- Michael Biebl <biebl@debian.org>  Sun, 05 Jun 2022 16:46:50 +0200
+
 cmucl (21d-1.1) unstable; urgency=medium
 
   * Non maintainer upload by the Reproducible Builds team.
diff -Nru cmucl-21d/debian/control cmucl-21d/debian/control
--- cmucl-21d/debian/control	2018-12-20 09:50:18.000000000 +0100
+++ cmucl-21d/debian/control	2022-06-05 16:44:56.000000000 +0200
@@ -16,7 +16,7 @@
 Depends: ${shlibs:Depends}, ${misc:Depends}
 Suggests: cmucl-source, cmucl-docs, ilisp
 Provides: lisp-compiler, lisp-core
-Recommends: binfmt-support (>= 1.1.2)
+Recommends: binfmt-support | systemd
 Description: CMU Common Lisp compiler and development system
  This is the basis package for CMUCL. It contains the base
  image with the compiler, PCL (CLOS), and the tty based
diff -Nru cmucl-21d/debian/Makefile cmucl-21d/debian/Makefile
--- cmucl-21d/debian/Makefile	2018-12-20 09:50:18.000000000 +0100
+++ cmucl-21d/debian/Makefile	2022-06-05 16:46:50.000000000 +0200
@@ -52,6 +52,7 @@
 	   linux-4/lisp/internals.inc $(DESTCMU)usr/lib/cmucl/
 	install -g root -o root -m 0755 debian/own-work/cmucl-run $(DESTCMU)usr/bin/cmucl-run
 	install -g root -o root -m 0644 debian/own-work/binfmt $(DESTCMU)usr/share/binfmts/cmucl
+	install -g root -o root -m 0644 -D debian/own-work/cmucl.conf $(DESTCMU)usr/lib/binfmt.d/cmucl.conf
 	install -g root -o root -m 0444 src/general-info/cmucl.1 $(DESTCMU)usr/share/man/man1/cmucl-lisp.1
 	install -g root -o root -m 0444 src/general-info/lisp.1 $(DESTCMU)usr/share/man/man1/cmucl.1
 	install -g root -o root -m 0444 src/general-info/lisp.1 $(DESTCMU)usr/share/man/man1/lisp.1
diff -Nru cmucl-21d/debian/own-work/cmucl.conf cmucl-21d/debian/own-work/cmucl.conf
--- cmucl-21d/debian/own-work/cmucl.conf	1970-01-01 01:00:00.000000000 +0100
+++ cmucl-21d/debian/own-work/cmucl.conf	2022-06-05 16:45:25.000000000 +0200
@@ -0,0 +1 @@
+:cmucl:M::FASL FILE::/usr/bin/cmucl-run:

Reply to: