[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#931795: sbcl: FTBFS with gcc-9, uses deprecated armv5 target on armhf

Source: sbcl
Version: 2:1.5.4-1
Severity: serious
Justification: uses non-optimized code
Tags: patch
Forwarded: https://github.com/sbcl/sbcl/pull/34

cat debian/patches/default-arm.patch 
Description: Default on armv7 for Ubuntu, since gcc-9 deprecates armv5
Author: Gianfranco Costamagna <locutusofborg@debian.org>
Forwarded: https://github.com/sbcl/sbcl/pull/34
Last-Update: 2019-07-10

--- sbcl-1.5.4.orig/src/runtime/Config.arm-linux
+++ sbcl-1.5.4/src/runtime/Config.arm-linux
@@ -9,7 +9,7 @@
 # provided with absolutely no warranty. See the COPYING and CREDITS
 # files for more information.
-CFLAGS += -marm -march=armv5
+CFLAGS += -marm -march=armv7
 NM = ./linux-nm
 ASSEM_SRC = arm-assem.S ldso-stubs.S

with gcc-9, armv5 is now a deprecated keyword, resulting the build in:
make[2]: Entering directory '/<<PKGBUILDDIR>>/tools-for-build'
cc -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -marm -march=armv5 -Wdate-time -D_FORTIFY_SOURCE=2 -I../src/runtime -Wl,-Bsymbolic-functions -Wl,-z,relro  determine-endianness.c  -ldl -o determine-endianness
cc: error: unrecognized -march target: armv5
cc: note: valid arguments are: armv4 armv4t armv5t armv5te armv5tej armv6 armv6j armv6k armv6z armv6kz armv6zk armv6t2 armv6-m armv6s-m armv7 armv7-a armv7ve armv7-r armv7-m armv7e-m armv8-a armv8.1-a armv8.2-a armv8.3-a armv8.4-a armv8.5-a armv8-m.base armv8-m.main armv8-r iwmmxt iwmmxt2 native; did you mean 'armv4'?

So, I propose to use armv7, that is the bare minimum required for Debian...

This might become RC when gcc-9 defaults, but I think the current binary is not really optimized for armhf, so I prefer to
have an higher severity.

Of course, no strange point from my side, so feel free to downgrade as you wish!



Reply to: