[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#998396: marked as done (FTBFS: very wrong python dependency)

Your message dated Wed, 03 Nov 2021 17:52:57 +0000
with message-id <E1miKRV-000HJC-Vz@fasolo.debian.org>
and subject line Bug#998396: fixed in python-boto3 1.19.9+dfsg-1
has caused the Debian Bug report #998396,
regarding FTBFS: very wrong python dependency
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
998396: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=998396
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: assimp
Version: 5.0.1~ds0-3
Tags: patch
Control: clone -1 -2
Control: retitle -2 rules-require-build-prerequisite gives bogus advice
Control: reassign -2 lintian
Control: severity -2 important
Control: tags -2 - patch
Control: affects -2 src:assimp
User: debian-cross@lists.debian.org
Usertags: ftcbfs
X-Debbugs-Cc: debhelper@packages.debian.org
X-Debbugs-Cc: debian-cross@lists.debian.org

assimp fails to cross build from source. It attempts to build a python
module, but it ultimately fails doing so. While inspecting this, I
discovered that assimp "Build-Depends: python3:any | python3-all:any |
python3-dev:any | python3-all-dev:any | dh-sequence-python3". This is
wrong on so many levels.

For starters, sbuild ignores any alternative in unstable, so in
practice, this happens to become "python3:any". Any other alternative is
simply ignored and shouldn't be there.

Then, issuing a dependency on python3-dev:any without libpython3-dev is
practically never correct. That could be a separate lintian tag, but
that's not too bad here as python3-dev isn't needed. Either you go
python3-dev or you go python3-dev:any, libpython3-dev or you have a very
special and unusual use case that I have never encountered anywhere.

Also listing dh-sequence-python3 there is bogus. You already added
"--with python3" in debian/rules. This is duplicate at best. Either
should be dropped, but enabling a dh-addon in an alternative is clearly
not right, and debhelper should likely fail hard when encountering that.
Niels, do you agree?

I wondered how one would come up with such a strange dependency and
asked #debian-mentors for help. Kindly, a user named "itd" pointed me at
the lintian tag rules-require-build-prerequisite, which very likely is
the cause for this. Please disable the tag right now as it does more
harm than good. While the tag isn't bad per-se, the advice it gives
misleads users and produces broken packages. I request hiding or
disabling it now and then figuring out what it really should say.

Back to assimp. I looked into this to make it cross buildable, right?
And it was failing in Python-ish stuff. So why do we actually build the
Python module? Did I say module? It's not an extension? No, it isn't.
And we really don't have to build it in an arch-only build. So the key
to making assimp cross buildable is to make an arch-only build fully
skip the Python stuff. And once you do that, you don't care about :any
annotations anymore as those are practically irrelevant in
Build-Depends-Indep.

So I've attached a patch for assimp to fix the cross build and the
strange build dependency. Please consider applying it.

Helmut

diff --minimal -Nru assimp-5.0.1~ds0/debian/changelog assimp-5.0.1~ds0/debian/changelog
--- assimp-5.0.1~ds0/debian/changelog	2021-10-06 09:02:14.000000000 +0200
+++ assimp-5.0.1~ds0/debian/changelog	2021-10-08 20:49:28.000000000 +0200
@@ -1,3 +1,15 @@
+assimp (5.0.1~ds0-3.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix python build dependency. (Closes: #-1)
+    + Alternatives in Build-Depends are ignored.
+    + Enable the python3 dh addon once only.
+    + Build python module in indep build only.
+    + Move python Build-Depends to B-D-I.
+    + Drop the :any nonsense.
+
+ -- Helmut Grohne <helmut@subdivi.de>  Fri, 08 Oct 2021 20:49:28 +0200
+
 assimp (5.0.1~ds0-3) unstable; urgency=medium
 
   [ Debian Janitor ]
diff --minimal -Nru assimp-5.0.1~ds0/debian/control assimp-5.0.1~ds0/debian/control
--- assimp-5.0.1~ds0/debian/control	2021-10-06 09:02:14.000000000 +0200
+++ assimp-5.0.1~ds0/debian/control	2021-10-08 20:49:28.000000000 +0200
@@ -15,8 +15,10 @@
  libstb-dev,
  libutfcpp-dev,
  zlib1g-dev | libz-dev,
- python3:any | python3-all:any | python3-dev:any | python3-all-dev:any | dh-sequence-python3,
  doxygen,
+Build-Depends-Indep:
+ dh-sequence-python3,
+ python3,
 Rules-Requires-Root: no
 Vcs-Git: https://salsa.debian.org/debian/assimp.git
 Vcs-Browser: https://salsa.debian.org/debian/assimp
diff --minimal -Nru assimp-5.0.1~ds0/debian/rules assimp-5.0.1~ds0/debian/rules
--- assimp-5.0.1~ds0/debian/rules	2021-10-06 09:02:14.000000000 +0200
+++ assimp-5.0.1~ds0/debian/rules	2021-10-08 20:49:28.000000000 +0200
@@ -33,7 +33,7 @@
 export PYBUILD_NAME=pyassimp
 
 %:
-	dh $@ --with python3 --buildsystem=cmake
+	dh $@ --buildsystem=cmake
 
 override_dh_auto_configure:
 	dh_auto_configure -- \
@@ -50,8 +50,10 @@
 
 override_dh_auto_build:
 	dh_auto_build
+ifneq ($(filter python3-pyassimp,$(shell dh_listpackages)),)
 	dh_auto_build --buildsystem=pybuild -- \
 		-d port/PyAssimp/
+endif
 	cd obj-$(DEB_HOST_GNU_TYPE)/doc && doxygen Doxyfile
 	cd doc && doxygen Doxyfile_Cmd
 
@@ -61,8 +63,10 @@
 
 override_dh_auto_install:
 	dh_auto_install
+ifneq ($(filter python3-pyassimp,$(shell dh_listpackages)),)
 	dh_auto_install --buildsystem=pybuild -- \
 		-d port/PyAssimp/
+endif
 	# IrrXML is not packaged for Debian, so drop the wrapper
 	find debian/*/usr -name irrXMLWrapper.h -delete

--- End Message ---
--- Begin Message --- 
Source: python-boto3
Source-Version: 1.19.9+dfsg-1
Done: Noah Meyerhans <noahm@debian.org>

We believe that the bug you reported is fixed in the latest version of
python-boto3, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 998396@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Noah Meyerhans <noahm@debian.org> (supplier of updated python-boto3 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 03 Nov 2021 10:29:48 -0700
Source: python-boto3
Architecture: source
Version: 1.19.9+dfsg-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Cloud Team <debian-cloud@lists.debian.org>
Changed-By: Noah Meyerhans <noahm@debian.org>
Closes: 998396
Changes:
 python-boto3 (1.19.9+dfsg-1) unstable; urgency=medium
 .
   * New upstream version 1.19.9+dfsg
   * fix python build dependency (Closes: 998396)
Checksums-Sha1:
 4303f914d7b9fee09d9a58502a53a513bfb00cb4 2119 python-boto3_1.19.9+dfsg-1.dsc
 df9ee18e502cc48ff56d982613da34f7a4d643bb 265060 python-boto3_1.19.9+dfsg.orig.tar.xz
 4ad9feac3893c165b69937d6d02dc181e4607aef 3880 python-boto3_1.19.9+dfsg-1.debian.tar.xz
 cc1e41a35e9314b84d2d7cf9589dc0dd4b2a5105 6763 python-boto3_1.19.9+dfsg-1_source.buildinfo
Checksums-Sha256:
 3c293335836289b31f34c1e89bbb52f8bf2a86fd926561a25f26e2e182dbee4a 2119 python-boto3_1.19.9+dfsg-1.dsc
 ca0815a1352d5be841333cf51cfc57fd1be8921e2a3e5c6749539b8dbe0df2da 265060 python-boto3_1.19.9+dfsg.orig.tar.xz
 5e65ef582cb8744aa7937586b58433051bbcfe338e0871c8bf62ed6ac0a02931 3880 python-boto3_1.19.9+dfsg-1.debian.tar.xz
 eabe93484cca48d46cc8ccf65b6d415da35f03cd9cb94361044cb081c09ed6fc 6763 python-boto3_1.19.9+dfsg-1_source.buildinfo
Files:
 c8e35c50e29e047acefa4ff971a36697 2119 python optional python-boto3_1.19.9+dfsg-1.dsc
 b7c57536f7cc630f278ff5e3e1f4f469 265060 python optional python-boto3_1.19.9+dfsg.orig.tar.xz
 553c7398739d9158d870a586bbcbe182 3880 python optional python-boto3_1.19.9+dfsg-1.debian.tar.xz
 da98200da93beac5449e8e08ed3e40da 6763 python optional python-boto3_1.19.9+dfsg-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJFBAEBCgAvFiEE65xaF5r2LDCTz+zyV68+Bn2yWDMFAmGCx4ARHG5vYWhtQGRl
Ymlhbi5vcmcACgkQV68+Bn2yWDOtAg//VuLNiCBRa7wNgouvETM8EFx3adeqb4e0
5nOjBOJhv6jCBHct32lNnTzVYxz+MpRPePorKvy1GSesnLpvhS5IFlTh3uquv1RQ
rUOuHNTbPkDFeksmRn4mKDvem8Cmi3De5+82KwtCZBkPXWEQs0nNeh4vN2nhxl9S
XWmzyBq+Dw02ablua4r4QPHZRjPeNtayAKZKOBRi1YEBaMIk4VBdmPJbxxxI2jNu
8H/r6Kr2mwkMNcQP9iOh5v/AefJrcsiUx4KgTtVAH5tFtmfPxykWqwOh3BZ7HoIR
gjnHJrTl+NFlcP5T2O7HgNKofnRRNjjdrK2WZGVgNswEsYDeKclqCcHOPpsjBe44
ubtHI/k7NcxQqKtFHkP5ZFLHJBTqOgVialyXhgHP0vfYUar4kSAtWdEd02HrgY5F
p0hsbaTbwreFmtyHzs97QIStCfet20njqlAK4LNEqMeK+vAKtLDON8yeOfS9m+od
Jggv4R4UJm9HSkuLCbfEe+9ok4mSL4YcgBKFLD9pLY5HlzXuWfzGGzHpOHvCgMjW
VijAq+3bq1KAGS0PnfmW8u2RcanREu8kKC5oX3EMTEuo+RIT+lMbv2Yh4ArHDwjX
DJiKyDNQqLqlceXXBEyegFL67XEnwEl1O8P2ZTnigxa3KX0GLXlJBDJaL4lGX5W0
BSdlA/VKB4I=
=kGya
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: